A small update to unify error handling during probe().
Signed-off-by: Oliver Neukum
---
drivers/usb/class/cdc-acm.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 1620542..2e5dea8 100644
--- a/drivers
7;s not, then to only way to go forward would be to always
> just use the svid in the name.
Yes, that is better. It makes more sense to use the number.
We'd get into versioning problems if we use names.
Regards
Oliver
--
To unsubscribe from this list:
On Wed, 2016-06-01 at 23:37 -0700, Guenter Roeck wrote:
> On 06/01/2016 11:24 PM, Oliver Neukum wrote:
> > On Wed, 2016-06-01 at 06:34 -0700, Guenter Roeck wrote:
> >> The class code would not explicitly learn about the reset,
> >> but it would be informed about the exi
On Wed, 2016-06-01 at 16:29 -0700, Guenter Roeck wrote:
> On Wed, Jun 01, 2016 at 11:26:09AM +0200, Oliver Neukum wrote:
> > On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote:
> > > Just noticed that the "active" file is for now read only, but it needs
> >
)
- it is a race against your own command
- it does not work if you are in basic USB mode
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at h
On Wed, 2016-06-01 at 08:48 -0400, Sandhya Bankar wrote:
> Use "foo *bar" instead of "foo * bar".
>
> Signed-off-by: Sandhya Bankar
Acked-by: Oliver Neukum
> ---
> drivers/usb/image/microtek.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(
SB persist we also need to restore data role
after S4.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ever, how do we learn that the other side has triggered a reset?
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
gt; On Tue, May 31, 2016 at 10:48:29AM +0200, Oliver Neukum wrote:
> > > > > On Tue, 2016-05-31 at 11:31 +0300, Heikki Krogerus wrote:
> > > > > > Hi Oliver,
> > > > > >
> > > > > > On Mon, May 30, 2016 at 03:59:27PM
On Tue, 2016-05-31 at 11:31 +0300, Heikki Krogerus wrote:
> Hi Oliver,
>
> On Mon, May 30, 2016 at 03:59:27PM +0200, Oliver Neukum wrote:
> > On Mon, 2016-05-30 at 16:19 +0300, Heikki Krogerus wrote:
> > > Hi guys,
> > >
> > > I'm attachin
t; [ 155.892061] BUG: unable to handle kernel paging request at 30303046
> [ 155.892101] IP: [] get_next_timer_interrupt+0x8a/0x290
>
> and then panic and the system is unresponsive.
Please try the attached patch.
Regards
Oliver
From 50a2b0b9e53cae8c4d608e672dd3db
this
> expected behaviour for ttyACM devices?
That is a bug. It is with a very old kernel. Can you replicate it with
the current kernel? If so, please provide information about where it
hangs. Sysrq-T will do that.
Regards
Oliver
--
To unsubscribe from this list: send
tricker reset? Why
> isn't it enough for the userspace to be able to enter/exit modes?
> Oliver! Can you please comment?
1. Because we need error handling.
Devices crash. Cables will crash. We will get out of sync.
You never put yourself in a place where you cannot handle an
IO e
live with that. But we just shouldn't share the responsibility of
> un/registering them between the class and the drivers, so the driver
> should then handle the registration always.
>
> Oliver, what do you think?
Either will do for me. Registration by the drivers is a bit better
it claims to be is left
to the individual drivers. If that cannot be done in kernel
space, the admin still can call a device trustworthy.
To guard the entropy pool against malicious spoof we assume
the quality of an unverified source's entropy to be 0.
Signed-off-by: Oliver Neukum
---
driver
evice. When the pen is out of range, we just
> don't get any URBs and don't do anything.
> Like all other mouses or input tablets, we don't use runtime PM.
>
> Signed-off-by: Martin Kepplinger
> ---
>
> Thanks for having a look. Any more suggestions on this?
>
n any case. I'm not sure about this approach. There is a
> question about it in the code. Please check it.
This approach looks workable.
An the whole the approach looks good, but needs to be extended.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2016-05-24 at 13:08 +0300, Heikki Krogerus wrote:
> Hi Guenter,
>
> On Mon, May 23, 2016 at 09:52:12AM -0700, Guenter Roeck wrote:
> > On Mon, May 23, 2016 at 05:55:04PM +0200, Oliver Neukum wrote:
> > > On Mon, 2016-05-23 at 07:43 -0700, Guenter Roeck wrote:
>
On Mon, 2016-05-23 at 10:09 -0700, Guenter Roeck wrote:
> On Mon, May 23, 2016 at 01:25:19PM +0200, Oliver Neukum wrote:
> > On Mon, 2016-05-23 at 12:57 +0300, Heikki Krogerus wrote:
> >
> > A reset is a generic function, so it does not belong to specific
> > drivers
On Mon, 2016-05-23 at 07:43 -0700, Guenter Roeck wrote:
> On 05/23/2016 06:58 AM, Oliver Neukum wrote:
> > Now I am confused. Are you saying that the choice of Alternate Mode does
> > not belong into user space?
> >
>
> No; sorry for the confusion. The above was me
nstead, with
> (currently)
> >> no means to report it to user space.
> >
> > Mode or role? I would say that the choice of alternate modes belongs
> to
>
> s/preferred mode/preferred role/g
Now I am confused. Are you saying that the choice of Alternate Mode does
no
On Mon, 2016-05-23 at 14:43 +0200, Martin Kepplinger wrote:
> Am 2016-05-23 um 14:26 schrieb Oliver Neukum:
> > On Mon, 2016-05-23 at 13:39 +0200, Martin Kepplinger wrote:
> >
> >> It's *really* fun to use as an input tablet though! So let's support th
Regards
Oliver
> +static int pegasus_probe(struct usb_interface *intf,
> + const struct usb_device_id *id)
> +{
> + struct usb_device *dev = interface_to_usbdev(intf);
> + struct usb_endpoint_descriptor *endpoint;
> + struc
On Mon, 2016-05-23 at 12:57 +0300, Heikki Krogerus wrote:
> Hi Oliver,
>
> On Fri, May 20, 2016 at 04:19:59PM +0200, Oliver Neukum wrote:
> > On Thu, 2016-05-19 at 15:44 +0300, Heikki Krogerus wrote:
> > > Like I've told some of you guys, I'm trying to imple
On Sun, 2016-05-22 at 08:54 -0700, Guenter Roeck wrote:
> Hi Oliver,
>
> On 05/20/2016 11:43 PM, Oliver Neukum wrote:
> > On Fri, 2016-05-20 at 22:51 -0700, Guenter Roeck wrote:
> >> On 05/20/2016 06:37 AM, Oliver Neukum wrote:
> >>> On Fri, 2016-05-20 a
On Fri, 2016-05-20 at 22:51 -0700, Guenter Roeck wrote:
> On 05/20/2016 06:37 AM, Oliver Neukum wrote:
> > On Fri, 2016-05-20 at 14:24 +0300, Heikki Krogerus wrote:
> >> On Thu, May 19, 2016 at 04:47:17PM +0200, Oliver Neukum wrote:
> >>>
> >>> Ple
The former problem we can address.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
in
> any case not affect the userspace interface proposed in this patch.
Is this strictly divorced from USB PD?
How do you trigger a cable reset or a USB PD reset?
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body
On Fri, 2016-05-20 at 14:24 +0300, Heikki Krogerus wrote:
> On Thu, May 19, 2016 at 04:47:17PM +0200, Oliver Neukum wrote:
> >
> > Please explain. How does that express DRP but prefered master?
>
> Sorry but I'm not sure what you mean here. If the port is capable of
>
add an entry matching your device.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2016-05-19 at 21:59 +0200, Oliver Neukum wrote:
> On Thu, 2016-05-19 at 12:52 -0700, Keith Packard wrote:
> > Oliver Neukum writes:
> >
> > > I think we would need to use a form of public key cryptography
> > > in the same manner used to verify authorshi
On Thu, 2016-05-19 at 12:52 -0700, Keith Packard wrote:
> Oliver Neukum writes:
>
> > I think we would need to use a form of public key cryptography
> > in the same manner used to verify authorship of emails. The host
> > would provide a nonce value that the device encry
> seems no real implementation yet)
How do we know the claimed TPM is a genuine TPM?
I think we would need to use a form of public key cryptography
in the same manner used to verify authorship of emails. The host
would provide a nonce value that the device encrypts and returns.
The host woul
d to create link to %s (%d)\n",
> + dev_name(dev), ret);
The attributes should be present as soon as the device is announced.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
Please explain. How does that express DRP but prefered master?
> I Hope I remembered to CC everybody interested.
Alternate modes can be left involuntarily. So we need a method of
notification.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
I've been going through the drivers with an eye on security.
And a question arose. How do we know that a device that claims
to be a chaoskey is really a chaoskey?
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" i
On Wed, 2016-05-18 at 12:16 +0300, Andrey Ryabinin wrote:
> 2016-05-18 11:18 GMT+03:00 Oliver Neukum :
> > On Wed, 2016-05-18 at 10:40 +0300, Andrey Ryabinin wrote:
> >> 2016-05-18 1:16 GMT+03:00 Greg Kroah-Hartman :
> >> > On Tue, May 17, 2016 at 05:52:40PM
r dereferenced or not.
That is a bold statement. Pointer arithmetic is defined. How can
the computation of an address be undefined behavior while it is
not used?
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2016-05-18 at 01:39 +0200, Bjørn Mork wrote:
> Oliver Neukum writes:
> > On Tue, 2016-05-17 at 21:24 +0200, Bjørn Mork wrote:
> >> Oliver Neukum writes:
> >>
> >> > On Fri, 2016-05-13 at 18:59 +0200, Bjørn Mork wrote:
> >> >> Bjørn
mplify the expression.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 2016-05-17 at 21:24 +0200, Bjørn Mork wrote:
> Oliver Neukum writes:
>
> > On Fri, 2016-05-13 at 18:59 +0200, Bjørn Mork wrote:
> >> Bjørn Mork writes:
> >>
> >> > The driver enforces a strict one-to-one relationship between the
> >&
st one notification is received, but I obviously
> have to test this theory thoroughly on all devices I have.
Hi,
I think the best approach would be to keep the interrupt URB always
active. I didn't do this to conserve bandwidth, but if it makes devices
work, it certainly would be the best
Allow for SS+ USB devices
Signed-off-by: Oliver Neukum
---
sound/usb/midi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/usb/midi.c b/sound/usb/midi.c
index 47de8af..7ba9292 100644
--- a/sound/usb/midi.c
+++ b/sound/usb/midi.c
@@ -911,6 +911,7 @@ static void
Allow handling SS+ USB devices correctly.
Signed-off-by: Oliver Neukum
---
sound/usb/card.c | 4
sound/usb/helper.c | 1 +
2 files changed, 5 insertions(+)
diff --git a/sound/usb/card.c b/sound/usb/card.c
index 3fc6358..69860da 100644
--- a/sound/usb/card.c
+++ b/sound/usb/card.c
Allow for SS+
Signed-off-by: Oliver Neukum
---
drivers/usb/misc/sisusbvga/sisusb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/misc/sisusbvga/sisusb.c
b/drivers/usb/misc/sisusbvga/sisusb.c
index a22de52..15666ad 100644
--- a/drivers/usb/misc/sisusbvga
Allow for SS+
Signed-off-by: Oliver Neukum
---
drivers/usb/misc/sisusbvga/sisusb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/misc/sisusbvga/sisusb.c
b/drivers/usb/misc/sisusbvga/sisusb.c
index a22de52..15666ad 100644
--- a/drivers/usb/misc/sisusbvga
Allow for SS+ USB
Signed-off-by: Oliver Neukum
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c
index
Allow for SS+ USB
Signed-off-by: Oliver Neukum
---
drivers/net/usb/r8152.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index d1f78c2..3f9f6ed 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -3366,7
Allow for SS+ USB
Signed-off-by: Oliver Neukum
---
drivers/net/usb/usbnet.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 4f08426..bc46ef9 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -355,6 +355,7
Allow for SS+
Signed-off-by: Oliver Neukum
---
drivers/usb/misc/sisusbvga/sisusb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/misc/sisusbvga/sisusb.c
b/drivers/usb/misc/sisusbvga/sisusb.c
index a22de52..15666ad 100644
--- a/drivers/usb/misc/sisusbvga
Allow for SS+
Signed-off-by: Oliver Neukum
---
drivers/usb/misc/sisusbvga/sisusb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/misc/sisusbvga/sisusb.c
b/drivers/usb/misc/sisusbvga/sisusb.c
index a22de52..15666ad 100644
--- a/drivers/usb/misc/sisusbvga
If a port can do 10 Gb/s the kernel should say so.
The corresponding check needs to be added.
Signed-off.by: Oliver Neukum >
---
drivers/usb/core/hub.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index 38cc4ba..c2270d8 100644
--
LTM is also defined for SS+. The correct test is to check for anything
slower than SS not exactly SS.
Signed-off-by: Oliver Neukum
---
include/linux/usb.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/usb.h b/include/linux/usb.h
index 6a9a0c2..29aba760 100644
SS+ also expresses intervals in units of 125ms. Testing must
be for SS or faster, not SS exactly.
Signed-off-by: Oliver neukum
---
include/linux/usb.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/usb.h b/include/linux/usb.h
index 29aba760..7824f45 100644
It looks to me like the tests for LTM and the units of intervals
for periodic transfers used ==USB_SPEED_SUPER where >=USB_SPEED_SUPER
should have been used.
Oliver Neukum (2):
USB: LTM also for USB 3.1
USB: correct intervals for SS+
include/linux/usb.h | 6 +++---
1 file changed
Hi,
I got more patches to improve throughput
but I cannot test them.
Regards
From b32c2f840c1ff0d0e93b627eb07b2fdc11f37bb5 Mon Sep 17 00:00:00 2001
From: Oliver Neukum
Date: Thu, 25 Feb 2016 12:20:12 +0100
Subject: [PATCH 1/4] chaoskey: O_NONBLOCK in concurrent reads
This changes the
Now that the common parser resides in USB core, it can
be used for CDC-WDM.
Signed-off-by: Oliver Neukum
---
drivers/usb/class/cdc-wdm.c | 29 +
1 file changed, 5 insertions(+), 24 deletions(-)
diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c
Hi,
after trying to use the common parser drivers which don't depend on usbnet
I ended up in dependency hell. Having this code live in usbnet just
doesn't make sense. I toyed with the idea of turning it into a module
of its own, but that collides with the purpose of saving space.
--
To unsubscrib
A small update to unify error handling during probe().
Signed-off-by: Oliver Neukum
---
drivers/usb/class/cdc-acm.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c
index 6d82257..8268860 100644
--- a/drivers
The dependencies were impossible to handle preventing
drivers for CDC devices not which are not network drivers
from using the common parser.
Signed-off-by: Oliver Neukum
---
drivers/net/usb/usbnet.c | 138
drivers/usb/core/message.c | 153
This introduces the common parser for extra CDC headers now that it no longer
depends on usbnet.
Signed-off-by: Oliver Neukum
---
drivers/usb/class/cdc-acm.c | 60 +++--
1 file changed, 3 insertions(+), 57 deletions(-)
diff --git a/drivers/usb/class/cdc
tend that there is a second bus for slower than
SuperSpeed.
HTH
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
heline_aligned would be the maximum possible for a given
> build/architecture. If not, what is the value of having
> cacheline_aligned in the first place ?
I thought it was for performance to prevent cache bouncing.
I honestly don't know. You'd have to ask a specific question
on
On Mon, 2016-04-18 at 06:57 -0700, Guenter Roeck wrote:
> On 04/18/2016 01:32 AM, Oliver Neukum wrote:
> > On Mon, 2016-04-18 at 03:53 +0100, Alexey Klimov wrote:
> >> This patch creates new driver that supports StreamLabs usb watchdog
> >> device. This device plug
red a cacheline for DMA but somebody tries taking
the lock. Then the cacheline with the lock is read from RAM. If that
happens before you finish the DMA the data resulting from DMA is lost.
The fix is to allocate the buffer with its own allocation. The VM
subsystem makes sure separate allocation
d say per
device ID quirks as UAS does is the way to go.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
an come up with an RFC patch if noone else does in the mean
> time.
Copy the code uas.c provides.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
be added and in this
particular case we ought to add the whole vendor to the lst.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
g tool.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
imited to 2048 sectors. This gives us
> + * better throughput on most devices.
> + */
> + blk_queue_max_hw_sectors(sdev->request_queue, 2048);
Should we really test for speed rather than USB version?
Regards
Oliver
--
To unsubscribe from this
/* Disable all notifications */
> + ucsi_acpi_cmd(ucsi, UCSI_SET_NOTIFICATION_ENABLE);
You remove the handler before you disable notifications?
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
e crash and
> the dmesg showing the problem.
Hi,
thank you for reporting this. You are the second one to report it.
I send a fix upstream last week.
Greg, can we merge this for the next rc? People are hitting this
bug.
Regards
Oliver
--
To unsubscribe from this list: send
estion is why udevd feeding
back events to the audit subsystem is inferior to the kernel
itself generating audit events.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
Under some circumstances acm_tty_flush_chars() is called
with no buffer to flush. We simply need to do nothing.
Signed-off-by: Oliver Neukum
Reported-by: Torsten Hilbrich
---
drivers/usb/class/cdc-acm.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/class/cdc-acm.c b
Under some circumstances acm_tty_flush_chars() is called
with no buffer to flush. We simply need to do nothing.
Signed-off-by: Oliver Neukum
Reported-by: Torsten Hilbrich
---
drivers/usb/class/cdc-acm.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/usb/class/cdc-acm.c b
On Mon, 2016-04-04 at 12:31 +0200, Torsten Hilbrich wrote:
> commit a81cf9799ad7299b03a4dff020d9685f9ac5f3e0
> Author: Oliver Neukum
> Date: Wed Feb 10 10:39:49 2016 +0100
>
> cdc-acm: implement put_char() and flush_chars()
Hi,
does this fix the issue?
unsigned char *buffer;
> int r;
> - const unsigned size = 8;
> + const unsigned size = 2;
Are you sure only 2 are used?
For the amount of space needed it makes no difference.
Regards
Oliver
--
To unsubscribe from this list: send the line
t
is add_device(), and provide a method in the generic device structure
for providing information to the audit subsystem.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi,
do I need to resubmit the serial fixes I submitted for
the issues with the forged device descriptors leading
to crashes?
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kerne
right? I suggest buying a new keyboard, it's going
> to be much cheaper in the end.
>
> good luck!
Your hub's firmware is broken. How many physical ports does it have?
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linu
A T430 is reported to also need XHCI_SLOW_SUSPEND, lest a power
off turn into a reboot.
Signed-off-by: Oliver Neukum
---
drivers/usb/host/xhci-pci.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index f0640b7
I have a report of a T430 laptop needing this unless you want
shut downs turn into reboot. Is there any hope of investigating this
further at Intel, or do we go for the cautious approach?
Oliver Neukum (1):
xhci: one more quirk for PANTHERPOINT
drivers/usb/host/xhci-pci.c | 4 +++-
1 file
_status_suspended().
I guess we are in violent agreement though we were unaware of being
in that state.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo in
The device can now easily be derived from the interface.
Stop leaving a private copy.
Signed-off-by: Oliver Neukum
---
drivers/input/tablet/kbtab.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/input/tablet/kbtab.c b/drivers/input/tablet/kbtab.c
index
We now have a macro to easily get to the USB device from the interface.
So we are cleaning up all drivers to not store a private pointer.
Oliver Neukum (4):
acecad: stop saving struct usb_device
aiptek: stop saving struct usb_device
gtco: stop saving struct usb_device
kbtab: stop saving
The device can now easily be derived from the interface.
Stop leaving a private copy.
Signed-off-by: Oliver Neukum
---
drivers/input/tablet/acecad.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/input/tablet/acecad.c b/drivers/input/tablet/acecad.c
The device can now easily be derived from the interface.
Stop leaving a private copy.
Signed-off-by: Oliver Neukum
---
drivers/input/tablet/aiptek.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/input/tablet/aiptek.c b/drivers/input/tablet
The device can now easily be derived from the interface.
Stop leaving a private copy.
Signed-off-by: Oliver Neukum
---
drivers/input/tablet/gtco.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/input/tablet/gtco.c b/drivers/input/tablet
ly different issues.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
During the initialisation that driver uses a buffer on the stack
for DMA. That violates the cache coherency rules. The fix is to
allocate the buffer with kmalloc().
Signed-off-by: Oliver Neukum
---
drivers/input/touchscreen/sur40.c | 20
1 file changed, 12 insertions(+), 8
On Mon, 2016-03-21 at 15:30 -0400, Alan Stern wrote:
> On Mon, 21 Mar 2016, Oliver Neukum wrote:
>
> > We have an autosuspend timeout because we think that IO, if it will
> > come at all, is likeliest to come soon. If, however, the IO is
> > periodic that heuristics is
t, please
contact your vendor.
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 2016-03-21 at 11:46 -0400, Alan Stern wrote:
> On Mon, 21 Mar 2016, Oliver Neukum wrote:
>
> > On Fri, 2016-03-18 at 12:36 -0400, Alan Stern wrote:
> >
> > Almost. In case of reset_resume() it makes no sense to still
> > clear a halt or execute a re
On Mon, 2016-03-21 at 14:24 -0400, Alan Stern wrote:
> On Mon, 21 Mar 2016, Oliver Neukum wrote:
>
> > On Mon, 2016-03-21 at 10:57 -0400, Alan Stern wrote:
> >
> > > One possible solution is to export a sysfs parameter to prevent
> > > statistics collecti
is
information down?
Regards
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
The driver can be crashed with devices that expose crafted
descriptors with too few endpoints.
See:
http://seclists.org/bugtraq/2016/Mar/61
Signed-off-by: Oliver Neukum
v1 - added sanity checks
v2 - moved them to probe() to fix problems Johan pointed out
---
drivers/usb/serial
An attack using the lack of sanity checking in probe
is known. This patch checks for the existance of a
second port.
CVE-2016-3136
Signed-off-by: Oliver Neukum
CC: sta...@vger.kernel.org
v1 - add sanity check for presence of a second port
v2 - add sanity check for an interrupt endpoint
On Thu, 2016-03-17 at 10:47 -0400, Johan Hovold wrote:
> This looks like you just resent v1 (again, please include the revision
> in the mail Subject).
Indeed. Wrong directory.
Sorry
Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-
An attack using the lack of sanity checking in probe
is known. This patch checks for the existance of a
second port.
CVE-2016-3136
Signed-off-by: Oliver Neukum
CC: sta...@vger.kernel.org
v1 - add sanity check for presence of a second port
v2 - add sanity check for an interrupt endpoint
gt;reset_resume(hid);
Almost. In case of reset_resume() it makes no sense to still
clear a halt or execute a reset that had been ordered. The
corresponding flags should be cleared.
And now that I think of it, if while restarting IO an
old error condition is detected shouldn't the restart
801 - 900 of 2090 matches
Mail list logo
