Re: [PATCH v2] dt-bindings: usb: renesas_gen3: Rename bindings documentation file to reflect IP block

2019-08-19 Thread Simon Horman
On Sat, Aug 10, 2019 at 01:14:55PM +0200, Greg Kroah-Hartman wrote: > On Sat, Aug 10, 2019 at 08:40:15AM +0200, Geert Uytterhoeven wrote: > > Hi Simon, > > > > On Fri, Aug 9, 2019 at 11:37 PM Simon Horman > > wrote: > > > For consistency with the naming of

[PATCH v2] dt-bindings: usb: renesas_gen3: Rename bindings documentation file to reflect IP block

2019-08-09 Thread Simon Horman
is to more accurately reflect the IP block documented in this file. Signed-off-by: Simon Horman Reviewed-by: Geert Uytterhoeven --- * Based on v5.3-rc1 v2 * Add review tag * Correct changelog --- .../devicetree/bindings/usb/{renesas,usb3.txt => renesas,usb3-peri.txt} | 0 1 file changed

Re: [PATCH] usb: host: xhci-rcar: Fix timeout in xhci_suspend()

2019-08-09 Thread Simon Horman
: xhci-plat: set resume_quirk() for R-Car > controllers") > Cc: # v4.12+ > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman > --- > drivers/usb/host/xhci-rcar.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drive

PARTNERSHIP REQUEST,

2019-08-06 Thread Simon Beron
of 30% only If you agree to assist me, i will like to know if the commission is ok for you, also i would love to know more about you too. Get Back to me without delay if you are interested Yours Faithfully Simon Beron.

Re: [PATCH] dt-bindings: usb: renesas_gen3: Rename bindings documentation file to reflect IP block

2019-08-01 Thread Simon Horman
On Thu, Aug 01, 2019 at 11:18:36AM +0200, Geert Uytterhoeven wrote: > On Thu, Aug 1, 2019 at 11:13 AM Simon Horman > wrote: > > For consistency with the naming of (most) other documentation files for DT > > bindings for Renesas IP blocks rename the Renesas USB3.0 peripheral

Re: [PATCH v2 2/2] dt-bindings: usb: renesas_gen3: Rename bindings documentation file

2019-08-01 Thread Simon Horman
On Mon, Jul 29, 2019 at 08:25:24AM +, Yoshihiro Shimoda wrote: > Hi Simon-san, > > > From: Simon Horman, Sent: Monday, July 29, 2019 5:15 PM > > > > > > > Unfortunately the previous version has already made it into usb-next > > > > > > 23c4

[PATCH] dt-bindings: usb: renesas_gen3: Rename bindings documentation file to reflect IP block

2019-08-01 Thread Simon Horman
is to to more accurately reflect the IP block documented in this file. Signed-off-by: Simon Horman --- * Based on v5.3-rc1 --- .../devicetree/bindings/usb/{renesas,usb3.txt => renesas,usb3-peri.txt} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename Documentation/devicetree/bindi

Re: [PATCH v2 2/2] dt-bindings: usb: renesas_gen3: Rename bindings documentation file

2019-07-29 Thread Simon Horman
On Fri, Jul 26, 2019 at 01:22:48AM +, Yoshihiro Shimoda wrote: > Hi Greg, > > > From: Greg Kroah-Hartman, Sent: Thursday, July 25, 2019 6:10 PM > > > > On Thu, Jul 11, 2019 at 10:03:03AM +0200, Simon Horman wrote: > > > On Wed, Jul 03, 2019 at 02:28:51P

Re: [PATCH v2 2/2] dt-bindings: usb: renesas_gen3: Rename bindings documentation file

2019-07-11 Thread Simon Horman
On Wed, Jul 03, 2019 at 02:28:51PM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Wed, Jul 3, 2019 at 10:35 AM Simon Horman > wrote: > > For consistency with the naming of (most) other documentation files for DT > > bindings for Renesas IP blocks rename the R

Re: [PATCH v2] usb: renesas_usbhs: Use specific struct instead of USBHS_TYPE_* enums

2019-05-15 Thread Simon Horman
On Wed, May 15, 2019 at 06:57:17AM +, Yoshihiro Shimoda wrote: > Hi Simon-san, > > > From: Simon Horman, Sent: Monday, May 13, 2019 9:01 PM > > > > On Mon, May 13, 2019 at 11:40:29AM +0900, Yoshihiro Shimoda wrote: > > > This patch adds a specific struct

Re: [PATCH v3 12/15] dt-bindings: usb: renesas_usbhs: Add support for r7s9210

2019-05-15 Thread Simon Horman
On Tue, May 14, 2019 at 09:56:02AM -0500, Chris Brandt wrote: > Add support for r7s9210 (RZ/A2M) SoC > > Signed-off-by: Chris Brandt Reviewed-by: Simon Horman

Re: [PATCH v3 11/15] usb: renesas_usbhs: Add support for RZ/A2

2019-05-15 Thread Simon Horman
On Tue, May 14, 2019 at 09:56:01AM -0500, Chris Brandt wrote: > The RZ/A2 is similar to the R-Car Gen3 with some small differences. > > Signed-off-by: Chris Brandt Reviewed-by: Simon Horman

Re: [PATCH v3 10/15] usb: renesas_usbhs: support byte addressable CFIFO

2019-05-15 Thread Simon Horman
t Reviewed-by: Simon Horman

Re: [PATCH v3 03/15] phy: renesas: rcar-gen3-usb2: detect usb_x1 clock

2019-05-15 Thread Simon Horman
On Tue, May 14, 2019 at 09:55:53AM -0500, Chris Brandt wrote: > The RZ/A2 has an optional dedicated 48MHz clock input for the PLL. > If a clock node named 'usb_x1' exists and set to non-zero, then we can > assume we want it use it. > > Signed-off-by: Chris Brandt Reviewed-by: Simon Horman

Re: [PATCH v3 05/15] phy: renesas: rcar-gen3-usb2: Check dr_mode when not using OTG

2019-05-15 Thread Simon Horman
On Tue, May 14, 2019 at 09:55:55AM -0500, Chris Brandt wrote: > When not using OTG, the PHY will need to know if it should function as > host or peripheral by checking dr_mode in the PHY node (not the parent > controller node). > > Signed-off-by: Chris Brandt Reviewed-by: Simon Horman

Re: [PATCH v3 04/15] dt-bindings: rcar-gen3-phy-usb2: Document use of usb_x1

2019-05-15 Thread Simon Horman
On Tue, May 14, 2019 at 09:55:54AM -0500, Chris Brandt wrote: > Document the USB_X1 input and add clock-names to identify > functional and USB_X1 clocks. > > Signed-off-by: Chris Brandt Reviewed-by: Simon Horman

Re: [PATCH v3 06/15] dt-bindings: rcar-gen3-phy-usb2: Document dr_mode

2019-05-15 Thread Simon Horman
On Tue, May 14, 2019 at 09:55:56AM -0500, Chris Brandt wrote: > Document the optional dr_mode property > > Signed-off-by: Chris Brandt Reviewed-by: Simon Horman

Re: [PATCH v3 07/15] dt-bindings: rcar-gen3-phy-usb2: Add r7s9210 support

2019-05-15 Thread Simon Horman
On Tue, May 14, 2019 at 09:55:57AM -0500, Chris Brandt wrote: > Document RZ/A2 (R7S9210) SoC bindings. > > Signed-off-by: Chris Brandt Reviewed-by: Simon Horman

Re: [PATCH v3 09/15] usb: renesas_usbhs: add support for CNEN bit

2019-05-15 Thread Simon Horman
On Tue, May 14, 2019 at 09:55:59AM -0500, Chris Brandt wrote: > For some SoC, CNEN must be set for USB Device mode operation. > > Signed-off-by: Chris Brandt Reviewed-by: Simon Horman

Re: [PATCH v3 08/15] usb: renesas_usbhs: move flags to param

2019-05-15 Thread Simon Horman
On Tue, May 14, 2019 at 09:55:58AM -0500, Chris Brandt wrote: > Move options from 'flags' field in private structure to param structure > where other options are already being kept. > > Signed-off-by: Chris Brandt Reviewed-by: Simon Horman

Re: [PATCH v3 02/15] ARM: dts: rza2mevb: Add 48MHz USB clock

2019-05-15 Thread Simon Horman
On Wed, May 15, 2019 at 09:43:02AM +0200, Geert Uytterhoeven wrote: > Hi Chris, > > On Tue, May 14, 2019 at 4:57 PM Chris Brandt wrote: > > The RZ/A2M EVB has a 48MHz clock attached to USB_X1. > > > > Signed-off-by: Chris Brandt > > Reviewed-by: Simo

Re: [PATCH v3 01/15] ARM: dts: r7s9210: Add USB clock

2019-05-15 Thread Simon Horman
On Wed, May 15, 2019 at 09:38:32AM +0200, Geert Uytterhoeven wrote: > On Tue, May 14, 2019 at 4:56 PM Chris Brandt wrote: > > Add USB clock node. If present, this clock input must be 48MHz. > > > > Signed-off-by: Chris Brandt > > Reviewed-by: Simon Horman > >

Re: [PATCH v2 01/15] ARM: dts: r7s9210: Add USB clock

2019-05-13 Thread Simon Horman
On Thu, May 09, 2019 at 03:11:28PM -0500, Chris Brandt wrote: > Add USB clock node. If present, this clock input must be 48MHz. > > Signed-off-by: Chris Brandt Thanks, This looks fine to me but I will wait to see if there are other reviews before applying. Reviewed-by: Simon Horman

Re: [PATCH v2 02/15] ARM: dts: rza2mevb: Add 48MHz USB clock

2019-05-13 Thread Simon Horman
On Thu, May 09, 2019 at 03:11:29PM -0500, Chris Brandt wrote: > The RZ/A2M EVB has a 48MHz clock attached to USB_X1. > > Signed-off-by: Chris Brandt Thanks, This looks fine to me but I will wait to see if there are other reviews before applying. Reviewed-by: Simon Horman

Re: [PATCH v2] usb: renesas_usbhs: Use specific struct instead of USBHS_TYPE_* enums

2019-05-13 Thread Simon Horman
i Shimoda-san, the minor suggestion below not withstanding this looks good to me. Reviewed-by: Simon Horman > --- > Changes from v1 [1]: > - Use sizeof(variable) instead of sizeof(type). > - Add Geert-san's reviewed-by (thanks!). > > [1] > https://patchwork.kernel.org/patch

Re: [PATCH 0/4] Add USB-HOST support to cat874

2019-03-06 Thread Simon Horman
On Fri, Mar 01, 2019 at 11:05:44AM +, Fabrizio Castro wrote: > While trying to add USB-HOST support to the cat874 board, > it came up that of_usb_get_dr_mode_by_phy was selecting > the wrong DT node to use for dr_mode. > Also, drivers/phy/renesas/phy-rcar-gen3-usb2.c was registering > IRQs, no

Re: [PATCH 0/9] Add USB3.0 and TI HD3SS3220 driver support

2019-03-06 Thread Simon Horman
On Wed, Mar 06, 2019 at 09:07:17AM +, Biju Das wrote: > This series adds USB 3.0 support for the CAT874 platform, including a > new driver for the TI HD3SS3220 USB Type-C DRP port controller. > > This patch series supports: > 1) Host hotplug operation > 2) Device hot plug operation > 3) USB ty

Re: Location of HUB USB Report Descriptors?

2019-02-14 Thread Simon Wood
can just copy > the code in lsusb. I will attempt coding something, or take some other approach in my investigations. Thank you both so much for your replies, Simon

Re: Location of HUB USB Report Descriptors?

2019-02-14 Thread Simon Wood
On Thu, February 14, 2019 9:42 am, Greg KH wrote: > That's because Android is using toybox's version of 'lsusb'. I > recommend using the real version if you need this information. I would if I could, I do not control the BSP for this hardware :-( >> I have found the 'descriptors' file for the U

Location of HUB USB Report Descriptors?

2019-02-14 Thread Simon Wood
9 Hub bDeviceSubClass 0 Unused bDeviceProtocol 0 Full speed (or root) hub bMaxPacketSize064 bNumConfigurations 1 Device Status: 0x0001 Self Powered -- Many thanks in advance, Simon. 12 01 10 02 09 00 02 40 E3 05 10 06 03 93 01 02 ...@ã... 0010 0

Re: [PATCH] usb: renesas_usbhs: replace udelay() with usleep_range()

2019-01-17 Thread Simon Horman
the .hardware_init() and .power_ctrl() will run on NON-ATOMIC > CONTEXT, this patch replaces udelay() with usleep_range(). > > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman

Re: [PATCH] usb: gadget: udc: renesas_usb3: add support for r8a774c0

2018-12-16 Thread Simon Horman
On Thu, Dec 13, 2018 at 08:23:55PM +, Fabrizio Castro wrote: > RZ/G2E USB 3.0 implementation is like the one found on R-Car E3, > therefore add the same quirk. > > Signed-off-by: Fabrizio Castro Reviewed-by: Simon Horman

Re: [PATCH] usb: gadget: udc: renesas_usb3: Add bindings for r8a774c0

2018-12-16 Thread Simon Horman
On Thu, Dec 13, 2018 at 08:22:18PM +, Fabrizio Castro wrote: > Document RZ/G2E (R8A774C0) SoC bindings. > > Signed-off-by: Fabrizio Castro Reviewed-by: Simon Horman

Re: [PATCH] dt-bindings: usb: renesas_usbhs: Add r8a774c0 support

2018-12-15 Thread Simon Horman
On Thu, Dec 13, 2018 at 08:21:03PM +, Fabrizio Castro wrote: > Document RZ/G2E (R8A774C0) SoC bindings. > > Signed-off-by: Fabrizio Castro Reviewed-by: Simon Horman

Re: [PATCH] usb: renesas_usbhs: add support for RZ/G2E

2018-12-15 Thread Simon Horman
in a similar fashion to what was done for the > r8a77990. > > Signed-off-by: Fabrizio Castro Reviewed-by: Simon Horman

Re: [PATCH] dt-bindings: usb-xhci: Add r8a774c0 support

2018-12-14 Thread Simon Horman
On Thu, Dec 13, 2018 at 08:21:11PM +, Fabrizio Castro wrote: > Document RZ/G2E (R8A774C0) SoC bindings. > > Signed-off-by: Fabrizio Castro Reviewed-by: Simon Horman

Re: Logitech G27 leds no more supported

2018-10-23 Thread Simon Wood
g all leds simultaneously */ struct led_classdev *led[SRWS1_NUMBER_LEDS + 1]; }; #endif -- Cheers, Simon https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/leds/Kconfig?h=v4.19 -- config LEDS_SYSCON bool "LED support for LEDs on system controllers" d

Re: Logitech G27 leds no more supported

2018-10-19 Thread Simon Wood
On Fri, October 19, 2018 4:46 pm, Simon Wood wrote: > Thanks for the report, and yes it does seem broken. I tried on > 4.17.0-rc5+ > and it seems that the 'hid-logitech' module does not know the device ID of > the G29 anymore. Oh, how easily we forget things... there'

Re: Logitech G27 leds no more supported

2018-10-19 Thread Simon Wood
20, but that was a long time ago and it seems that the 'hid-core.c' stuff has somewhat changed Will continue looking for cause. Simon Syslog on insert -- Oct 19 16:16:04 thevoid kernel: [33656.156644] usb 1-2: new full-speed USB device number 12 using xhci_hcd Oct 19 16:16:05 thevo

Re: [PATCH] usb: gadget: udc: renesas_usb3: Fix b-device mode for "workaround"

2018-10-04 Thread Simon Horman
he b-device mode is disabled. To fix the issue, this patch > adds usb_disconnect() calling in renesas_usb3_b_device_write() > if workaround_for_vbus is true. > > Fixes: 43ba968b00ea ("usb: gadget: udc: renesas_usb3: add debugfs to set the > b-device mode") > Cc: # v4

Re: [PATCH] dt-bindings: usb-xhci: Document r8a7744 support

2018-10-01 Thread Simon Horman
On Thu, Sep 27, 2018 at 02:42:38PM +0100, Biju Das wrote: > Document r8a7744 xhci support. The driver will use the fallback > compatible string "renesas,rcar-gen2-xhci", therefore no driver > change is needed. Reviewed-by: Simon Horman

Re: [PATCH] dt-bindings: usb: renesas_usbhs: Add support for r8a7744

2018-10-01 Thread Simon Horman
On Thu, Sep 27, 2018 at 02:01:16PM +0100, Biju Das wrote: > Document support for RZ/G1N (R8A7744) SoC. > > Signed-off-by: Biju Das > Reviewed-by: Chris Paterson Reviewed-by: Simon Horman

Re: [PATCH 0/5] usb: renesas_usbhs: use otg mode and add support for R-Car E3

2018-09-25 Thread Simon Horman
for R-Car D3 and E3, we need the following > patch set. Otherwize, the mode will not be changed to peripheral mode > by the phy's COMMCTRL register: > https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=21629 Reviewed-by: Simon Horman

Re: [PATCH 2/2] dt-bindings: usb: ohci: Add clocks description for R-Car Gen3

2018-09-11 Thread Simon Horman
On Mon, Sep 10, 2018 at 08:15:48PM +0900, Yoshihiro Shimoda wrote: > This patch adds detailed information of an optional property "clocks" > description for R-Car Gen3. > > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman

Re: [PATCH 1/2] dt-bindings: usb: ehci: Add clocks description for R-Car Gen3

2018-09-11 Thread Simon Horman
On Mon, Sep 10, 2018 at 08:15:47PM +0900, Yoshihiro Shimoda wrote: > This patch adds detailed information of an optional property "clocks" > description for R-Car Gen3. > > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman

Re: [PATCH/RFC v3 3/4] usb: gadget: udc: renesas_usb3: use usb role switch API

2018-05-15 Thread Simon Horman
On Tue, May 15, 2018 at 08:02:00AM +, Yoshihiro Shimoda wrote: > Hi Simon-san, > > Thank you for your review! > > > From: Simon Horman, Sent: Tuesday, May 15, 2018 4:54 PM > > On Mon, May 14, 2018 at 06:15:59PM +0900, Yoshihiro Shimoda wrote: > > > &g

Re: [PATCH v2 6/6] usb: gadget: udc: renesas_usb3: disable the controller's irqs for reconnecting

2018-05-15 Thread Simon Horman
On Tue, May 15, 2018 at 07:49:44AM +, Yoshihiro Shimoda wrote: > Hi Simon-san, > > Thank you for your review! > > > From: Simon Horman, Sent: Tuesday, May 15, 2018 4:35 PM > > > > On Tue, Apr 10, 2018 at 02:38:54PM +0900, Yoshihiro Shimoda wrote: > &

Re: [PATCH/RFC v3 3/4] usb: gadget: udc: renesas_usb3: use usb role switch API

2018-05-15 Thread Simon Horman
On Mon, May 14, 2018 at 06:15:59PM +0900, Yoshihiro Shimoda wrote: > This patch uses usb role switch API if the register suceeeded. > > Signed-off-by: Yoshihiro Shimoda > --- > drivers/usb/gadget/udc/renesas_usb3.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a

Re: [PATCH v2 6/6] usb: gadget: udc: renesas_usb3: disable the controller's irqs for reconnecting

2018-05-15 Thread Simon Horman
On Tue, Apr 10, 2018 at 02:38:54PM +0900, Yoshihiro Shimoda wrote: > This patch fixes an issue that reconnection is possible to fail > because unexpected state handling happens by the irqs. To fix the issue, > the driver disables the controller's irqs when disconnected. > > Fixes: 746bfe63bba3 ("u

Re: [PATCH v2 5/6] usb: gadget: udc: renesas_usb3: should fail if devm_phy_get() returns error

2018-05-15 Thread Simon Horman
optional_get(). > > Reported-by: Simon Horman > Fixes: 279d4bc64060 ("usb: gadget: udc: renesas_usb3: add support for generic > phy") > Cc: # v4.15+ > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman > --- > Remarks: > - A new file in v

Re: [PATCH v1 0/2] usb: dwc2: gadget: Fixes for LPM

2018-05-07 Thread Simon Shields
Hi Grigor, On Wed, May 02, 2018 at 10:12:27AM +, Grigor Tovmasyan wrote: > Hi Simon, > > On 4/21/2018 4:52 PM, Simon Shields wrote: > > Hi Grigor, > > > > On Fri, Apr 20, 2018 at 01:00:16PM +, Grigor Tovmasyan wrote: > >> Hi Simon, > >> &

Re: [PATCH v1 0/2] usb: dwc2: gadget: Fixes for LPM

2018-04-21 Thread Simon Shields
Hi Grigor, On Fri, Apr 20, 2018 at 01:00:16PM +, Grigor Tovmasyan wrote: > Hi Simon, > > On 4/19/2018 8:31 PM, Simon Shields wrote: > > Hi all, > > > > On 10/04/2018 10:21 PM, Grigor Tovmasyan wrote: > >> Here are two little fixes for LPM feature. > &g

Re: [PATCH v1 0/2] usb: dwc2: gadget: Fixes for LPM

2018-04-19 Thread Simon Shields
e source. I'm not really sure how to debug this any further (vendor kernel releases contain no mention of LPM in the gadget drivers), so any pointers in that direction would be much appreciated. Cheers, Simon -- To unsubscribe from this list: send the line "unsubscribe linux-us

Re: [PATCH 1/2] usb: gadget: udc: renesas_usb3: add property "renesas,ignore-id"

2018-04-11 Thread Simon Horman
On Tue, Apr 10, 2018 at 09:13:53PM +0900, Yoshihiro Shimoda wrote: > This patch adds a new property to ignore the ID signal on a board. > > Signed-off-by: Yoshihiro Shimoda > --- > Documentation/devicetree/bindings/usb/renesas_usb3.txt | 2 ++ > drivers/usb/gadget/udc/renesas_usb3.c

Re: [PATCH 4/4] usb: gadget: udc: renesas_usb3: should call devm_phy_get() before add udc

2018-04-11 Thread Simon Horman
On Tue, Apr 10, 2018 at 09:44:31AM +, Yoshihiro Shimoda wrote: > Hi Simon-san, > > > From: Simon Horman, Sent: Tuesday, April 10, 2018 6:34 PM > > > > On Tue, Apr 10, 2018 at 01:28:33AM +, Yoshihiro Shimoda wrote: > > > Hi Simon-san, > > > >

Re: [PATCH v2 5/6] usb: gadget: udc: renesas_usb3: should fail if devm_phy_get() returns error

2018-04-10 Thread Simon Horman
optional_get(). > > Reported-by: Simon Horman > Fixes: 279d4bc64060 ("usb: gadget: udc: renesas_usb3: add support for generic > phy") > Cc: # v4.15+ > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman > --- > Remarks: > - A new file in v

Re: [PATCH v2 6/6] usb: gadget: udc: renesas_usb3: disable the controller's irqs for reconnecting

2018-04-10 Thread Simon Horman
Fixes: 746bfe63bba3 ("usb: gadget: renesas_usb3: add support for Renesas > USB3.0 peripheral controller") > Cc: # v4.5+ > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman > --- > > Remarks: > - A new file in v2 > > drivers/usb/gadget/udc/r

Re: [PATCH 4/4] usb: gadget: udc: renesas_usb3: should call devm_phy_get() before add udc

2018-04-10 Thread Simon Horman
On Tue, Apr 10, 2018 at 01:28:33AM +, Yoshihiro Shimoda wrote: > Hi Simon-san, > > > From: Simon Horman, Sent: Monday, April 9, 2018 8:58 PM > > > > On Mon, Apr 02, 2018 at 09:21:34PM +0900, Yoshihiro Shimoda wrote: > > > This patch fixes an issue that

Re: [PATCH 4/4] usb: gadget: udc: renesas_usb3: should call devm_phy_get() before add udc

2018-04-09 Thread Simon Horman
uot;usb: gadget: udc: renesas_usb3: add support for generic > phy") > Cc: # v4.15+ > Signed-off-by: Yoshihiro Shimoda > --- > drivers/usb/gadget/udc/renesas_usb3.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Simon Horman Plea

Re: [PATCH 3/4] usb: gadget: udc: renesas_usb3: should call pm_runtime_enable() before add udc

2018-04-09 Thread Simon Horman
# v4.15+ > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/4] usb: gadget: udc: renesas_usb3: should remove debugfs

2018-04-09 Thread Simon Horman
Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] usb: gadget: udc: renesas_usb3: fix double phy_put()

2018-04-09 Thread Simon Horman
uot;usb: gadget: udc: renesas_usb3: add support for generic > phy") > Cc: # v4.15+ > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org Mo

Re: [PATCH 2/2] usb: gadget: udc: renesas_usb3: add binging for r8a77965

2018-03-06 Thread Simon Horman
On Tue, Feb 27, 2018 at 05:16:03PM +0900, Yoshihiro Shimoda wrote: > This patch adds binding for r8a77965 (R-Car M3-N). > > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of

Re: [PATCH 1/2] usb: renesas_usbhs: add binding for r8a77965

2018-03-06 Thread Simon Horman
On Tue, Feb 27, 2018 at 05:16:02PM +0900, Yoshihiro Shimoda wrote: > This patch adds binding for r8a77965 (R-Car M3-N). > > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of

Re: [PATCH] usb: host: xhci-rcar: add support for r8a77965

2018-03-06 Thread Simon Horman
On Tue, Feb 27, 2018 at 05:15:20PM +0900, Yoshihiro Shimoda wrote: > This patch adds support for r8a77965 (R-Car M3-N). > > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of

Re: [PATCH v3 0/3] usb: renesas_usbhs: Add RZ/A1 support

2018-01-09 Thread Simon Horman
On Mon, Jan 08, 2018 at 01:15:08PM +0100, Geert Uytterhoeven wrote: > Hi Chris, > > On Mon, Jan 8, 2018 at 12:59 PM, Chris Brandt > wrote: > > On Monday, January 08, 2018, Geert Uytterhoeven wrote: > >> Thanks for the update, but I think there has been a misunderstanding. > >> I didn't mean to d

Re: [PATCH v4 2/3] dt-bindings: usb: renesas_usbhs: Add support for RZ/A1

2018-01-09 Thread Simon Horman
On Mon, Jan 08, 2018 at 07:30:54AM -0500, Chris Brandt wrote: > Document support for RZ/A1 SoCs > > Signed-off-by: Chris Brandt > Reviewed-by: Geert Uytterhoeven Reviewed-by: Simon Horman > --- > v4: > * Re-added "renesas,usbhs-r7s72100" > v3: > *

Re: [PATCH v3 2/3] dt-bindings: usb: renesas_usbhs: Add support for RZ/A1

2018-01-07 Thread Simon Horman
On Fri, Jan 05, 2018 at 05:46:46PM -0500, Chris Brandt wrote: > Document support for RZ/A1 SoCs > > Signed-off-by: Chris Brandt > Reviewed-by: Geert Uytterhoeven > --- > v3: > * Removed "renesas,usbhs-r7s72100" Unless I am mistaken you want both renesas,usbhs-r7s72100, for the SoC and renesas,

Re: [PATCH v3 3/3] ARM: dts: r7s72100: add USB device to device tree

2018-01-07 Thread Simon Horman
On Fri, Jan 05, 2018 at 05:46:47PM -0500, Chris Brandt wrote: > Add USB device support. > > Signed-off-by: Chris Brandt > Reviewed-by: Geert Uytterhoeven > --- > v3: > * Changed from "renesas,usbhs-r7s72100" to "renesas,rza1-usbhs" I think you want both. The SoC-specific compat string followed

Re: [PATCH 3/3] ARM: dts: r7s72100: add USB device to device tree

2018-01-05 Thread Simon Horman
On Thu, Jan 04, 2018 at 03:01:50PM -0500, Chris Brandt wrote: > Add USB device support. > > Signed-off-by: Chris Brandt Hi Chris, it looks like there have been some requests for (minor) changes to this patch. Please consider addressing those and reposting. -- To unsubscribe from this list: send

Re: [PATCH 2/2] ARM: dts: r8a7743: Add xhci support to SoC dtsi

2017-10-17 Thread Simon Horman
On Tue, Oct 17, 2017 at 01:39:33AM +, Yoshihiro Shimoda wrote: > Hi Biju-san, > > IIUC, when we submitted a patch for dts[i] file, > we don't need to submit such a patch to usb maintainers. > > > From: Biju Das, Sent: Monday, October 16, 2017 7:13 PM > > > > From: Fabrizio Castro > > > > A

Re: [PATCH 1/2] dt-bindings: usb-xhci: Document r8a7743 support

2017-10-17 Thread Simon Horman
On Mon, Oct 16, 2017 at 11:12:48AM +0100, Biju Das wrote: > From: Fabrizio Castro > > Document r8a7743 xhci support. The driver will use the fallback > compatible string "renesas,rcar-gen2-xhci", therefore no driver > change is needed. > > Signed-off-by: Fabri

Re: [PATCH v2] usb: renesas_usbhs: Add compatible string for r8a7743/5

2017-10-08 Thread Simon Horman
usbhs". > Adding the SoC-specific compatible values here has two purposes: > 1. Document which SoCs have this hardware module, > 2. Allow checkpatch to validate compatible values. 3. Allow the driver to support SoC specific implementations in future as necessary. Acked-by: Simon

Re: [PATCH] usb: host: xhci-plat: Use of_device_get_match_data() helper

2017-10-06 Thread Simon Horman
On Thu, Oct 05, 2017 at 01:12:01PM +0300, Mathias Nyman wrote: > On 05.10.2017 12:19, Simon Horman wrote: > >On Wed, Oct 04, 2017 at 02:25:03PM +0200, Geert Uytterhoeven wrote: > >>Use the of_device_get_match_data() helper instead of open coding. > >> > >&

Re: [PATCH] usb: renesas_usbhs: Use of_device_get_match_data() helper

2017-10-05 Thread Simon Horman
On Wed, Oct 04, 2017 at 02:26:48PM +0200, Geert Uytterhoeven wrote: > Use the of_device_get_match_data() helper instead of open coding. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman -- To unsubscribe from this list: send the line "unsubscribe linux-usb&quo

Re: [PATCH] usb: host: xhci-plat: Use of_device_get_match_data() helper

2017-10-05 Thread Simon Horman
On Wed, Oct 04, 2017 at 02:25:03PM +0200, Geert Uytterhoeven wrote: > Use the of_device_get_match_data() helper instead of open coding. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman -- To unsubscribe from this list: send the line "unsubscribe linux-usb&quo

Re: [PATCH] usb: gadget: udc: renesas_usb3: Use of_device_get_match_data() helper

2017-10-05 Thread Simon Horman
lid match. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Simon Horman -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Flood of hub_ext_port_status failed (err = -71) messages

2016-11-22 Thread Simon Arlott
On 22/11/16 08:37, Mathias Nyman wrote: > On 21.11.2016 23:52, Simon Arlott wrote: >> 2016-06-17T09:56:09.219+01:00 kernel: xhci_hcd :00:14.0: URB >> transfer length is wrong, xHC issue? req. len = 4, act. len = 4294967292 > > Your broken hardware triggered another int

Flood of hub_ext_port_status failed (err = -71) messages

2016-11-21 Thread Simon Arlott
usb 1-13.5.1: Product: USB HID 2016-06-17T09:56:13.468+01:00 kernel: usb 1-13.5.1: Manufacturer: Action Star 2016-06-17T09:56:13.471+01:00 kernel: hid-generic 0003:0835:8502.000E: hiddev0,hidraw3: USB HID v1.11 Device [Action Star USB HID] on usb-:00:14.0-13.5.1/input0 -- Simon Arlott

Re: Tascam US-122L - Corrupt USB descriptor

2016-04-14 Thread Simon Wood
On Thu, April 14, 2016 1:35 am, Clemens Ladisch wrote: > Simon Wood wrote: > >> The card shows up under '/proc/asound/cards', but only as Midi. >> > > Apparently, there is no PCM device. This driver creates a special > hardware-dependent device which is int

Re: Tascam US-122L - Corrupt USB descriptor

2016-04-13 Thread Simon Wood
On Wed, April 13, 2016 3:01 am, Clemens Ladisch wrote: > Simon Wood wrote: > >> I have been struggling for the past few days to get a Tascam US-122L >> (USB >> sound-card/midi interface) working, despite reading numerous forum >> postings I have only been able t

Tascam US-122L - Corrupt USB descriptor

2016-04-13 Thread Simon Wood
D descriptors, is the same possible for the base USB descriptor? Trolling through 'drivers/usb' I didn't see anything... any suggestions? If this is possible I can try to increase the interface count and renumber the last one. Cheers, Simon. PS. For reference the device is: Model No:

[PATCH] usb: gadget: renesas_usb3: Use ARCH_RENESAS

2016-03-01 Thread Simon Horman
Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. This is part of an ongoing process to migrate from ARCH_SHMOBILE to ARCH_RENESAS the motivation for which being that RENESAS seems to be a more appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. Signed-off-by: Simon

[PATCH 2/2] usb: host: xhci-rcar: Use ARCH_RENESAS

2016-02-18 Thread Simon Horman
Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. This is part of an ongoing process to migrate from ARCH_SHMOBILE to ARCH_RENESAS the motivation for which being that RENESAS seems to be a more appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. Signed-off-by: Simon

[PATCH 1/2] usb: renesas_usbhs: Use ARCH_RENESAS

2016-02-18 Thread Simon Horman
Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. This is part of an ongoing process to migrate from ARCH_SHMOBILE to ARCH_RENESAS the motivation for which being that RENESAS seems to be a more appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. Signed-off-by: Simon

[PATCH 0/2] usb: Use ARCH_RENESAS

2016-02-18 Thread Simon Horman
. Simon Horman (2): usb: renesas_usbhs: Use ARCH_RENESAS usb: host: xhci-rcar: Use ARCH_RENESAS drivers/usb/host/Kconfig | 2 +- drivers/usb/renesas_usbhs/Kconfig | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.1.4 -- To unsubscribe from this list: send the line

[PATCHv2] net2280.h: fix endpoint max packet for super speed connections

2016-02-09 Thread Simon Appleby
This patch fixes the register offset used for super-speed connection's max packet size. Without it using the 338x series of devices in enhanced mode will only allow full or high speed operation to function correctly. Signed-off-by: Simon Appleby --- linux/drivers/usb/gadget/udc/net2280.h

Re: [Patch] net2280.h: fix endpoint max packet for super speed connections

2016-02-08 Thread Simon Appleby
> On 8 Feb 2016, at 16:50, Greg KH wrote: > > On Mon, Feb 08, 2016 at 10:01:09AM +0000, Simon Appleby wrote: >> This patch fixes the register offset used for super-speed connection¹s max >> packet size. >> Without it using the 338x series of devices in enhanced mode

[Patch] net2280.h: fix endpoint max packet for super speed connections

2016-02-08 Thread Simon Appleby
This patch fixes the register offset used for super-speed connection¹s max packet size. Without it using the 338x series of devices in enhanced mode will only allow full or high speed operation to function correctly. Signed-off-by: Simon Appleby --- linux/drivers/usb/gadget/udc/net2280.h.orig

[PATCH v4 0/3] usb: renesas_usbhs: More compat strings

2015-12-15 Thread Simon Horman
: * Split documentation of SoC names into separate patch * Use correct fallback compatibility string in example Changes since v1: * Add R-Car Gen2 and Gen3 fallback compatibility strings rather than a single compatibility string for all of R-Car. Simon Horman (3): usb: renesas_usbhs: add SoC names to

[PATCH v4 3/3] usb: renesas_usbhs: add device tree support for r8a779[23]

2015-12-15 Thread Simon Horman
Simply document new compatibility string. As a previous patch adds a generic R-Car Gen2 compatibility string there appears to be no need for a driver updates. Signed-off-by: Simon Horman Acked-by: Rob Herring Acked-by: Kuninori Morimoto --- Documentation/devicetree/bindings/usb

[PATCH v4 1/3] usb: renesas_usbhs: add SoC names to compatibility string documentation

2015-12-15 Thread Simon Horman
This extends the documentation of compatibility strings a little to include the SoC names. Signed-off-by: Simon Horman Acked-by: Kuninori Morimoto --- v3 * Split into separate patch --- Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 8 1 file changed, 4 insertions(+), 4

[PATCH v4 2/3] usb: renesas_usbhs: add fallback compatibility strings

2015-12-15 Thread Simon Horman
Add fallback compatibility strings for R-Car Gen2 and Gen3. This is in keeping with the fallback scheme being adopted wherever appropriate for drivers for Renesas SoCs. Signed-off-by: Simon Horman Acked-by: Kuninori Morimoto --- v4 * State that one or more compat string should be used v3

Re: [PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings

2015-12-14 Thread Simon Horman
On Fri, Dec 11, 2015 at 03:24:27PM +0300, Sergei Shtylyov wrote: > Hello. > > On 12/11/2015 5:12 AM, Simon Horman wrote: > > >Add fallback compatibility strings for R-Car Gen2 and Gen3. > >This is in keeping with the fallback scheme being adopted wherever > >appro

Re: [PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings

2015-12-10 Thread Simon Horman
On Thu, Dec 10, 2015 at 09:56:24PM -0600, Rob Herring wrote: > On Fri, Dec 11, 2015 at 11:12:26AM +0900, Simon Horman wrote: > > Add fallback compatibility strings for R-Car Gen2 and Gen3. > > This is in keeping with the fallback scheme being adopted wherever > > approp

[PATCH v3 3/3] usb: renesas_usbhs: add device tree support for r8a779[23]

2015-12-10 Thread Simon Horman
Simply document new compatibility string. As a previous patch adds a generic R-Car Gen2 compatibility string there appears to be no need for a driver updates. Signed-off-by: Simon Horman Acked-by: Rob Herring --- Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 2 ++ 1 file changed, 2

[PATCH v3 2/3] usb: renesas_usbhs: add fallback compatibility strings

2015-12-10 Thread Simon Horman
Add fallback compatibility strings for R-Car Gen2 and Gen3. This is in keeping with the fallback scheme being adopted wherever appropriate for drivers for Renesas SoCs. Signed-off-by: Simon Horman --- v3 * Moved documentation of SoC names to a separate patch * Use correct fallback compatibility

[PATCH v3 0/3] usb: renesas_usbhs: More compat strings

2015-12-10 Thread Simon Horman
compatibility string in example Changes since v1: * Add R-Car Gen2 and Gen3 fallback compatibility strings rather than a single compatibility string for all of R-Car. Simon Horman (3): usb: renesas_usbhs: add SoC names to compatibility string documentation usb: renesas_usbhs: add

[PATCH v3 1/3] usb: renesas_usbhs: add SoC names to compatibility string documentation

2015-12-10 Thread Simon Horman
This extends the documentation of compatibility strings a little to include the SoC names. Signed-off-by: Simon Horman --- v3 * Split into separate patch --- Documentation/devicetree/bindings/usb/renesas_usbhs.txt | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a

Re: [PATCH v2 1/2] usb: renesas_usbhs: add fallback compatibility strings

2015-12-10 Thread Simon Horman
On Thu, Dec 10, 2015 at 07:28:06AM +, Kuninori Morimoto wrote: > > Hi Simon > > Thank you for your patch > > > Add fallback compatibility strings for R-Car Gen2 and Gen3. > > This is in keeping with the fallback scheme being adopted wherever > > appropr

  1   2   3   >