Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error

2016-08-08 Thread Robert Foss
On 2016-08-07 04:59 AM, Oliver Neukum wrote: On Thu, 2016-08-04 at 13:44 -0400, Robert Foss wrote: On 2016-08-03 06:39 AM, Oliver Neukum wrote: On Tue, 2016-08-02 at 10:37 -0400, Robert Foss wrote: How can that depend on what we return to user space? In the driver we can continue just

Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error

2016-08-07 Thread Oliver Neukum
On Thu, 2016-08-04 at 13:44 -0400, Robert Foss wrote: > > On 2016-08-03 06:39 AM, Oliver Neukum wrote: > > On Tue, 2016-08-02 at 10:37 -0400, Robert Foss wrote: > > How can that depend on what we return to user space? > > In the driver we can continue just ignoring errors. > > Now, if user space

Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error

2016-08-04 Thread Robert Foss
On 2016-08-03 06:39 AM, Oliver Neukum wrote: On Tue, 2016-08-02 at 10:37 -0400, Robert Foss wrote: On 2016-08-02 09:59 AM, Oliver Neukum wrote: On Tue, 2016-08-02 at 09:54 -0400, Robert Foss wrote: On 2016-08-02 08:23 AM, Oliver Neukum wrote: On Thu, 2016-07-28 at 14:19 -0400,

Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error

2016-08-03 Thread Oliver Neukum
On Tue, 2016-08-02 at 10:37 -0400, Robert Foss wrote: > > On 2016-08-02 09:59 AM, Oliver Neukum wrote: > > On Tue, 2016-08-02 at 09:54 -0400, Robert Foss wrote: > >> > >> On 2016-08-02 08:23 AM, Oliver Neukum wrote: > >>> On Thu, 2016-07-28 at 14:19 -0400, robert.f...@collabora.com wrote: >

Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error

2016-08-02 Thread Robert Foss
On 2016-08-02 09:59 AM, Oliver Neukum wrote: On Tue, 2016-08-02 at 09:54 -0400, Robert Foss wrote: On 2016-08-02 08:23 AM, Oliver Neukum wrote: On Thu, 2016-07-28 at 14:19 -0400, robert.f...@collabora.com wrote: From: Prathmesh Prabhu Implemented queued response

Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error

2016-08-02 Thread Oliver Neukum
On Thu, 2016-07-28 at 14:19 -0400, robert.f...@collabora.com wrote: > From: Prathmesh Prabhu > > Implemented queued response handling. This queue is processed every > time the > WDM_READ flag is cleared. > > In case of a read error, userspace may not actually read the

Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error

2016-08-02 Thread Robert Foss
On 2016-08-02 08:23 AM, Oliver Neukum wrote: On Thu, 2016-07-28 at 14:19 -0400, robert.f...@collabora.com wrote: From: Prathmesh Prabhu Implemented queued response handling. This queue is processed every time the WDM_READ flag is cleared. In case of a read error,

Re: [PACTH v1] cdc-wdm: Clear read pipeline in case of error

2016-08-02 Thread Oliver Neukum
On Tue, 2016-08-02 at 09:54 -0400, Robert Foss wrote: > > On 2016-08-02 08:23 AM, Oliver Neukum wrote: > > On Thu, 2016-07-28 at 14:19 -0400, robert.f...@collabora.com wrote: > >> From: Prathmesh Prabhu > >> > >> Implemented queued response handling. This queue is processed

[PACTH v1] cdc-wdm: Clear read pipeline in case of error

2016-07-28 Thread robert . foss
From: Prathmesh Prabhu Implemented queued response handling. This queue is processed every time the WDM_READ flag is cleared. In case of a read error, userspace may not actually read the data, since the driver returns an error through wdm_poll. After this, the underlying