RE: [PATCH/RFC v3 3/4] usb: gadget: udc: renesas_usb3: use usb role switch API

2018-05-15 Thread Yoshihiro Shimoda
Hi Simon-san, > From: Simon Horman, Sent: Tuesday, May 15, 2018 5:04 PM > > On Tue, May 15, 2018 at 08:02:00AM +, Yoshihiro Shimoda wrote: > > Hi Simon-san, > > > > Thank you for your review! > > > > > From: Simon Horman, Sent: Tuesday, May 15, 2018 4:54 PM > > > On Mon, May 14, 2018 at

Re: [PATCH/RFC v3 3/4] usb: gadget: udc: renesas_usb3: use usb role switch API

2018-05-15 Thread Simon Horman
On Tue, May 15, 2018 at 08:02:00AM +, Yoshihiro Shimoda wrote: > Hi Simon-san, > > Thank you for your review! > > > From: Simon Horman, Sent: Tuesday, May 15, 2018 4:54 PM > > On Mon, May 14, 2018 at 06:15:59PM +0900, Yoshihiro Shimoda wrote: > > > > static void usb3_set_mode(struct

RE: [PATCH/RFC v3 3/4] usb: gadget: udc: renesas_usb3: use usb role switch API

2018-05-15 Thread Yoshihiro Shimoda
Hi Simon-san, Thank you for your review! > From: Simon Horman, Sent: Tuesday, May 15, 2018 4:54 PM > On Mon, May 14, 2018 at 06:15:59PM +0900, Yoshihiro Shimoda wrote: > > static void usb3_set_mode(struct renesas_usb3 *usb3, bool host) > > { > > - _usb3_set_mode(usb3, host); > > + if

Re: [PATCH/RFC v3 3/4] usb: gadget: udc: renesas_usb3: use usb role switch API

2018-05-15 Thread Simon Horman
On Mon, May 14, 2018 at 06:15:59PM +0900, Yoshihiro Shimoda wrote: > This patch uses usb role switch API if the register suceeeded. > > Signed-off-by: Yoshihiro Shimoda > --- > drivers/usb/gadget/udc/renesas_usb3.c | 8 ++-- > 1 file changed, 6

[PATCH/RFC v3 3/4] usb: gadget: udc: renesas_usb3: use usb role switch API

2018-05-14 Thread Yoshihiro Shimoda
This patch uses usb role switch API if the register suceeeded. Signed-off-by: Yoshihiro Shimoda --- drivers/usb/gadget/udc/renesas_usb3.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/udc/renesas_usb3.c