Re: [PATCH][V3] usb: isp1760: check for null return from kzalloc

2015-06-08 Thread Felipe Balbi
On Mon, Jun 08, 2015 at 02:22:06PM -0700, Greg Kroah-Hartman wrote: > On Wed, Jun 03, 2015 at 03:43:23AM +0300, Laurent Pinchart wrote: > > Hi Colin, > > > > Thank you for the patch. > > > > On Tuesday 02 June 2015 19:05:13 Colin King wrote: > > > From: Colin Ian King > > > > > > isp1760_ep_all

Re: [PATCH][V3] usb: isp1760: check for null return from kzalloc

2015-06-08 Thread Greg Kroah-Hartman
On Wed, Jun 03, 2015 at 03:43:23AM +0300, Laurent Pinchart wrote: > Hi Colin, > > Thank you for the patch. > > On Tuesday 02 June 2015 19:05:13 Colin King wrote: > > From: Colin Ian King > > > > isp1760_ep_alloc_request allocates a structure with kzalloc without checking > > for NULL and then r

Re: [PATCH][V3] usb: isp1760: check for null return from kzalloc

2015-06-03 Thread Felipe Balbi
Hi, On Wed, Jun 03, 2015 at 03:43:23AM +0300, Laurent Pinchart wrote: > > From: Colin Ian King > > > > isp1760_ep_alloc_request allocates a structure with kzalloc without checking > > for NULL and then returns a pointer to one of the structure fields. As the > > field happens to be the first in

Re: [PATCH][V3] usb: isp1760: check for null return from kzalloc

2015-06-02 Thread Laurent Pinchart
Hi Colin, Thank you for the patch. On Tuesday 02 June 2015 19:05:13 Colin King wrote: > From: Colin Ian King > > isp1760_ep_alloc_request allocates a structure with kzalloc without checking > for NULL and then returns a pointer to one of the structure fields. As the > field happens to be the fi

[PATCH][V3] usb: isp1760: check for null return from kzalloc

2015-06-02 Thread Colin King
From: Colin Ian King isp1760_ep_alloc_request allocates a structure with kzalloc without checking for NULL and then returns a pointer to one of the structure fields. As the field happens to be the first in the structure the caller can properly check for NULL, but this is risky if the structure