Re: [PATCH] USB: EHCI: don't reread PORTSC after disabling port power

2017-10-25 Thread Alan Stern
On Tue, 24 Oct 2017, Uwe [iso-8859-1] Kleine-K�nig wrote: > Now after removing my instrumentation the situation isn't what I > described before. Instead of being spammed by messages about > over-current I get only a single message (good) and power stays on. I > wonder if that is acceptable. > >

Re: [PATCH] USB: EHCI: don't reread PORTSC after disabling port power

2017-10-24 Thread Uwe Kleine-König
Hello, On Sun, Oct 22, 2017 at 09:03:34PM -0400, Alan Stern wrote: > On Sun, 22 Oct 2017, Uwe [iso-8859-1] Kleine-K?nig wrote: > > On Sat, Oct 21, 2017 at 11:08:39AM -0400, Alan Stern wrote: > > > On Fri, 20 Oct 2017, Uwe [iso-8859-1] Kleine-K?nig wrote: > > > > On Fri, Oct 20, 2017 at 03:47:37PM

Re: [PATCH] USB: EHCI: don't reread PORTSC after disabling port power

2017-10-22 Thread Alan Stern
On Sun, 22 Oct 2017, Uwe [iso-8859-1] Kleine-K�nig wrote: > Hello, > > On Sat, Oct 21, 2017 at 11:08:39AM -0400, Alan Stern wrote: > > On Fri, 20 Oct 2017, Uwe [iso-8859-1] Kleine-K�nig wrote: > > > On Fri, Oct 20, 2017 at 03:47:37PM -0400, Alan Stern wrote: > > > > On Fri, 20 Oct 2017, Uwe

Re: [PATCH] USB: EHCI: don't reread PORTSC after disabling port power

2017-10-22 Thread Uwe Kleine-König
Hello, On Sat, Oct 21, 2017 at 11:08:39AM -0400, Alan Stern wrote: > On Fri, 20 Oct 2017, Uwe [iso-8859-1] Kleine-König wrote: > > On Fri, Oct 20, 2017 at 03:47:37PM -0400, Alan Stern wrote: > > > On Fri, 20 Oct 2017, Uwe [iso-8859-1] Kleine-König wrote: > > > > On Fri, Oct 20, 2017 at 05:27:09PM

Re: [PATCH] USB: EHCI: don't reread PORTSC after disabling port power

2017-10-21 Thread Alan Stern
On Fri, 20 Oct 2017, Uwe [iso-8859-1] Kleine-K�nig wrote: > Hello Alan, > > On Fri, Oct 20, 2017 at 03:47:37PM -0400, Alan Stern wrote: > > On Fri, 20 Oct 2017, Uwe [iso-8859-1] Kleine-K�nig wrote: > > > On Fri, Oct 20, 2017 at 05:27:09PM -0200, Fabio Estevam wrote: > > > > On Fri, Oct 20, 2017

Re: [PATCH] USB: EHCI: don't reread PORTSC after disabling port power

2017-10-20 Thread Uwe Kleine-König
Hello Alan, On Fri, Oct 20, 2017 at 03:47:37PM -0400, Alan Stern wrote: > On Fri, 20 Oct 2017, Uwe [iso-8859-1] Kleine-König wrote: > > On Fri, Oct 20, 2017 at 05:27:09PM -0200, Fabio Estevam wrote: > > > On Fri, Oct 20, 2017 at 5:20 PM, Uwe Kleine-König > > >

Re: [PATCH] USB: EHCI: don't reread PORTSC after disabling port power

2017-10-20 Thread Marc Kleine-Budde
On 10/20/2017 09:47 PM, Alan Stern wrote: >> On Fri, Oct 20, 2017 at 05:27:09PM -0200, Fabio Estevam wrote: >>> On Fri, Oct 20, 2017 at 5:20 PM, Uwe Kleine-K�nig >>> wrote: >>> It also works. However I wonder if it's right that I'm spammed by over-current

Re: [PATCH] USB: EHCI: don't reread PORTSC after disabling port power

2017-10-20 Thread Alan Stern
On Fri, 20 Oct 2017, Uwe [iso-8859-1] Kleine-K�nig wrote: > Hey Fabio, > > On Fri, Oct 20, 2017 at 05:27:09PM -0200, Fabio Estevam wrote: > > On Fri, Oct 20, 2017 at 5:20 PM, Uwe Kleine-K�nig > > wrote: > > > > > It also works. However I wonder if it's right

Re: [PATCH] USB: EHCI: don't reread PORTSC after disabling port power

2017-10-20 Thread Uwe Kleine-König
Hey Fabio, On Fri, Oct 20, 2017 at 05:27:09PM -0200, Fabio Estevam wrote: > On Fri, Oct 20, 2017 at 5:20 PM, Uwe Kleine-König > wrote: > > > It also works. However I wonder if it's right that I'm spammed by > > over-current messages now (independent of which fix

Re: [PATCH] USB: EHCI: don't reread PORTSC after disabling port power

2017-10-20 Thread Fabio Estevam
Hi Uwe, On Fri, Oct 20, 2017 at 5:20 PM, Uwe Kleine-König wrote: > It also works. However I wonder if it's right that I'm spammed by > over-current messages now (independent of which fix I choose) as long as > there is something connected to the port that draws

Re: [PATCH] USB: EHCI: don't reread PORTSC after disabling port power

2017-10-20 Thread Uwe Kleine-König
Hello Alan, On Fri, Oct 20, 2017 at 01:58:14PM -0400, Alan Stern wrote: > On Fri, 20 Oct 2017, Uwe Kleine-König wrote: > > diff --git a/drivers/usb/host/ehci-hub.c b/drivers/usb/host/ehci-hub.c > > index df169c8e7225..08f59654654b 100644 > > --- a/drivers/usb/host/ehci-hub.c > > +++

Re: [PATCH] USB: EHCI: don't reread PORTSC after disabling port power

2017-10-20 Thread Alan Stern
On Fri, 20 Oct 2017, Uwe Kleine-König wrote: > ehci_hub_control does the following related to overcurrent handling > (simplified): > > temp = ehci_readl(ehci, status_reg); > > if (temp & PORT_OCC) { > status |= USB_PORT_STAT_C_OVERCURRENT << 16; > > if

Re: [PATCH] USB: EHCI: don't reread PORTSC after disabling port power

2017-10-20 Thread Uwe Kleine-König
Hello Sergei, On Fri, Oct 20, 2017 at 01:15:00PM +0300, Sergei Shtylyov wrote: > > - temp = ehci_readl(ehci, status_reg); > > + temp |= ~PORT_POWER; > >You surely meant '&='? Right. /me has to work on his workflow such that it doesn't

Re: [PATCH] USB: EHCI: don't reread PORTSC after disabling port power

2017-10-20 Thread Sergei Shtylyov
Hello! On 10/20/2017 12:54 PM, Uwe Kleine-König wrote: ehci_hub_control does the following related to overcurrent handling (simplified): temp = ehci_readl(ehci, status_reg); if (temp & PORT_OCC) { status |= USB_PORT_STAT_C_OVERCURRENT << 16;

[PATCH] USB: EHCI: don't reread PORTSC after disabling port power

2017-10-20 Thread Uwe Kleine-König
ehci_hub_control does the following related to overcurrent handling (simplified): temp = ehci_readl(ehci, status_reg); if (temp & PORT_OCC) { status |= USB_PORT_STAT_C_OVERCURRENT << 16; if (temp & PORT_OC) {