Re: [PATCH] USB: chipidea: fix error path

2013-12-20 Thread Sascha Hauer
On Thu, Dec 19, 2013 at 04:28:54PM +0800, Peter Chen wrote: On Thu, Dec 19, 2013 at 09:35:44AM +0100, Sascha Hauer wrote: devm_usb_get_phy_by_phandle() returns a PTR_ERR on failure, so we have to check for IS_ERR before calling usb_phy_shutdown(), not for NULL. Signed-off-by: Sascha

[PATCH] USB: chipidea: fix error path

2013-12-19 Thread Sascha Hauer
devm_usb_get_phy_by_phandle() returns a PTR_ERR on failure, so we have to check for IS_ERR before calling usb_phy_shutdown(), not for NULL. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Cc: Peter Chen peter.c...@freescale.com Cc: linux-usb@vger.kernel.org ---

Re: [PATCH] USB: chipidea: fix error path

2013-12-19 Thread Peter Chen
On Thu, Dec 19, 2013 at 09:35:44AM +0100, Sascha Hauer wrote: devm_usb_get_phy_by_phandle() returns a PTR_ERR on failure, so we have to check for IS_ERR before calling usb_phy_shutdown(), not for NULL. Signed-off-by: Sascha Hauer s.ha...@pengutronix.de Cc: Peter Chen peter.c...@freescale.com