Re: [PATCH] USB: serial: add nt124 usb to serial driver

2014-12-16 Thread Johan Hovold
On Mon, Dec 15, 2014 at 10:09:22AM -0600, George McCollister wrote: > On Mon, Dec 15, 2014 at 3:52 AM, Johan Hovold wrote: > > On Sun, Dec 14, 2014 at 11:51:11AM -0600, George McCollister wrote: > >> Johan, > >> > >> While working on the tx_empty changes you suggested it occurred to me > >> that i

Re: [PATCH] USB: serial: add nt124 usb to serial driver

2014-12-15 Thread George McCollister
On Mon, Dec 15, 2014 at 3:52 AM, Johan Hovold wrote: > On Sun, Dec 14, 2014 at 11:51:11AM -0600, George McCollister wrote: >> Johan, >> >> While working on the tx_empty changes you suggested it occurred to me >> that it might not be obvious to others that the firmware doesn't send >> a packet with

Re: [PATCH] USB: serial: add nt124 usb to serial driver

2014-12-15 Thread Johan Hovold
On Sun, Dec 14, 2014 at 11:51:11AM -0600, George McCollister wrote: > Johan, > > While working on the tx_empty changes you suggested it occurred to me > that it might not be obvious to others that the firmware doesn't send > a packet with the NT124_CTRL_TXEMPTY flag cleared when it begins > transm

Re: [PATCH] USB: serial: add nt124 usb to serial driver

2014-12-15 Thread Johan Hovold
On Fri, Dec 12, 2014 at 09:01:03AM -0600, George McCollister wrote: > On Wed, Dec 10, 2014 at 7:04 AM, Johan Hovold wrote: > > On Mon, Dec 08, 2014 at 05:24:17PM -0600, George McCollister wrote: > >> + switch (termios->c_cflag & CSIZE) { > > > > C_CSIZE(tty) > Okay > > > >> + case CS5: >

Re: [PATCH] USB: serial: add nt124 usb to serial driver

2014-12-14 Thread George McCollister
Johan, While working on the tx_empty changes you suggested it occurred to me that it might not be obvious to others that the firmware doesn't send a packet with the NT124_CTRL_TXEMPTY flag cleared when it begins transmitting. The practical implication is that if the driver sets tx_empty = true whe

Re: [PATCH] USB: serial: add nt124 usb to serial driver

2014-12-12 Thread George McCollister
Johan, Thanks for the thorough review. On Wed, Dec 10, 2014 at 7:04 AM, Johan Hovold wrote: > On Mon, Dec 08, 2014 at 05:24:17PM -0600, George McCollister wrote: >> This driver is for the NovaTech 124 4x serial expansion board for the >> NovaTech OrionLXm. >> >> Firmware source code can be found

Re: Re: [PATCH] USB: serial: add nt124 usb to serial driver

2014-12-11 Thread Karl Palsson
Johan Hovold wrote: > On Mon, Dec 08, 2014 at 05:24:17PM -0600, George McCollister wrote: > > + newline.bParityType = termios->c_cflag & PARENB ? > > + (termios->c_cflag & PARODD ? 1 : 2) + > > + (termios->c_cflag & CMSPAR ? 2 : 0) : 0; > >

Re: [PATCH] USB: serial: add nt124 usb to serial driver

2014-12-10 Thread Johan Hovold
On Mon, Dec 08, 2014 at 05:24:17PM -0600, George McCollister wrote: > This driver is for the NovaTech 124 4x serial expansion board for the > NovaTech OrionLXm. > > Firmware source code can be found here: > https://github.com/novatechweb/nt124 Great, and thanks for the patch! > Signed-off-by: Ge

Re: [PATCH] USB: serial: add nt124 usb to serial driver

2014-12-08 Thread George McCollister
Thanks for the review. I didn't update the MAINTAINERS file because I looked in it and didn't see any other individual usb/serial drivers listed with maintainers. -George On Mon, Dec 8, 2014 at 6:29 PM, Jeremiah Mahler wrote: > George, > > On Mon, Dec 08, 2014 at 05:24:17PM -0600, George McColl

Re: [PATCH] USB: serial: add nt124 usb to serial driver

2014-12-08 Thread Jeremiah Mahler
George, On Mon, Dec 08, 2014 at 05:24:17PM -0600, George McCollister wrote: > This driver is for the NovaTech 124 4x serial expansion board for the > NovaTech OrionLXm. > > Firmware source code can be found here: > https://github.com/novatechweb/nt124 > > Signed-off-by: George McCollister > ---

[PATCH] USB: serial: add nt124 usb to serial driver

2014-12-08 Thread George McCollister
This driver is for the NovaTech 124 4x serial expansion board for the NovaTech OrionLXm. Firmware source code can be found here: https://github.com/novatechweb/nt124 Signed-off-by: George McCollister --- drivers/usb/serial/Kconfig | 9 + drivers/usb/serial/Makefile | 1 + drivers/usb/seria