[PATCH] USB: serial: fix invalid user-pointer checks

2016-11-08 Thread Johan Hovold
Drop invalid user-pointer checks from ioctl handlers. A NULL-pointer can be valid in user space and copy_to_user() takes care of sanity checking. Signed-off-by: Johan Hovold --- drivers/usb/serial/ftdi_sio.c | 5 - drivers/usb/serial/io_edgeport.c | 3 --- drivers/usb/serial/io

Re: [PATCH] USB: serial: fix invalid user-pointer checks

2016-11-08 Thread Oliver Neukum
On Tue, 2016-11-08 at 13:26 +0100, Johan Hovold wrote: > Drop invalid user-pointer checks from ioctl handlers. > > A NULL-pointer can be valid in user space and copy_to_user() takes > care > of sanity checking. Shouldn't we bail out early in these cases? Regards Oliver

Re: [PATCH] USB: serial: fix invalid user-pointer checks

2016-11-08 Thread Johan Hovold
On Tue, Nov 08, 2016 at 03:13:13PM +0100, Oliver Neukum wrote: > On Tue, 2016-11-08 at 13:26 +0100, Johan Hovold wrote: > > Drop invalid user-pointer checks from ioctl handlers. > > > > A NULL-pointer can be valid in user space and copy_to_user() takes > > care > > of sanity checking. > > Shouldn

Re: [PATCH] USB: serial: fix invalid user-pointer checks

2016-11-09 Thread Johan Hovold
On Wed, Nov 09, 2016 at 11:58:31AM +0100, Oliver Neukum wrote: > On Tue, 2016-11-08 at 16:41 +0100, Johan Hovold wrote: > > On Tue, Nov 08, 2016 at 03:13:13PM +0100, Oliver Neukum wrote: > > > On Tue, 2016-11-08 at 13:26 +0100, Johan Hovold wrote: > > > > Drop invalid user-pointer checks from ioctl

Re: [PATCH] USB: serial: fix invalid user-pointer checks

2016-11-09 Thread Oliver Neukum
On Tue, 2016-11-08 at 16:41 +0100, Johan Hovold wrote: > On Tue, Nov 08, 2016 at 03:13:13PM +0100, Oliver Neukum wrote: > > On Tue, 2016-11-08 at 13:26 +0100, Johan Hovold wrote: > > > Drop invalid user-pointer checks from ioctl handlers. > > > > > > A NULL-pointer can be valid in user space and c