Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-21 Thread Brian Norris
On Tue, Aug 06, 2013 at 03:03:29PM +0300, Jussi Kivilinna wrote: Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not. Patch is only compile tested. Cc: sta...@vger.kernel.org Signed-off-by: Jussi Kivilinna

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-21 Thread Bjørn Mork
Brian Norris computersforpe...@gmail.com writes: On Tue, Aug 06, 2013 at 03:03:29PM +0300, Jussi Kivilinna wrote: Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not. Patch is only compile tested. Cc: sta...@vger.kernel.org

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-21 Thread Brian Norris
On Wed, Aug 21, 2013 at 09:59:27AM +0200, Bjørn Mork wrote: Brian Norris computersforpe...@gmail.com writes: On Tue, Aug 06, 2013 at 03:03:29PM +0300, Jussi Kivilinna wrote: Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not.

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-21 Thread Jussi Kivilinna
On 21.08.2013 11:41, Brian Norris wrote: On Wed, Aug 21, 2013 at 09:59:27AM +0200, Bjørn Mork wrote: Brian Norris computersforpe...@gmail.com writes: On Tue, Aug 06, 2013 at 03:03:29PM +0300, Jussi Kivilinna wrote: Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-21 Thread Brian Norris
On Wed, Aug 21, 2013 at 2:59 AM, Jussi Kivilinna jussi.kivili...@iki.fi wrote: On 21.08.2013 11:41, Brian Norris wrote: On Wed, Aug 21, 2013 at 09:59:27AM +0200, Bjørn Mork wrote: Brian Norris computersforpe...@gmail.com writes: On Tue, Aug 06, 2013 at 03:03:29PM +0300, Jussi Kivilinna wrote:

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-21 Thread Jörn Engel
On Wed, 21 August 2013 13:00:15 -0700, Brian Norris wrote: Yes, that's a good point. Quoting Documentation/stable_kernel_rules.txt: It must be obviously correct and tested. Seeing as it was not tested, I am dropping the patch entirely (it is not stable material, and there is no point

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-07 Thread Jörn Engel
On Wed, 7 August 2013 08:50:53 +0300, Jussi Kivilinna wrote: On 06.08.2013 19:49, Jörn Engel wrote: On Tue, 6 August 2013 15:03:29 +0300, Jussi Kivilinna wrote: Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not. Patch is

[PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-06 Thread Jussi Kivilinna
Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not. Patch is only compile tested. Cc: sta...@vger.kernel.org Signed-off-by: Jussi Kivilinna jussi.kivili...@iki.fi --- drivers/mtd/nand/alauda.c | 74

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-06 Thread Jussi Kivilinna
On 06.08.2013 15:26, Oliver Neukum wrote: On Tue, 2013-08-06 at 15:03 +0300, Jussi Kivilinna wrote: Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not. You better include GregKH in CC Ok. Each of the 6 patches I sent today are

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-06 Thread Greg Kroah-Hartman
On Tue, Aug 06, 2013 at 03:47:24PM +0300, Jussi Kivilinna wrote: On 06.08.2013 15:26, Oliver Neukum wrote: On Tue, 2013-08-06 at 15:03 +0300, Jussi Kivilinna wrote: Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not. You

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-06 Thread Jörn Engel
On Tue, 6 August 2013 15:03:29 +0300, Jussi Kivilinna wrote: Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not. Patch is only compile tested. I have tested the driver back when I wrote it. Not sure why it worked then, maybe

Re: [PATCH] alauda: do not use stack for URB transfer_buffers

2013-08-06 Thread Jussi Kivilinna
On 06.08.2013 19:49, Jörn Engel wrote: On Tue, 6 August 2013 15:03:29 +0300, Jussi Kivilinna wrote: Patch fixes alauda not to use stack as URB transfer_buffer. URB buffers need to be DMA-able, which stack is not. Patch is only compile tested. I have tested the driver back when I wrote