Re: [PATCH] configfs: switch ->default groups to a linked list

2016-03-10 Thread Doug Ledford
On 02/27/2016 06:22 PM, Nicholas A. Bellinger wrote: > On Fri, 2016-02-26 at 13:33 +0100, Christoph Hellwig wrote: >> Replace the current NULL-terminated array of default groups with a linked >> list. This gets rid of lots of nasty code to size and/or dynamically >> allocate the array. >> >> While

Re: [PATCH] configfs: switch ->default groups to a linked list

2016-03-05 Thread Joel Becker
Acked-by: Joel Becker On Fri, Feb 26, 2016 at 01:33:51PM +0100, Christoph Hellwig wrote: > Replace the current NULL-terminated array of default groups with a linked > list. This gets rid of lots of nasty code to size and/or dynamically > allocate the array. > > While we're at it also provide a

Re: [PATCH] configfs: switch ->default groups to a linked list

2016-02-28 Thread Christoph Hellwig
On Sun, Feb 28, 2016 at 12:58:42PM +0200, Sagi Grimberg wrote: >> -As a consequence of this, default_groups cannot be removed directly via >> +As a consequence of this, default groups cannot be removed directly via >> rmdir(2). They also are not considered when rmdir(2) on the parent >> group

Re: [PATCH] configfs: switch ->default groups to a linked list

2016-02-28 Thread Sagi Grimberg
On 26/02/2016 14:33, Christoph Hellwig wrote: Replace the current NULL-terminated array of default groups with a linked list. This gets rid of lots of nasty code to size and/or dynamically allocate the array. While we're at it also provide a conveniant helper to remove the default groups. Si

Re: [PATCH] configfs: switch ->default groups to a linked list

2016-02-27 Thread Nicholas A. Bellinger
On Fri, 2016-02-26 at 13:33 +0100, Christoph Hellwig wrote: > Replace the current NULL-terminated array of default groups with a linked > list. This gets rid of lots of nasty code to size and/or dynamically > allocate the array. > > While we're at it also provide a conveniant helper to remove the

Re: [PATCH] configfs: switch ->default groups to a linked list

2016-02-26 Thread Felipe Balbi
Christoph Hellwig writes: > Replace the current NULL-terminated array of default groups with a linked > list. This gets rid of lots of nasty code to size and/or dynamically > allocate the array. > > While we're at it also provide a conveniant helper to remove the default > groups. > looks ok to

[PATCH] configfs: switch ->default groups to a linked list

2016-02-26 Thread Christoph Hellwig
Replace the current NULL-terminated array of default groups with a linked list. This gets rid of lots of nasty code to size and/or dynamically allocate the array. While we're at it also provide a conveniant helper to remove the default groups. Signed-off-by: Christoph Hellwig --- Documentation