Re: [PATCH] dma: cpp41: Fix handling of error path

2016-11-16 Thread Tony Lindgren
* Tony Lindgren [161116 06:55]: > * Sekhar Nori [161115 22:25]: > > On Wednesday 16 November 2016 02:28 AM, Tony Lindgren wrote: > > > * Sekhar Nori [161115 00:35]: > > >> If pm_runtime_get_sync() fails due to callback error, then > > >>

Re: [PATCH] dma: cpp41: Fix handling of error path

2016-11-16 Thread Tony Lindgren
* Sekhar Nori [161115 22:25]: > On Wednesday 16 November 2016 02:28 AM, Tony Lindgren wrote: > > * Sekhar Nori [161115 00:35]: > >> If pm_runtime_get_sync() fails due to callback error, then > >> rpm_callback() sets dev.power.runtime_error to an error value which

Re: [PATCH] dma: cpp41: Fix handling of error path

2016-11-15 Thread Sekhar Nori
On Wednesday 16 November 2016 02:28 AM, Tony Lindgren wrote: > * Sekhar Nori [161115 00:35]: >> If pm_runtime_get_sync() fails due to callback error, then >> rpm_callback() sets dev.power.runtime_error to an error value which gets >> cleared by an explicit call to

Re: [PATCH] dma: cpp41: Fix handling of error path

2016-11-15 Thread Bin Liu
On Tue, Nov 15, 2016 at 12:58:17PM -0800, Tony Lindgren wrote: > * Sekhar Nori [161115 00:35]: > > On Saturday 12 November 2016 12:58 AM, Tony Lindgren wrote: > > > If we return early on pm_runtime_get() error, we need to also call > > > pm_runtime_put_noidle() as pointed out in a

Re: [PATCH] dma: cpp41: Fix handling of error path

2016-11-15 Thread Tony Lindgren
* Sekhar Nori [161115 00:35]: > On Saturday 12 November 2016 12:58 AM, Tony Lindgren wrote: > > If we return early on pm_runtime_get() error, we need to also call > > pm_runtime_put_noidle() as pointed out in a musb related thread > > by Johan Hovold . This is to

Re: [PATCH] dma: cpp41: Fix handling of error path

2016-11-15 Thread Sekhar Nori
On Saturday 12 November 2016 12:58 AM, Tony Lindgren wrote: > If we return early on pm_runtime_get() error, we need to also call > pm_runtime_put_noidle() as pointed out in a musb related thread > by Johan Hovold . This is to keep the PM runtime > use counts happy. > > Fixes:

Re: [PATCH] dma: cpp41: Fix handling of error path

2016-11-14 Thread Tony Lindgren
* Johan Hovold [161114 06:59]: > On Mon, Nov 14, 2016 at 06:47:31AM -0800, Tony Lindgren wrote: > > Hi, > > > > * Johan Hovold [161114 06:35]: > > > On Fri, Nov 11, 2016 at 11:28:52AM -0800, Tony Lindgren wrote: > > > > If we return early on pm_runtime_get()

Re: [PATCH] dma: cpp41: Fix handling of error path

2016-11-14 Thread Johan Hovold
On Mon, Nov 14, 2016 at 06:47:31AM -0800, Tony Lindgren wrote: > Hi, > > * Johan Hovold [161114 06:35]: > > On Fri, Nov 11, 2016 at 11:28:52AM -0800, Tony Lindgren wrote: > > > If we return early on pm_runtime_get() error, we need to also call > > > pm_runtime_put_noidle() as

Re: [PATCH] dma: cpp41: Fix handling of error path

2016-11-14 Thread Tony Lindgren
Hi, * Johan Hovold [161114 06:35]: > On Fri, Nov 11, 2016 at 11:28:52AM -0800, Tony Lindgren wrote: > > If we return early on pm_runtime_get() error, we need to also call > > pm_runtime_put_noidle() as pointed out in a musb related thread > > by Johan Hovold .

Re: [PATCH] dma: cpp41: Fix handling of error path

2016-11-14 Thread Johan Hovold
On Mon, Nov 14, 2016 at 03:34:54PM +0100, Johan Hovold wrote: > On Fri, Nov 11, 2016 at 11:28:52AM -0800, Tony Lindgren wrote: > > If we return early on pm_runtime_get() error, we need to also call > > pm_runtime_put_noidle() as pointed out in a musb related thread > > by Johan Hovold

Re: [PATCH] dma: cpp41: Fix handling of error path

2016-11-14 Thread Johan Hovold
On Fri, Nov 11, 2016 at 11:28:52AM -0800, Tony Lindgren wrote: > If we return early on pm_runtime_get() error, we need to also call > pm_runtime_put_noidle() as pointed out in a musb related thread > by Johan Hovold . This is to keep the PM runtime > use counts happy. > > Fixes:

[PATCH] dma: cpp41: Fix handling of error path

2016-11-11 Thread Tony Lindgren
If we return early on pm_runtime_get() error, we need to also call pm_runtime_put_noidle() as pointed out in a musb related thread by Johan Hovold . This is to keep the PM runtime use counts happy. Fixes: fdea2d09b997 ("dmaengine: cppi41: Add basic PM runtime support") Cc: Johan