gm45 intel gfx can generate non-MSI irq# in MSI mode (was Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses

2013-03-19 Thread Daniel Vetter
On Tue, Mar 19, 2013 at 10:03 AM, Chris Wilson wrote: >> > How about just using: >> > if (!HAS_GMBUS_IRQ(dev_priv->dev)) gmbus4_irq_en = 0; >> > and the existing wait loop? >> >> I explicitly wanted to avoid touching GMBUS4 register, as the real cause >> of the failure is not clear. >> >> But, a

Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses))

2013-03-19 Thread Chris Wilson
On Tue, Mar 19, 2013 at 09:56:57AM +0100, Jiri Kosina wrote: > On Mon, 18 Mar 2013, Chris Wilson wrote: > > > > +#define HAS_GMBUS_IRQ(dev) (INTEL_INFO(dev)->gen >= 5) > > > void > > > intel_i2c_reset(struct drm_device *dev) > > > { > > > struct drm_i915_private *dev_priv = dev->dev_private;

Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses))

2013-03-19 Thread Jiri Kosina
On Mon, 18 Mar 2013, Chris Wilson wrote: > > +#define HAS_GMBUS_IRQ(dev) (INTEL_INFO(dev)->gen >= 5) > > void > > intel_i2c_reset(struct drm_device *dev) > > { > > struct drm_i915_private *dev_priv = dev->dev_private; > > I915_WRITE(dev_priv->gpio_mmio_base + GMBUS0, 0); > > - I915_WR

Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses))

2013-03-18 Thread Daniel Vetter
On Mon, Mar 18, 2013 at 04:56:02PM +0100, Jiri Kosina wrote: > Okay, so I think that for 3.9 we want the patch below, and if eventually > hardware root cause / workaround is found for GM45, we can have it merged > later. I'd prefer if we dig into this for a bit more. I've been traveling last wee

Re: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses))

2013-03-18 Thread Chris Wilson
On Mon, Mar 18, 2013 at 04:56:02PM +0100, Jiri Kosina wrote: > Okay, so I think that for 3.9 we want the patch below, and if eventually > hardware root cause / workaround is found for GM45, we can have it merged > later. > > > > From: Jiri Kosina > Subject: [PATCH] drm/i915: stop using GMBUS

[PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips (was Re: [3.9-rc1] irq 16: nobody cared (was [3.9-rc1] very poor interrupt responses))

2013-03-18 Thread Jiri Kosina
Okay, so I think that for 3.9 we want the patch below, and if eventually hardware root cause / workaround is found for GM45, we can have it merged later. From: Jiri Kosina Subject: [PATCH] drm/i915: stop using GMBUS IRQs on Gen4 chips Commit 28c70f162 ("drm/i915: use the gmbus irq for waits"