Re: Re: [PATCH] phy: add Rockchip RK3288 USB2 PHY driver.

2014-12-04 Thread Yunzhi Li
Hi Heiko Am Mittwoch, 3. Dezember 2014, 21:46:50 schrieb LiYunzhi: + +}; + +static int rockchip_usb_phy_power(struct rockchip_usb_phy *phy, + bool siddq) +{ + return regmap_write(phy->reg_base, phy->reg_offset, + SIDDQ_MS

Re: [PATCH] phy: add Rockchip RK3288 USB2 PHY driver.

2014-12-04 Thread Heiko Stübner
Hi Roy, Am Mittwoch, 3. Dezember 2014, 21:46:50 schrieb LiYunzhi: > From: lyz > > Add a driver for the Rockchip SoC internal USB2.0 PHY. > This driver currently support RK3288. > > Signed-off-by: lyz > --- [...] > diff --git a/drivers/phy/phy-rockchip-usb.c b/drivers/phy/phy-rockchip-usb.c >

Re: [PATCH] phy: add Rockchip RK3288 USB2 PHY driver.

2014-12-03 Thread Kever Yang
Hi Roy, Why you send two patches with different commit message but the same change, you should use V2 for a new patch. On 12/03/2014 09:46 PM, LiYunzhi wrote: From: lyz You don't need the From for the patches from yourself. Add a driver for the Rockchip SoC internal USB2.0 PHY. This d

Re: [PATCH] phy: add Rockchip RK3288 USB2 PHY driver.

2014-12-03 Thread Greg KH
On Wed, Dec 03, 2014 at 09:46:50PM +0800, LiYunzhi wrote: > From: lyz > > Add a driver for the Rockchip SoC internal USB2.0 PHY. > This driver currently support RK3288. > > Signed-off-by: lyz Is this the name you use to sign legal documents? That is what you need to put in your Signed-off-by:

[PATCH] phy: add Rockchip RK3288 USB2 PHY driver.

2014-12-03 Thread LiYunzhi
From: lyz Add a driver for the Rockchip SoC internal USB2.0 PHY. This driver currently support RK3288. Signed-off-by: lyz --- .../devicetree/bindings/phy/rockchip-usb-phy.txt | 17 ++ drivers/phy/Kconfig| 7 + drivers/phy/Makefile