Re: [PATCH] tools: usb: aio example applications

2014-01-28 Thread Peter Stuge
Nice to have a complete kernel+userspace example. Thanks! Robert Baldyga wrote: > +++ b/tools/usb/aio_multibuff/host_app/test.c > @@ -0,0 +1,122 @@ > +#include Please don't do this. Please always #include and call some combination of: pkg-config --cflags libusb-1.0 pkg-config --libs libusb-1

Re: [PATCH] tools: usb: aio example applications

2014-01-28 Thread Michal Nazarewicz
On Tue, Jan 28 2014, David Laight wrote: > I was thinking of the bits that are K&R C. > Like: > int foo() { For that I think the code should stick to Linux style guide (even though in this particular instance, I do not agree with it). -- Best regards, _

RE: [PATCH] tools: usb: aio example applications

2014-01-28 Thread David Laight
From: Michal Nazarewicz > On Tue, Jan 28 2014, David Laight wrote: > > From: Robert Baldyga > >> This patch adds two example applications showing usage of Asynchronous I/O > >> API > >> of FunctionFS. First one (aio_simple) is simple example of bidirectional > >> data > >> transfer. Second one (

Re: [PATCH] tools: usb: aio example applications

2014-01-28 Thread Michal Nazarewicz
On Tue, Jan 28 2014, Robert Baldyga wrote: > diff --git a/tools/usb/aio_multibuff/device_app/aio_multibuff.c > b/tools/usb/aio_multibuff/device_app/aio_multibuff.c > new file mode 100644 > index 000..df1db84 > --- /dev/null > +++ b/tools/usb/aio_multibuff/device_app/aio_multibuff.c > +#define

Re: [PATCH] tools: usb: aio example applications

2014-01-28 Thread Michal Nazarewicz
On Tue, Jan 28 2014, David Laight wrote: > From: Robert Baldyga >> This patch adds two example applications showing usage of Asynchronous I/O >> API >> of FunctionFS. First one (aio_simple) is simple example of bidirectional data >> transfer. Second one (aio_multibuff) shows multi-buffer data tra

RE: [PATCH] tools: usb: aio example applications

2014-01-28 Thread David Laight
From: Robert Baldyga > This patch adds two example applications showing usage of Asynchronous I/O API > of FunctionFS. First one (aio_simple) is simple example of bidirectional data > transfer. Second one (aio_multibuff) shows multi-buffer data transfer, which > may to be used in high performance a

[PATCH] tools: usb: aio example applications

2014-01-28 Thread Robert Baldyga
This patch adds two example applications showing usage of Asynchronous I/O API of FunctionFS. First one (aio_simple) is simple example of bidirectional data transfer. Second one (aio_multibuff) shows multi-buffer data transfer, which may to be used in high performance applications. Both examples c