[PATCH] usb: Clear both buffers when clearing a control transfer TT buffer.

2013-06-27 Thread William Gulland
Control transfers have both IN and OUT (or SETUP) packets, so when clearing TT buffers for a control transfer it's necessary to send two HUB_CLEAR_TT_BUFFER requests to the hub. Signed-off-by: William Gulland --- drivers/usb/core/hub.c | 9 + 1 file changed, 9 insertions(+)

Re: [PATCH] usb: Clear both buffers when clearing a control transfer TT buffer.

2013-06-28 Thread Sergei Shtylyov
Hello. On 28-06-2013 3:10, William Gulland wrote: Control transfers have both IN and OUT (or SETUP) packets, so when clearing TT buffers for a control transfer it's necessary to send two HUB_CLEAR_TT_BUFFER requests to the hub. Signed-off-by: William Gulland --- drivers/usb

Re: [PATCH] usb: Clear both buffers when clearing a control transfer TT buffer.

2013-06-28 Thread Alan Stern
On Thu, 27 Jun 2013, William Gulland wrote: > Control transfers have both IN and OUT (or SETUP) packets, so when > clearing TT buffers for a control transfer it's necessary to send > two HUB_CLEAR_TT_BUFFER requests to the hub. What makes you think this is necessary? Have you found a

Re: [PATCH] usb: Clear both buffers when clearing a control transfer TT buffer.

2013-06-28 Thread Alan Stern
Please use Reply-To-All so that your response gets sent to the mailing list as well as to me. And please don't top-post. On Fri, 28 Jun 2013, William Gulland wrote: > Yes, two ClearTTBuffer requests seem to be necessary with Intel's CaveCreek > integrated rate-matching hub - I've got it into th

Fwd: [PATCH] usb: Clear both buffers when clearing a control transfer TT buffer.

2013-06-28 Thread William Gulland
From: William Gulland Date: Fri, Jun 28, 2013 at 3:13 PM Subject: Re: [PATCH] usb: Clear both buffers when clearing a control transfer TT buffer. To: Alan Stern Cc: Sarah Sharp , USB list On Fri, Jun 28, 2013 at 12:24 PM, Alan Stern wrote: > > Please use Reply-To-All so that your re

Re: [PATCH] usb: Clear both buffers when clearing a control transfer TT buffer.

2013-06-28 Thread Sarah Sharp
On Fri, Jun 28, 2013 at 03:24:49PM -0400, Alan Stern wrote: > Please use Reply-To-All so that your response gets sent to the mailing > list as well as to me. And please don't top-post. > > On Fri, 28 Jun 2013, William Gulland wrote: > > > Yes, two ClearTTBuffer requests seem to be necessary wit

Re: [PATCH] usb: Clear both buffers when clearing a control transfer TT buffer.

2013-06-28 Thread Greg KH
On Fri, Jun 28, 2013 at 04:17:44PM -0700, Sarah Sharp wrote: > On Fri, Jun 28, 2013 at 03:24:49PM -0400, Alan Stern wrote: > > Please use Reply-To-All so that your response gets sent to the mailing > > list as well as to me. And please don't top-post. > > > > On Fri, 28 Jun 2013, William Gulland

Re: [PATCH] usb: Clear both buffers when clearing a control transfer TT buffer.

2013-06-29 Thread Alan Stern
On Fri, 28 Jun 2013, Greg KH wrote: > On Fri, Jun 28, 2013 at 04:17:44PM -0700, Sarah Sharp wrote: > > On Fri, Jun 28, 2013 at 03:24:49PM -0400, Alan Stern wrote: > > > Please use Reply-To-All so that your response gets sent to the mailing > > > list as well as to me. And please don't top-post.

Re: [PATCH] usb: Clear both buffers when clearing a control transfer TT buffer.

2013-06-29 Thread Alan Stern
On Fri, 28 Jun 2013, Sarah Sharp wrote: > > This sounds like a bug in the Intel hub hardware, or at least, > > unintentional behavior. > > > > Sarah, is this the sort of thing the Intel engineers would want to know > > about? > > I will send them a report. However, if this was found on produc

Re: [PATCH] usb: Clear both buffers when clearing a control transfer TT buffer.

2013-07-01 Thread Alan Stern
On Thu, 27 Jun 2013, William Gulland wrote: > Control transfers have both IN and OUT (or SETUP) packets, so when > clearing TT buffers for a control transfer it's necessary to send > two HUB_CLEAR_TT_BUFFER requests to the hub. > > Signed-off-by: William Gulland > --- > drivers/usb/