Re: [PATCH] usb: ehci-platform: add reset controller number in struct ehci_platform_priv

2016-04-26 Thread Alan Stern
On Tue, 26 Apr 2016, Jiancheng Xue wrote: > > If an error occurs here... > > > Sorry. It's really a problem. I'll modify it in v2 like below: > > err = reset_control_deassert(priv->rsts[rst]); > if(err) { > reset_control_put(priv->rsts[rst]); > goto err_reset; > } Yes, that would

Re: [PATCH] usb: ehci-platform: add reset controller number in struct ehci_platform_priv

2016-04-25 Thread Jiancheng Xue
Hi Alan, On 2016/4/25 22:43, Alan Stern wrote: > On Sat, 23 Apr 2016, Jiancheng Xue wrote: > >> Some generic-ehci compatible controllers have more than one reset signal >> lines, e.g., Synopsys DWC USB2.0 Host-AHB Controller has two resets bus_reset >> and roothub_reset. Two more resets are

Re: [PATCH] usb: ehci-platform: add reset controller number in struct ehci_platform_priv

2016-04-25 Thread Alan Stern
On Sat, 23 Apr 2016, Jiancheng Xue wrote: > Some generic-ehci compatible controllers have more than one reset signal > lines, e.g., Synopsys DWC USB2.0 Host-AHB Controller has two resets bus_reset > and roothub_reset. Two more resets are added in this patch in order for this > kind of controller

[PATCH] usb: ehci-platform: add reset controller number in struct ehci_platform_priv

2016-04-23 Thread Jiancheng Xue
Some generic-ehci compatible controllers have more than one reset signal lines, e.g., Synopsys DWC USB2.0 Host-AHB Controller has two resets bus_reset and roothub_reset. Two more resets are added in this patch in order for this kind of controller to use this driver directly. Signed-off-by: