Re: [PATCH] usb: gadget: f_fs: do not set cancel function on synchronous {read,write}

2015-06-04 Thread Al Viro
On Wed, May 27, 2015 at 11:41:31AM +0100, Rui Miguel Silva wrote: > do not try to set cancel function in synchronous operations in > ffs_epfile_{read,write}_iter. > > With, 70e60d917 gadget/function/f_fs.c: switch to ->{read,write}_iter() > if CONFIG_AIO is disable there is no problem as kiocb_set

[PATCH] usb: gadget: f_fs: do not set cancel function on synchronous {read,write}

2015-05-27 Thread Rui Miguel Silva
do not try to set cancel function in synchronous operations in ffs_epfile_{read,write}_iter. With, 70e60d917 gadget/function/f_fs.c: switch to ->{read,write}_iter() if CONFIG_AIO is disable there is no problem as kiocb_set_cancel_fn is a nop, with this option enabled it will try to use ctx that is

Re: [PATCH] usb: gadget: f_fs: do not set cancel function on synchronous {read,write}

2015-05-26 Thread Felipe Balbi
On Mon, May 18, 2015 at 04:02:07PM +0100, Rui Miguel Silva wrote: > do not try to set cancel function in synchronous operations in > ffs_epfile_{read,write}_iter. why not ? Please provide a better commit log and Cc author of the commit which added that particular line. > Signed-off-by: Rui Miguel