Re: [PATCH] usb: gadget: fsl: check vbus presence on probe

2014-05-09 Thread Paul Fertser
Hi, On Fri, May 09, 2014 at 09:07:00AM +, suresh.gu...@freescale.com wrote: > > Are you really sure we can't get async VBUS state change notifications > > until controller has USB_CMD_RUN_STOP bit set (and the same bit actually > > controls internal 1.5k dataline pullup)? If yes, I guess it me

RE: [PATCH] usb: gadget: fsl: check vbus presence on probe

2014-05-09 Thread suresh.gu...@freescale.com
> -Original Message- > From: Paul Fertser [mailto:fercer...@gmail.com] > Sent: Friday, May 09, 2014 1:44 AM > To: Gupta Suresh-B42813 > Cc: ba...@ti.com; Li Yang-Leo-R58472; linux-usb@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH] usb: ga

Re: [PATCH] usb: gadget: fsl: check vbus presence on probe

2014-05-08 Thread Paul Fertser
On Thu, May 08, 2014 at 06:42:53PM +, suresh.gu...@freescale.com wrote: > > > And Host might be attach after system bootup or after driver > > > initialization. So putting this check in probe will not help much. > > > > If the host is attached after the driver was initialised, the interrupt >

RE: [PATCH] usb: gadget: fsl: check vbus presence on probe

2014-05-08 Thread suresh.gu...@freescale.com
> -Original Message- > From: Paul Fertser [mailto:fercer...@gmail.com] > Sent: Thursday, May 08, 2014 9:09 PM > To: Gupta Suresh-B42813 > Cc: ba...@ti.com; Li Yang-Leo-R58472; linux-usb@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH] usb: ga

Re: [PATCH] usb: gadget: fsl: check vbus presence on probe

2014-05-08 Thread Paul Fertser
Hi, On Thu, May 08, 2014 at 02:30:39PM +, suresh.gu...@freescale.com wrote: > As per my limited knowledge, the purpose of > OTGSC_STS_B_SESSION_VALID bit is to tell either VBUS is above the B > session valid threshold and which comes only Host is attached. Yes, that matches the datasheet I've

RE: [PATCH] usb: gadget: fsl: check vbus presence on probe

2014-05-08 Thread suresh.gu...@freescale.com
.kernel.org; linux- > ker...@vger.kernel.org > Subject: RE: [PATCH] usb: gadget: fsl: check vbus presence on probe > > Give me some time (actually some days), I will try this and update you. > > > -Original Message- > > From: Felipe Balbi [mailto:ba...@ti.com] &g

RE: [PATCH] usb: gadget: fsl: check vbus presence on probe

2014-05-01 Thread suresh.gu...@freescale.com
g; linux- > ker...@vger.kernel.org; Gupta Suresh-B42813 > Subject: Re: [PATCH] usb: gadget: fsl: check vbus presence on probe > > +Suresh > > (top-posting, yeah yeah :-) > > On Wed, Apr 30, 2014 at 11:27:45PM +0400, Paul Fertser wrote: > > Hello, > > > > Thank you f

Re: [PATCH] usb: gadget: fsl: check vbus presence on probe

2014-04-30 Thread Felipe Balbi
+Suresh (top-posting, yeah yeah :-) On Wed, Apr 30, 2014 at 11:27:45PM +0400, Paul Fertser wrote: > Hello, > > Thank you for the review. > > On Wed, Apr 30, 2014 at 11:06:25AM -0500, Felipe Balbi wrote: > > On Thu, Apr 24, 2014 at 12:54:13PM +0400, Paul Fertser wrote: > > > If VBUS is already p

Re: [PATCH] usb: gadget: fsl: check vbus presence on probe

2014-04-30 Thread Paul Fertser
Hello, Thank you for the review. On Wed, Apr 30, 2014 at 11:06:25AM -0500, Felipe Balbi wrote: > On Thu, Apr 24, 2014 at 12:54:13PM +0400, Paul Fertser wrote: > > If VBUS is already present during the driver initialisation, the > > s/initialisation/initialization If I'm understanding [1] proper

Re: [PATCH] usb: gadget: fsl: check vbus presence on probe

2014-04-30 Thread Felipe Balbi
On Thu, Apr 24, 2014 at 12:54:13PM +0400, Paul Fertser wrote: > If VBUS is already present during the driver initialisation, the s/initialisation/initialization > corresponding IRQ never fires, so there is no way the gadget can get > enumerated. > > This patch is real-life tested on an i.MX25 bo

[PATCH] usb: gadget: fsl: check vbus presence on probe

2014-04-24 Thread Paul Fertser
If VBUS is already present during the driver initialisation, the corresponding IRQ never fires, so there is no way the gadget can get enumerated. This patch is real-life tested on an i.MX25 board with VBUS constantly hooked up. Signed-off-by: Paul Fertser --- drivers/usb/gadget/fsl_udc_core.c |