Re: [PATCH] usb: gadget: r8a66597-udc: do not unlock unheld spinlock in r8a66597_sudmac_irq()

2013-05-29 Thread Shimoda, Yoshihiro
Hi, (2013/05/30 8:58), Felipe Balbi wrote: > HI, > > On Thu, May 30, 2013 at 12:51:37AM +0400, Alexey Khoroshilov wrote: >> r8a66597_irq() processes sudmac part (r8a66597_sudmac_irq()) before locking >> r8a66597->lock. >> But transfer_complete(), that is called inside >> (r8a66597_sudmac_irq()-

Re: [PATCH] usb: gadget: r8a66597-udc: do not unlock unheld spinlock in r8a66597_sudmac_irq()

2013-05-29 Thread Felipe Balbi
HI, On Thu, May 30, 2013 at 12:51:37AM +0400, Alexey Khoroshilov wrote: > r8a66597_irq() processes sudmac part (r8a66597_sudmac_irq()) before locking > r8a66597->lock. > But transfer_complete(), that is called inside > (r8a66597_sudmac_irq()->sudmac_finish()->transfer_complete()), > expects r8a6

[PATCH] usb: gadget: r8a66597-udc: do not unlock unheld spinlock in r8a66597_sudmac_irq()

2013-05-29 Thread Alexey Khoroshilov
r8a66597_irq() processes sudmac part (r8a66597_sudmac_irq()) before locking r8a66597->lock. But transfer_complete(), that is called inside (r8a66597_sudmac_irq()->sudmac_finish()->transfer_complete()), expects r8a66597->lock is locked. As a result unheld spinlock can be unlocked. The patch just