Re: [PATCH] usb: gadget: remove inode.c

2013-02-04 Thread Michal Nazarewicz
On Thu, Jan 24 2013, Felipe Balbi wrote: > Hmm, looks like there's no easy way out. Can we (easily) make > a compatibility layer between the two ? What are the biggest > differences ? Come to think of it, would it make sense to make it as a user space library preloaded when gadgetfs user space app

Re: [PATCH] usb: gadget: remove inode.c

2013-02-04 Thread Felipe Balbi
Hi, On Mon, Feb 04, 2013 at 04:27:49PM +0100, Michal Nazarewicz wrote: > On Thu, Jan 24 2013, Felipe Balbi wrote: > > the benefit is that we will be able to go ahed with configfs-based > > binding and will be able to drop duplicated gadget code between legacy > > (non-composite) and composite fram

Re: [PATCH] usb: gadget: remove inode.c

2013-02-04 Thread Michal Nazarewicz
On Thu, Jan 24 2013, Felipe Balbi wrote: > the benefit is that we will be able to go ahed with configfs-based > binding and will be able to drop duplicated gadget code between legacy > (non-composite) and composite framework with the function drivers. I'm not sure whether keeping gadgetfs around i

Re: [PATCH] usb: gadget: remove inode.c

2013-01-24 Thread Felipe Balbi
Hi, On Thu, Jan 24, 2013 at 07:16:39PM +0100, Michal Nazarewicz wrote: > On Thu, Jan 24 2013, Felipe Balbi wrote: > > Hmm, looks like there's no easy way out. Can we (easily) make > > a compatibility layer between the two ? What are the biggest > > differences? > > The biggest difference is that

Re: [PATCH] usb: gadget: remove inode.c

2013-01-24 Thread Michal Nazarewicz
On Thu, Jan 24 2013, Felipe Balbi wrote: > Hmm, looks like there's no easy way out. Can we (easily) make > a compatibility layer between the two ? What are the biggest > differences? The biggest difference is that gadgetfs application handles all setup requests whereas with functionfs most of them

Re: [PATCH] usb: gadget: remove inode.c

2013-01-24 Thread Felipe Balbi
Hi, On Thu, Jan 24, 2013 at 06:28:19PM +0100, Michal Nazarewicz wrote: > On Thu, Jan 24 2013, Greg KH wrote: > > gadgetfs is a userspace api that I don't think we can just drop all > > that easily. Does f_fs do everything that gadgetfs does? > > gadgetfs and functionfs have a different API so f_

Re: [PATCH] usb: gadget: remove inode.c

2013-01-24 Thread Michal Nazarewicz
On Thu, Jan 24 2013, Greg KH wrote: > gadgetfs is a userspace api that I don't think we can just drop all > that easily. Does f_fs do everything that gadgetfs does? gadgetfs and functionfs have a different API so f_fs cannot be used as a drop-in replacement for gadgetfs. -- Best regards,

Re: [PATCH] usb: gadget: remove inode.c

2013-01-24 Thread Felipe Balbi
Hi, On Thu, Jan 24, 2013 at 11:55:45AM -0500, Alan Stern wrote: > On Thu, 24 Jan 2013, Felipe Balbi wrote: > > > > > > gadgetfs is a userspace api that I don't think we can just drop all > > > > > that > > > > > easily. Does f_fs do everything that gadgetfs does? > > > > > > > > yes, just a di

Re: [PATCH] usb: gadget: remove inode.c

2013-01-24 Thread Alan Stern
On Thu, 24 Jan 2013, Felipe Balbi wrote: > > > > gadgetfs is a userspace api that I don't think we can just drop all that > > > > easily. Does f_fs do everything that gadgetfs does? > > > > > > yes, just a different name (functionfs instead of gadgetfs). > > > > No. gadgetfs supports async I/O

Re: [PATCH] usb: gadget: remove inode.c

2013-01-24 Thread Felipe Balbi
Hi, On Thu, Jan 24, 2013 at 11:40:38AM -0500, Alan Stern wrote: > On Thu, 24 Jan 2013, Felipe Balbi wrote: > > > On Thu, Jan 24, 2013 at 08:23:33AM -0800, Greg KH wrote: > > > On Thu, Jan 24, 2013 at 06:06:45PM +0200, Felipe Balbi wrote: > > > > Hi, > > > > > > > > On Thu, Jan 24, 2013 at 06:05:

Re: [PATCH] usb: gadget: remove inode.c

2013-01-24 Thread Alan Stern
On Thu, 24 Jan 2013, Felipe Balbi wrote: > On Thu, Jan 24, 2013 at 08:23:33AM -0800, Greg KH wrote: > > On Thu, Jan 24, 2013 at 06:06:45PM +0200, Felipe Balbi wrote: > > > Hi, > > > > > > On Thu, Jan 24, 2013 at 06:05:08PM +0200, Felipe Balbi wrote: > > > > it's not used anymore by anyone, we can

Re: [PATCH] usb: gadget: remove inode.c

2013-01-24 Thread Felipe Balbi
On Thu, Jan 24, 2013 at 08:33:59AM -0800, Greg KH wrote: > On Thu, Jan 24, 2013 at 06:25:56PM +0200, Felipe Balbi wrote: > > On Thu, Jan 24, 2013 at 08:23:33AM -0800, Greg KH wrote: > > > On Thu, Jan 24, 2013 at 06:06:45PM +0200, Felipe Balbi wrote: > > > > Hi, > > > > > > > > On Thu, Jan 24, 2013

Re: [PATCH] usb: gadget: remove inode.c

2013-01-24 Thread Greg KH
On Thu, Jan 24, 2013 at 06:25:56PM +0200, Felipe Balbi wrote: > On Thu, Jan 24, 2013 at 08:23:33AM -0800, Greg KH wrote: > > On Thu, Jan 24, 2013 at 06:06:45PM +0200, Felipe Balbi wrote: > > > Hi, > > > > > > On Thu, Jan 24, 2013 at 06:05:08PM +0200, Felipe Balbi wrote: > > > > it's not used anymo

Re: [PATCH] usb: gadget: remove inode.c

2013-01-24 Thread Felipe Balbi
On Thu, Jan 24, 2013 at 08:23:33AM -0800, Greg KH wrote: > On Thu, Jan 24, 2013 at 06:06:45PM +0200, Felipe Balbi wrote: > > Hi, > > > > On Thu, Jan 24, 2013 at 06:05:08PM +0200, Felipe Balbi wrote: > > > it's not used anymore by anyone, we can remove it. > > > > > > Signed-off-by: Felipe Balbi

Re: [PATCH] usb: gadget: remove inode.c

2013-01-24 Thread Greg KH
On Thu, Jan 24, 2013 at 06:06:45PM +0200, Felipe Balbi wrote: > Hi, > > On Thu, Jan 24, 2013 at 06:05:08PM +0200, Felipe Balbi wrote: > > it's not used anymore by anyone, we can remove it. > > > > Signed-off-by: Felipe Balbi > > my bad, we still have gadgetfs. I was going to ask you about that

Re: [PATCH] usb: gadget: remove inode.c

2013-01-24 Thread Felipe Balbi
Hi, On Thu, Jan 24, 2013 at 06:05:08PM +0200, Felipe Balbi wrote: > it's not used anymore by anyone, we can remove it. > > Signed-off-by: Felipe Balbi my bad, we still have gadgetfs. In any case, everybody agrees about removing gadgetfs and using f_fs only ? -- balbi signature.asc Descript

[PATCH] usb: gadget: remove inode.c

2013-01-24 Thread Felipe Balbi
it's not used anymore by anyone, we can remove it. Signed-off-by: Felipe Balbi --- drivers/usb/gadget/inode.c | 2129 1 file changed, 2129 deletions(-) delete mode 100644 drivers/usb/gadget/inode.c diff --git a/drivers/usb/gadget/inode.c b/drivers/u