Re: [PATCH] usb: gadget: udc: atmel: Fix check in usba_ep_enable()

2016-12-07 Thread Boris Brezillon
On Tue, 6 Dec 2016 22:59:43 +0100 Boris Brezillon wrote: > desc->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK is not necessarily > equal to ep->index and that's perfectly fine. The usba endpoint index is > just an internal identifier used by the driver to know

Re: [PATCH] usb: gadget: udc: atmel: Fix check in usba_ep_enable()

2016-12-06 Thread Boris Brezillon
Hi Felipe, I realize I sent this patch to your old @ti.com email address. Do you want me to resend it? Regards, Boris On Tue, 6 Dec 2016 22:59:43 +0100 Boris Brezillon wrote: > desc->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK is not necessarily > equal

[PATCH] usb: gadget: udc: atmel: Fix check in usba_ep_enable()

2016-12-06 Thread Boris Brezillon
desc->bEndpointAddress & USB_ENDPOINT_NUMBER_MASK is not necessarily equal to ep->index and that's perfectly fine. The usba endpoint index is just an internal identifier used by the driver to know which registers to use for a USB endpoint. Enforcing this constraint is not only useless, but can