RE: [PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED

2013-12-05 Thread Cortes, Alexis
04, 2013 6:04 PM To: Cortes, Alexis Cc: Alan Stern; Julius Werner; Greg Kroah-Hartman; LKML; linux-usb@vger.kernel.org; Benson Leung; Vincent Palatin Subject: Re: [PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED On Tue, Nov 19, 2013 at 02:53:22PM +, Cortes

Re: [PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED

2013-12-04 Thread Sarah Sharp
; Vincent Palatin; Cortes, Alexis Subject: Re: [PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED On Thu, Nov 07, 2013 at 10:32:33AM -0500, Alan Stern wrote: On Wed, 6 Nov 2013, Julius Werner wrote: What if the device is in USB_STATE_SUSPENDED? I'm

RE: [PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED

2013-11-19 Thread Cortes, Alexis
: Sarah Sharp [mailto:sarah.a.sh...@linux.intel.com] Sent: Thursday, November 14, 2013 5:31 PM To: Alan Stern Cc: Julius Werner; Greg Kroah-Hartman; LKML; linux-usb@vger.kernel.org; Benson Leung; Vincent Palatin; Cortes, Alexis Subject: Re: [PATCH] usb: hub: Use correct reset for wedged USB3

Re: [PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED

2013-11-18 Thread Julius Werner
I'm not sure if it's worth it further looking into this for the SUSPENDED state (Sarah's post sounds like that shouldn't happen)... but at any rate, that would be orthogonal to my patch, right? I'm really only interested in the NOTATTACHED case, which solves a real issue on my system. Do you still

Re: [PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED

2013-11-14 Thread Sarah Sharp
On Thu, Nov 07, 2013 at 10:32:33AM -0500, Alan Stern wrote: On Wed, 6 Nov 2013, Julius Werner wrote: What if the device is in USB_STATE_SUSPENDED? I'm not sure that is possible at that point in hub_events(), I don't know of a way that could lead to this situation. I could still add

Re: [PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED

2013-11-07 Thread Alan Stern
On Wed, 6 Nov 2013, Julius Werner wrote: What if the device is in USB_STATE_SUSPENDED? I'm not sure that is possible at that point in hub_events(), I don't know of a way that could lead to this situation. I could still add the check just to be sure if you want it, though. I don't know

Re: [PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED

2013-11-07 Thread Julius Werner
I don't know either. But Sarah has said that ports can spontaneously go into Compliance Mode for no apparent reason. If that can happen, maybe it can happen while the port is in U3 and the device is suspended. In such cases, though, you'd need to do a reset-resume rather than a simple

[PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED

2013-11-06 Thread Julius Werner
This patch adds a check for USB_STATE_NOTATTACHED to the hub_port_warm_reset_required() workaround for ports that end up in Compliance Mode in hub_events() when trying to decide which reset function to use. Trying to call usb_reset_device() with a NOTATTACHED device will just fail and leave the

Re: [PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED

2013-11-06 Thread Greg Kroah-Hartman
On Wed, Nov 06, 2013 at 12:27:21PM -0800, Julius Werner wrote: This patch adds a check for USB_STATE_NOTATTACHED to the hub_port_warm_reset_required() workaround for ports that end up in Compliance Mode in hub_events() when trying to decide which reset function to use. Trying to call

Re: [PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED

2013-11-06 Thread Alan Stern
On Wed, 6 Nov 2013, Julius Werner wrote: This patch adds a check for USB_STATE_NOTATTACHED to the hub_port_warm_reset_required() workaround for ports that end up in Compliance Mode in hub_events() when trying to decide which reset function to use. Trying to call usb_reset_device() with a

Re: [PATCH] usb: hub: Use correct reset for wedged USB3 devices that are NOTATTACHED

2013-11-06 Thread Julius Werner
Who makes those calls, drivers? Any specific ones that you know need to be fixed? Well, the one I'm worried about is the one this patch is fixing, in hub_events(). I have seen this happen when having certain USB3 devices plugged into a host controller that always looses power on suspend-to-ram