Re: [PATCH] usb: isp1760: compress return logic into one line

2017-07-11 Thread Oliver Neukum
Am Montag, den 10.07.2017, 14:58 -0500 schrieb Gustavo A. R. Silva : > Hi Oliver, > > Quoting Oliver Neukum : > > > > > Am Sonntag, den 09.07.2017, 21:00 -0500 schrieb Gustavo A. R. Silva : > > > > > > Simplify return logic to avoid unnecessary variable assignment. > > > > > > This issue was

Re: [PATCH] usb: isp1760: compress return logic into one line

2017-07-10 Thread Gustavo A. R. Silva
Hi Oliver, Quoting Oliver Neukum : Am Sonntag, den 09.07.2017, 21:00 -0500 schrieb Gustavo A. R. Silva : Simplify return logic to avoid unnecessary variable assignment. This issue was detected using Coccinelle and the following semantic patch: Hi, I need to ask: Where is the improvement?

Re: [PATCH] usb: isp1760: compress return logic into one line

2017-07-10 Thread Oliver Neukum
Am Sonntag, den 09.07.2017, 21:00 -0500 schrieb Gustavo A. R. Silva : > Simplify return logic to avoid unnecessary variable assignment. > > This issue was detected using Coccinelle and the following > semantic patch: > Hi, I need to ask: Where is the improvement? The compiler does not bother a

[PATCH] usb: isp1760: compress return logic into one line

2017-07-09 Thread Gustavo A. R. Silva
Simplify return logic to avoid unnecessary variable assignment. This issue was detected using Coccinelle and the following semantic patch: @@ local idexpression ret; expression e; @@ -ret = +return e; -return ret; Signed-off-by: Gustavo A. R. Silva --- drivers/usb/isp1760/isp1760-hcd.c |