Re: [PATCH] usb: musb: gadget: do *unmap_dma_buffer* only for valid DMA addr

2013-03-18 Thread Felipe Balbi
On Mon, Mar 18, 2013 at 02:17:52PM +0530, kishon wrote: > On Monday 18 March 2013 02:12 PM, Felipe Balbi wrote: > >Hi, > > > >On Mon, Mar 18, 2013 at 01:50:55PM +0530, kishon wrote: > >@@ -141,7 +141,7 @@ static inline void map_dma_buffer(struct > >musb_request *request, > > static in

Re: [PATCH] usb: musb: gadget: do *unmap_dma_buffer* only for valid DMA addr

2013-03-18 Thread kishon
On Monday 18 March 2013 02:12 PM, Felipe Balbi wrote: Hi, On Mon, Mar 18, 2013 at 01:50:55PM +0530, kishon wrote: @@ -141,7 +141,7 @@ static inline void map_dma_buffer(struct musb_request *request, static inline void unmap_dma_buffer(struct musb_request *request,

Re: [PATCH] usb: musb: gadget: do *unmap_dma_buffer* only for valid DMA addr

2013-03-18 Thread Felipe Balbi
Hi, On Mon, Mar 18, 2013 at 01:50:55PM +0530, kishon wrote: > >>>@@ -141,7 +141,7 @@ static inline void map_dma_buffer(struct musb_request > >>>*request, > >>> static inline void unmap_dma_buffer(struct musb_request *request, > >>> struct musb *musb) > >>> { > >>>- if

Re: [PATCH] usb: musb: gadget: do *unmap_dma_buffer* only for valid DMA addr

2013-03-18 Thread kishon
On Monday 18 March 2013 01:37 PM, Felipe Balbi wrote: On Fri, Mar 15, 2013 at 09:37:36PM +0530, kishon wrote: On Friday 15 March 2013 08:09 PM, Felipe Balbi wrote: From: Kishon Vijay Abraham I musb does not use DMA buffer for ep0 but it uses the same giveback function *musb_g_giveback* for al

Re: [PATCH] usb: musb: gadget: do *unmap_dma_buffer* only for valid DMA addr

2013-03-18 Thread Felipe Balbi
On Fri, Mar 15, 2013 at 09:37:36PM +0530, kishon wrote: > On Friday 15 March 2013 08:09 PM, Felipe Balbi wrote: > >From: Kishon Vijay Abraham I > > > >musb does not use DMA buffer for ep0 but it uses the same giveback > >function *musb_g_giveback* for all endpoints (*musb_g_ep0_giveback* calls > >

Re: [PATCH] usb: musb: gadget: do *unmap_dma_buffer* only for valid DMA addr

2013-03-15 Thread kishon
On Friday 15 March 2013 08:09 PM, Felipe Balbi wrote: From: Kishon Vijay Abraham I musb does not use DMA buffer for ep0 but it uses the same giveback function *musb_g_giveback* for all endpoints (*musb_g_ep0_giveback* calls *musb_g_giveback*). So for ep0 case request.dma will be '0' and will re

[PATCH] usb: musb: gadget: do *unmap_dma_buffer* only for valid DMA addr

2013-03-15 Thread Felipe Balbi
From: Kishon Vijay Abraham I musb does not use DMA buffer for ep0 but it uses the same giveback function *musb_g_giveback* for all endpoints (*musb_g_ep0_giveback* calls *musb_g_giveback*). So for ep0 case request.dma will be '0' and will result in kernel OOPS if tried to *unmap_dma_buffer* for r