Re: [PATCH] usb: roles: intel_xhci: Determine current role by DUAL_ROLE_CFG1

2018-10-11 Thread Heikki Krogerus
On Sat, Sep 29, 2018 at 10:26:20PM +0800, Yu Wang wrote: > The USB PHY mux switch depend on both USB2/USB3 PHY state and xHCI/xDCI > controller state. The role can't be switched if related states haven't > satisfied. That is why we need to poll the DUAL_ROLE_CFG1 to check if > the role switched

Re: [PATCH] usb: roles: intel_xhci: Determine current role by DUAL_ROLE_CFG1

2018-10-10 Thread Hans de Goede
Hi All, On 29-09-18 16:26, Yu Wang wrote: The USB PHY mux switch depend on both USB2/USB3 PHY state and xHCI/xDCI controller state. The role can't be switched if related states haven't satisfied. That is why we need to poll the DUAL_ROLE_CFG1 to check if the role switched successful or not. So

Re: [PATCH] usb: roles: intel_xhci: Determine current role by DUAL_ROLE_CFG1

2018-10-01 Thread Heikki Krogerus
On Mon, Oct 01, 2018 at 04:23:31PM +0200, Hans de Goede wrote: > On 29-09-18 16:26, Yu Wang wrote: > > The USB PHY mux switch depend on both USB2/USB3 PHY state and xHCI/xDCI > > controller state. The role can't be switched if related states haven't > > satisfied. That is why we need to poll the

Re: [PATCH] usb: roles: intel_xhci: Determine current role by DUAL_ROLE_CFG1

2018-10-01 Thread Hans de Goede
Hi, On 01-10-18 16:53, Wang, Yu1 wrote: Hi Hans, On 18-10-01 16:23:31, Hans de Goede wrote: Hi, On 29-09-18 16:26, Yu Wang wrote: The USB PHY mux switch depend on both USB2/USB3 PHY state and xHCI/xDCI controller state. The role can't be switched if related states haven't satisfied. That is

Re: [PATCH] usb: roles: intel_xhci: Determine current role by DUAL_ROLE_CFG1

2018-10-01 Thread Hans de Goede
Hi, On 29-09-18 16:26, Yu Wang wrote: The USB PHY mux switch depend on both USB2/USB3 PHY state and xHCI/xDCI controller state. The role can't be switched if related states haven't satisfied. That is why we need to poll the DUAL_ROLE_CFG1 to check if the role switched successful or not. So the

[PATCH] usb: roles: intel_xhci: Determine current role by DUAL_ROLE_CFG1

2018-09-29 Thread Yu Wang
The USB PHY mux switch depend on both USB2/USB3 PHY state and xHCI/xDCI controller state. The role can't be switched if related states haven't satisfied. That is why we need to poll the DUAL_ROLE_CFG1 to check if the role switched successful or not. So the SW_IDPIN and SW_VBUS_VALID bits can't