Re: [PATCH] usb: serial: Add USB identifier for the Motorola/Telit H24 HSPA module

2014-04-23 Thread Alexander Stein
On Wednesday 26 March 2014 13:38:29, Oliver Neukum wrote: > On Wed, 2014-03-26 at 13:18 +0100, Alexander Stein wrote: > > On Wednesday 26 March 2014 12:38:24, Oliver Neukum wrote: > > > On Tue, 2014-03-25 at 10:34 +0100, Alexander Stein wrote: > > > > As the module does not use the standard USB mec

Re: [PATCH] usb: serial: Add USB identifier for the Motorola/Telit H24 HSPA module

2014-03-26 Thread Alexander Stein
On Wednesday 26 March 2014 11:01:54, Dan Williams wrote: > On Tue, 2014-03-25 at 10:34 +0100, Alexander Stein wrote: > > As the module does not use the standard USB mechanism, the appropriate > > product and vendor IDs have to be added. > > Should these really be going into usb-serial-simple? If

Re: [PATCH] usb: serial: Add USB identifier for the Motorola/Telit H24 HSPA module

2014-03-26 Thread Johan Hovold
On Wed, Mar 26, 2014 at 11:01:54AM -0500, Dan Williams wrote: > On Tue, 2014-03-25 at 10:34 +0100, Alexander Stein wrote: > > As the module does not use the standard USB mechanism, the appropriate > > product and vendor IDs have to be added. > > Should these really be going into usb-serial-simple?

Re: [PATCH] usb: serial: Add USB identifier for the Motorola/Telit H24 HSPA module

2014-03-26 Thread Dan Williams
On Tue, 2014-03-25 at 10:34 +0100, Alexander Stein wrote: > As the module does not use the standard USB mechanism, the appropriate > product and vendor IDs have to be added. Should these really be going into usb-serial-simple? If they are indeed the PPP/Modem interface, then isn't something like

Re: [PATCH] usb: serial: Add USB identifier for the Motorola/Telit H24 HSPA module

2014-03-26 Thread Oliver Neukum
On Wed, 2014-03-26 at 13:18 +0100, Alexander Stein wrote: > On Wednesday 26 March 2014 12:38:24, Oliver Neukum wrote: > > On Tue, 2014-03-25 at 10:34 +0100, Alexander Stein wrote: > > > As the module does not use the standard USB mechanism, the appropriate > > > product and vendor IDs have to be ad

Re: [PATCH] usb: serial: Add USB identifier for the Motorola/Telit H24 HSPA module

2014-03-26 Thread Alexander Stein
On Wednesday 26 March 2014 12:38:24, Oliver Neukum wrote: > On Tue, 2014-03-25 at 10:34 +0100, Alexander Stein wrote: > > As the module does not use the standard USB mechanism, the appropriate > > product and vendor IDs have to be added. > > Wait, stop. How do you make sure the other interfaces ar

Re: [PATCH] usb: serial: Add USB identifier for the Motorola/Telit H24 HSPA module

2014-03-26 Thread Oliver Neukum
On Tue, 2014-03-25 at 10:34 +0100, Alexander Stein wrote: > As the module does not use the standard USB mechanism, the appropriate > product and vendor IDs have to be added. Wait, stop. How do you make sure the other interfaces are left to cdc-acm? Regards Oliver -- To u

[PATCH] usb: serial: Add USB identifier for the Motorola/Telit H24 HSPA module

2014-03-25 Thread Alexander Stein
As the module does not use the standard USB mechanism, the appropriate product and vendor IDs have to be added. Signed-off-by: Michael Ulbricht Signed-off-by: Alexander Stein --- drivers/usb/serial/usb-serial-simple.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --gi