Re: [PATCH] usb: xhci: Add quirk for Certain failing HP keyboard on reset after resume

2017-08-02 Thread Sandeep Singh
On 7/31/2017 9:16 PM, Greg KH wrote: > > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing in e-mail? > > A: No. > Q: Should I include quotations after my reply? > > >

Re: [PATCH] usb: xhci: Add quirk for Certain failing HP keyboard on reset after resume

2017-07-31 Thread Greg KH
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Mon, Jul 31, 2017 at

Re: [PATCH] usb: xhci: Add quirk for Certain failing HP keyboard on reset after resume

2017-07-31 Thread Sandeep Singh
Hi Greg, Thanks for review. Apart from pci_ids.h, I see only 3 options, add this id as macro in pci_quirks.c or pci_quirks.h or just hardcode it. please suggest what will good option as per your view. Regards Sandeep On 7/30/2017 7:41 PM, Greg KH wrote: > On Thu, Jul 27, 2017 at 02:05:09PM

Re: [PATCH] usb: xhci: Add quirk for Certain failing HP keyboard on reset after resume

2017-07-30 Thread Greg KH
On Thu, Jul 27, 2017 at 02:05:09PM +0530, Sandeep Singh wrote: > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h > index c71e532..d3f2296 100644 > --- a/include/linux/pci_ids.h > +++ b/include/linux/pci_ids.h > @@ -583,6 +583,7 @@ > #define PCI_DEVICE_ID_AMD_HUDSON2_SMBUS

[PATCH] usb: xhci: Add quirk for Certain failing HP keyboard on reset after resume

2017-07-27 Thread Sandeep Singh
From: Sandeep Singh Certain HP keyboards would keep inputting a character automatically which is the wake-up key after S3 resume On some AMD platforms USB host fails to respond (by holding resume-K) to USB device (an HP keyboard) resume request within 1ms (TURSM) and