Re: [PATCH] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-11-08 Thread Andrew Lunn
> Hopefully my comments will suffice as guidance for mxuport, but we could > iterate the flow-control handling separate from the other changes if you > want. Hi Johan I just posted v5. It would be good if you could take a look at the flow-control changes first. Thanks Andrew -- To unsubs

Re: [PATCH] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-11-07 Thread Johan Hovold
On Thu, Nov 07, 2013 at 03:39:16PM +0100, Andrew Lunn wrote: > Hi Johan > > Thanks for the review. > > I have a few questions, points to raise. > > > > + /* Submit the vendor request */ > > > + buf[0] = data_bits; > > > + buf[1] = parity; > > > + buf[2] = stop_bits; > > > + buf[3] = 0; > > > + >

Re: [PATCH] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-11-07 Thread Andrew Lunn
Hi Johan Thanks for the review. I have a few questions, points to raise. > > + /* Submit the vendor request */ > > + buf[0] = data_bits; > > + buf[1] = parity; > > + buf[2] = stop_bits; > > + buf[3] = 0; > > + > > + err = mxuport_send_ctrl_data_urb(serial, RQ_VENDOR_SET_LINE, > > +

Re: [PATCH] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-11-07 Thread Johan Hovold
On Wed, Oct 23, 2013 at 02:51:49PM +0200, Andrew Lunn wrote: > Add a driver which supports the following Moxa USB to serial converters: > * 2 ports : UPort 1250, UPort 1250I > * 4 ports : UPort 1410, UPort 1450, UPort 1450I > * 8 ports : UPort 1610-8, UPort 1650-8 > * 16 port

[PATCH] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-10-23 Thread Andrew Lunn
Add a driver which supports the following Moxa USB to serial converters: * 2 ports : UPort 1250, UPort 1250I * 4 ports : UPort 1410, UPort 1450, UPort 1450I * 8 ports : UPort 1610-8, UPort 1650-8 * 16 ports : UPort 1610-16, UPort 1650-16 The UPORT devices don't directy fit t