Re: [PATCH] usb-storage: scsiglue: Changing the command result

2013-12-10 Thread Vishal Annapurve
Hi Greg, There was problem with my email client. Hope now it is fine. --- [PATCH 1/3] usb: storage: Proper cmd result assignment This change replaces DID_ABORT with DID_TIMEOUT as a command result whenever US_FLIDX_TIMED_OUT bit is set. This change is made to bring USB storage inline with a

Re: [PATCH] usb-storage: scsiglue: Changing the command result

2013-12-09 Thread Greg KH
On Sat, Nov 16, 2013 at 12:23:50PM +0530, Vishal Annapurve wrote: Hi, Here are the updated patches: Can you please resend these in a format which I can apply them in without having to hand-edit all three of them? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] usb-storage: scsiglue: Changing the command result

2013-12-09 Thread Vishal Annapurve
Hi Greg, Attached are the patches. Regards, Vishal On Monday 09 December 2013 07:29 AM, Greg KH wrote: On Sat, Nov 16, 2013 at 12:23:50PM +0530, Vishal Annapurve wrote: Hi, Here are the updated patches: Can you please resend these in a format which I can apply them in without having to

Re: [PATCH] usb-storage: scsiglue: Changing the command result

2013-12-09 Thread Oliver Neukum
On Mon, 2013-12-09 at 15:14 +0530, Vishal Annapurve wrote: Hi Greg, Attached are the patches. Hi, please send patches in the clear, inline, one patch per mail and with a Signed-off-by line, as described in the Documentation directory of the kernel. Regards Oliver --

Re: [PATCH] usb-storage: scsiglue: Changing the command result

2013-12-09 Thread Greg KH
On Mon, Dec 09, 2013 at 03:14:07PM +0530, Vishal Annapurve wrote: Hi Greg, Attached are the patches. As Oliver said, I can't take these, please read Documentation/SubmittingPatches for how to do this properly. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] usb-storage: scsiglue: Changing the command result

2013-12-09 Thread Vishal Annapurve
Hi Greg, Does this look fine? I will send over other patches once you confirm. Patch set 1: - [PATCH 1/3] usb: storage: Proper cmd result assignment This change replaces DID_ABORT with DID_TIMEOUT as a command result whenever US_FLIDX_TIMED_OUT bit is set. This change is made to bring

Re: [PATCH] usb-storage: scsiglue: Changing the command result

2013-12-09 Thread Greg KH
On Tue, Dec 10, 2013 at 10:53:59AM +0530, Vishal Annapurve wrote: Hi Greg, Does this look fine? I will send over other patches once you confirm. I'm not going to confirm a broken format... Please go read the file I pointed you at as to how to properly do this. greg k-h -- To unsubscribe

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-11-18 Thread Alan Stern
On Sat, 16 Nov 2013, Vishal Annapurve wrote: Hi, Here are the updated patches: [PATCH 1/3] usb: storage: Proper cmd result assignment This change replaces DID_ABORT with DID_TIMEOUT as a command result whenever US_FLIDX_TIMED_OUT bit is set. This change is made to bring USB storage

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-11-15 Thread Vishal Annapurve
To: Vishal Annapurve Cc: Ming Lei; Linux Kernel Mailing List; linux-usb Subject: RE: [PATCH] usb-storage: scsiglue: Changing the command result On Sat, 26 Oct 2013, Vishal Annapurve wrote: Hi Alan, Here is the new patch: From: Vishal Annapurve vannapu...@nvidia.com Date: Sat, 26 Oct 2013 21:10

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-11-15 Thread Vishal Annapurve
-usb Subject: RE: [PATCH] usb-storage: scsiglue: Changing the command result Hi, Here are the updated patches: [PATCH 1/3] usb: storage: Proper cmd result assignment This change replaces DID_ABORT with DID_TIMEOUT as a command result whenever US_FLIDX_TIMED_OUT bit is set. This change

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-11-15 Thread Vishal Annapurve
'; 'linux-usb' Subject: RE: [PATCH] usb-storage: scsiglue: Changing the command result Hi, [PATCH 2/3] keucr: Proper cmd result assignment This change replaces DID_ABORT with DID_TIMEOUT as a command result whenever US_FLIDX_TIMED_OUT bit is set. This change is made to bring USB storage inline

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-26 Thread Vishal Annapurve
(US_FLIDX_TIMED_OUT, us-dflags)) { -- 1.8.4 Regards, Vishal -Original Message- From: Alan Stern [mailto:st...@rowland.harvard.edu] Sent: Monday, October 21, 2013 7:23 PM To: Vishal Annapurve Cc: Ming Lei; Linux Kernel Mailing List; linux-usb Subject: RE: [PATCH] usb-storage: scsiglue: Changing

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-26 Thread Alan Stern
On Sat, 26 Oct 2013, Vishal Annapurve wrote: Hi Alan, Here is the new patch: From: Vishal Annapurve vannapu...@nvidia.com Date: Sat, 26 Oct 2013 21:10:11 +0530 Subject: [PATCH] usb: storage: Proper cmd result assignment This change replaces DID_ABORT with DID_TIMEOUT as a command

Re: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-26 Thread Greg KH
On Sat, 26 Oct 2013, Vishal Annapurve wrote: Hi Alan, Here is the new patch: From: Vishal Annapurve vannapu...@nvidia.com Date: Sat, 26 Oct 2013 21:10:11 +0530 Subject: [PATCH] usb: storage: Proper cmd result assignment This change replaces DID_ABORT with DID_TIMEOUT as a command

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-18 Thread Alan Stern
On Fri, 18 Oct 2013, Vishal Annapurve wrote: Hi Alan, What I wanted to say was If the bit US_FLIDX_TIMED_OUT can have more meanings than timed out then maybe it would be best to override the results after usb-storage is done with the command maybe in scsi layer itself who aborted it in the

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-17 Thread Vishal Annapurve
? Regards, Vishal -Original Message- From: Alan Stern [mailto:st...@rowland.harvard.edu] Sent: Tuesday, October 15, 2013 10:22 PM To: Vishal Annapurve Cc: Ming Lei; Linux Kernel Mailing List; linux-usb Subject: RE: [PATCH] usb-storage: scsiglue: Changing the command result On Tue, 15 Oct 2013

Re: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-16 Thread Alan Stern
On Wed, 16 Oct 2013, Ming Lei wrote: Of course the SCSI midlayer has decided to abort. That's the only way this bit can get set. But usb-storage doesn't know why SCSI decided to abort. usb-storage may know if it is caused by timeout via .eh_timed_out callback if it wants to know. Ah,

Re: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-15 Thread Ming Lei
On Thu, Sep 26, 2013 at 7:35 PM, Vishal Annapurve vannapu...@nvidia.com wrote: Hi, There was a recent commit in mainline for the scsi devices which do not respond properly to medium access command: commit18a4d0a22ed6c54b67af7718c305cd010f09ddf8 [SCSI] Handle disk devices which can not

Re: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-15 Thread Alan Stern
On Tue, 15 Oct 2013, Ming Lei wrote: On Thu, Sep 26, 2013 at 7:35 PM, Vishal Annapurve vannapu...@nvidia.com wrote: Hi, There was a recent commit in mainline for the scsi devices which do not respond properly to medium access command: commit

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-15 Thread Vishal Annapurve
-Original Message- From: Alan Stern [mailto:st...@rowland.harvard.edu] Sent: Tuesday, October 15, 2013 5:55 PM To: Ming Lei Cc: Vishal Annapurve; Linux Kernel Mailing List; linux-usb Subject: Re: [PATCH] usb-storage: scsiglue: Changing the command result On Tue, 15 Oct 2013, Ming Lei wrote

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-15 Thread Alan Stern
On Tue, 15 Oct 2013, Vishal Annapurve wrote: Hi Alan, This issue seems more related to the devices using SCSI protocol and the changes otherwise will be at more places giving the same end result. I think as the comment says over the command_abort function, intentional result change

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-15 Thread Vishal Annapurve
Mailing List; linux-usb Subject: RE: [PATCH] usb-storage: scsiglue: Changing the command result On Tue, 15 Oct 2013, Vishal Annapurve wrote: Hi Alan, This issue seems more related to the devices using SCSI protocol and the changes otherwise will be at more places giving the same end result. I

RE: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-15 Thread Alan Stern
On Tue, 15 Oct 2013, Vishal Annapurve wrote: Hi Alan, USB storage maybe just has to say that the abort occurred. By setting the US_FLIDX_TIMED_OUT bit USB storage is getting signaled that the reason was time out and the command is being aborted. No. By setting the US_FLIDX_TIMED_OUT bit,

Re: [PATCH] usb-storage: scsiglue: Changing the command result

2013-10-15 Thread Ming Lei
On Wed, Oct 16, 2013 at 4:22 AM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 15 Oct 2013, Vishal Annapurve wrote: Hi Alan, USB storage maybe just has to say that the abort occurred. By setting the US_FLIDX_TIMED_OUT bit USB storage is getting signaled that the reason was time out