Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-23 Thread Vivek Gautam
Hi Sylwester, On Wed, Jan 23, 2013 at 6:10 PM, Sylwester Nawrocki wrote: > Hi, > > On 01/23/2013 01:20 PM, Vivek Gautam wrote: >> - { .compatible = "samsung,exynos-dwc3" }, >> + { .compatible = "samsung,synopsis-dwc3" } > > You're both missing a point here. The synopsys I

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-23 Thread Sylwester Nawrocki
Hi, On 01/23/2013 01:20 PM, Vivek Gautam wrote: > - { .compatible = "samsung,exynos-dwc3" }, > + { .compatible = "samsung,synopsis-dwc3" } You're both missing a point here. The synopsys IP driver is called dwc3.ko and that's compatible with synopsys,dwc3. Your glue l

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-23 Thread Vivek Gautam
Hi all, On Wed, Jan 23, 2013 at 3:20 PM, Felipe Balbi wrote: > Hi, > > On Tue, Jan 22, 2013 at 02:04:56PM -0800, Kukjin Kim wrote: >> Felipe Balbi wrote: >> > Hi, >> > >> Hi Felipe, >> >> [...] >> >> > > Right, DWC has version number, but that being the kind of USB controller >> > > (USB 2.0 and

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-23 Thread Felipe Balbi
Hi, On Tue, Jan 22, 2013 at 02:04:56PM -0800, Kukjin Kim wrote: > Felipe Balbi wrote: > > Hi, > > > Hi Felipe, > > [...] > > > > Right, DWC has version number, but that being the kind of USB controller > > > (USB 2.0 and USB 3.0) > > > > > > DWC2: USB High Speed controller (as also indicated in

RE: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-22 Thread Kukjin Kim
Felipe Balbi wrote: > Hi, > Hi Felipe, [...] > > Right, DWC has version number, but that being the kind of USB controller > > (USB 2.0 and USB 3.0) > > > > DWC2: USB High Speed controller (as also indicated in the patch from > > Paul: [RFC PATCH 0/6] DWC2 DesignWare HS OTG driver) > > DWC3: USB

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-22 Thread Sylwester Nawrocki
On 01/22/2013 06:35 AM, Kukjin Kim wrote: > - { .compatible = "samsung,exynos-dwc3" }, > + { .compatible = "samsung,synopsis-dwc3" }, > > Or if any version or something, how about following? > > + { .compatible = "samsung,dwc-v3" }, > >>> Well, yes the newer

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-22 Thread Felipe Balbi
Hi, On Tue, Jan 22, 2013 at 11:18:55AM +0530, Vivek Gautam wrote: > On Tue, Jan 22, 2013 at 11:05 AM, Kukjin Kim wrote: > > Sylwester Nawrocki wrote: > >> > >> On 12/24/2012 09:13 AM, Vivek Gautam wrote: > >> These two changes look good to me. For both of them: > >> > >> Reviewed-

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-21 Thread Vivek Gautam
Hi Kukjin, On Tue, Jan 22, 2013 at 11:05 AM, Kukjin Kim wrote: > Sylwester Nawrocki wrote: >> >> On 12/24/2012 09:13 AM, Vivek Gautam wrote: >> These two changes look good to me. For both of them: >> >> Reviewed-by: Doug Anderson >> >>> >> >>> Well, I have another idea. Yes, I kn

RE: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-21 Thread Kukjin Kim
Sylwester Nawrocki wrote: > > On 12/24/2012 09:13 AM, Vivek Gautam wrote: > These two changes look good to me. For both of them: > > Reviewed-by: Doug Anderson > >>> > >>> Well, I have another idea. Yes, I know, specific chip name should be used. > >> But > >>> you know the specifi

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2013-01-15 Thread Vivek Gautam
On Thu, Dec 27, 2012 at 4:28 AM, Sylwester Nawrocki wrote: > On 12/24/2012 09:13 AM, Vivek Gautam wrote: > > These two changes look good to me. For both of them: > > Reviewed-by: Doug Anderson Well, I have another idea. Yes, I know, specific chip name should be

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-26 Thread Sylwester Nawrocki
On 12/24/2012 09:13 AM, Vivek Gautam wrote: These two changes look good to me. For both of them: Reviewed-by: Doug Anderson Well, I have another idea. Yes, I know, specific chip name should be used. But you know the specific chip name in compatible can cause another confusion on other SoC w

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-24 Thread Vivek Gautam
Hi Kukjin, On Mon, Dec 24, 2012 at 4:45 AM, Kukjin Kim wrote: > Kukjin Kim wrote: >> > Re-sending due to e-mail client problem... > >> Doug Anderson wrote: >> > >> > On Fri, Dec 21, 2012 at 12:14 AM, Vivek Gautam >> > wrote: >> > > On Wed, Dec 19, 2012 at 7:16 PM, Vivek Gautam >> > wrote: >> >

RE: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-23 Thread Kukjin Kim
Kukjin Kim wrote: > Re-sending due to e-mail client problem... > Doug Anderson wrote: > > > > On Fri, Dec 21, 2012 at 12:14 AM, Vivek Gautam > > wrote: > > > On Wed, Dec 19, 2012 at 7:16 PM, Vivek Gautam > > wrote: > > >> > > >> On Sat, Dec 15, 2012 at 12:50 PM, Grant Likely > > >> wrote: > >

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-21 Thread Doug Anderson
On Fri, Dec 21, 2012 at 12:14 AM, Vivek Gautam wrote: > On Wed, Dec 19, 2012 at 7:16 PM, Vivek Gautam > wrote: >> >> On Sat, Dec 15, 2012 at 12:50 PM, Grant Likely >> wrote: >>> On Thu, 13 Dec 2012 20:22:26 +0530, Vivek Gautam >>> wrote: Using chip specific compatible string as it should

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-21 Thread Vivek Gautam
Hi all, On Wed, Dec 19, 2012 at 7:16 PM, Vivek Gautam wrote: > CC: Doug Anderson > > > On Sat, Dec 15, 2012 at 12:50 PM, Grant Likely > wrote: >> On Thu, 13 Dec 2012 20:22:26 +0530, Vivek Gautam >> wrote: >>> Using chip specific compatible string as it should be. >>> So fixing this for ehci-s

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-19 Thread Vivek Gautam
CC: Doug Anderson On Sat, Dec 15, 2012 at 12:50 PM, Grant Likely wrote: > On Thu, 13 Dec 2012 20:22:26 +0530, Vivek Gautam > wrote: >> Using chip specific compatible string as it should be. >> So fixing this for ehci-s5p, ohci-exynos and dwc3-exynos >> which till now used a generic 'exynos' in

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-16 Thread Grant Likely
On Thu, 13 Dec 2012 20:22:26 +0530, Vivek Gautam wrote: > Using chip specific compatible string as it should be. > So fixing this for ehci-s5p, ohci-exynos and dwc3-exynos > which till now used a generic 'exynos' in their compatible strings. > > This goes as per the discussion happened in the th

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-13 Thread Vivek Gautam
CC: LKML On Thu, Dec 13, 2012 at 8:22 PM, Vivek Gautam wrote: > Using chip specific compatible string as it should be. > So fixing this for ehci-s5p, ohci-exynos and dwc3-exynos > which till now used a generic 'exynos' in their compatible strings. > > This goes as per the discussion happened in t

[PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-13 Thread Vivek Gautam
Using chip specific compatible string as it should be. So fixing this for ehci-s5p, ohci-exynos and dwc3-exynos which till now used a generic 'exynos' in their compatible strings. This goes as per the discussion happened in the thread for [PATCH v2] ARM: Exynos5250: Enabling dwc3-exynos driver ava