Re: [PATCH 06/37] usb: host: xhci: WARN on unexpected COMP_SUCCESS

2017-01-13 Thread Mathias Nyman
On 29.12.2016 13:00, Felipe Balbi wrote: COMP_SUCCESS should only be asserted on a *true* sucessful transfer. Any other cases are bogus and we should aim to catch them. One easy way to get bug reports is to trigger a WARN_ONCE() on such cases. Signed-off-by: Felipe Balbi Skipping 6/37 and 7/

Re: [PATCH 06/37] usb: host: xhci: WARN on unexpected COMP_SUCCESS

2016-12-29 Thread Felipe Balbi
Hi, Lu Baolu writes: > On 12/29/2016 07:00 PM, Felipe Balbi wrote: >> COMP_SUCCESS should only be asserted on a *true* sucessful transfer. Any >> other cases are bogus and we should aim to catch them. One easy way to >> get bug reports is to trigger a WARN_ONCE() on such cases. >> >> Signed-off-

Re: [PATCH 06/37] usb: host: xhci: WARN on unexpected COMP_SUCCESS

2016-12-29 Thread Lu Baolu
Hi, On 12/29/2016 07:00 PM, Felipe Balbi wrote: > COMP_SUCCESS should only be asserted on a *true* sucessful transfer. Any > other cases are bogus and we should aim to catch them. One easy way to > get bug reports is to trigger a WARN_ONCE() on such cases. > > Signed-off-by: Felipe Balbi > --- >

[PATCH 06/37] usb: host: xhci: WARN on unexpected COMP_SUCCESS

2016-12-29 Thread Felipe Balbi
COMP_SUCCESS should only be asserted on a *true* sucessful transfer. Any other cases are bogus and we should aim to catch them. One easy way to get bug reports is to trigger a WARN_ONCE() on such cases. Signed-off-by: Felipe Balbi --- drivers/usb/host/xhci-ring.c | 28 +++