Re: [PATCH 1/2] usb: chipidea: usbmisc: skip clocks on i.MX6

2014-12-10 Thread Philipp Zabel
Hi Peter, Am Mittwoch, den 10.12.2014, 13:09 +0800 schrieb Peter Chen: > On Tue, Dec 09, 2014 at 05:13:35PM +0100, Philipp Zabel wrote: > > On i.MX6Q, the USBMISC registers are clocked by the IPG clock, > > so there is no need to enable USBOH3 for the USBMISC driver. > > Access the registers at u

Re: [PATCH 1/2] usb: chipidea: usbmisc: skip clocks on i.MX6

2014-12-09 Thread Uwe Kleine-König
Hello Philipp, On Tue, Dec 09, 2014 at 05:13:35PM +0100, Philipp Zabel wrote: > + /* on i.MX6Q, the USBMISC register space is clocked by the IPG clock */ > + if (data->ops != &imx6q_usbmisc_ops) { > + data->clk = devm_clk_get(&pdev->dev, NULL); I wonder if it was better/simpler

Re: [PATCH 1/2] usb: chipidea: usbmisc: skip clocks on i.MX6

2014-12-09 Thread Peter Chen
On Tue, Dec 09, 2014 at 05:13:35PM +0100, Philipp Zabel wrote: > On i.MX6Q, the USBMISC registers are clocked by the IPG clock, > so there is no need to enable USBOH3 for the USBMISC driver. > Access the registers at usbmisc needs the same clock with chipidea core, both are usboh3. For i.mx6 ser

[PATCH 1/2] usb: chipidea: usbmisc: skip clocks on i.MX6

2014-12-09 Thread Philipp Zabel
On i.MX6Q, the USBMISC registers are clocked by the IPG clock, so there is no need to enable USBOH3 for the USBMISC driver. Signed-off-by: Philipp Zabel --- drivers/usb/chipidea/usbmisc_imx.c | 32 ++-- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/d