Re: [PATCH 1/3] usb: gadget: uvc: Factor out video USB request queueing

2018-09-25 Thread Kieran Bingham
Hi Laurent, On 18/09/18 11:35, Laurent Pinchart wrote: > USB requests for video data are queued from two different locations in > the driver, with the same code block occurring twice. Factor it out to a > function. > > Signed-off-by: Laurent Pinchart Looks good, and simplifies locking. Win win.

Re: [PATCH 1/3] usb: gadget: uvc: Factor out video USB request queueing

2018-09-24 Thread Paul Elder
On Tue, Sep 18, 2018 at 01:35:30PM +0300, Laurent Pinchart wrote: > USB requests for video data are queued from two different locations in > the driver, with the same code block occurring twice. Factor it out to a > function. > > Signed-off-by: Laurent Pinchart For the whole series: Looks good

[PATCH 1/3] usb: gadget: uvc: Factor out video USB request queueing

2018-09-18 Thread Laurent Pinchart
USB requests for video data are queued from two different locations in the driver, with the same code block occurring twice. Factor it out to a function. Signed-off-by: Laurent Pinchart --- drivers/usb/gadget/function/uvc_video.c | 30 -- 1 file changed, 20 insertions