[PATCH 1/5] xhci: Don't change the ownership of LINK TRB until all the TRB are written

2014-01-21 Thread David Laight
Some xhci controllers (eg ASMedia) don't like processing a LINK TRB and then finding that they can't process the next TRB. Instead of flipping the cycle bit on the first data TRB, remember the real first TRB in prepare_ring() and flip that in giveback_first_trb(). In queue_trb() ignore the cycle

Re: [PATCH 1/5] xhci: Don't change the ownership of LINK TRB until all the TRB are written

2014-01-22 Thread Sarah Sharp
Hi David, I've been thinking about this some more, and I'd like to propose a much simpler solution. The TD fragment rules didn't go into the xHCI specification until the 1.0 revision. The code that follows those rules only seems to trigger issues for 0.96 ASMedia hosts, while Intel 1.0 hosts ben

Re: [PATCH 1/5] xhci: Don't change the ownership of LINK TRB until all the TRB are written

2014-01-22 Thread walt
On 01/22/2014 12:56 PM, Sarah Sharp wrote: > Walt, can you turn on xHCI debugging and look for whether the NEC host > that worked with David's patch is a 1.0 host? You'll see a line like: > > // @%p = 0x%x (CAPLENGTH AND HCIVERSION) Hi Sarah. This is from the NEC host controller, *not* the ASMe

Re: [PATCH 1/5] xhci: Don't change the ownership of LINK TRB until all the TRB are written

2014-01-22 Thread Sarah Sharp
On Wed, Jan 22, 2014 at 03:22:53PM -0800, walt wrote: > On 01/22/2014 12:56 PM, Sarah Sharp wrote: > > Walt, can you turn on xHCI debugging and look for whether the NEC host > > that worked with David's patch is a 1.0 host? You'll see a line like: > > > > // @%p = 0x%x (CAPLENGTH AND HCIVERSION)

RE: [PATCH 1/5] xhci: Don't change the ownership of LINK TRB until all the TRB are written

2014-01-23 Thread David Laight
From: Sarah Sharp > Hi David, > > I've been thinking about this some more, and I'd like to propose a much > simpler solution. > > The TD fragment rules didn't go into the xHCI specification until the > 1.0 revision. The code that follows those rules only seems to trigger > issues for 0.96 ASMedi

Re: [PATCH 1/5] xhci: Don't change the ownership of LINK TRB until all the TRB are written

2014-01-27 Thread Sarah Sharp
On Thu, Jan 23, 2014 at 10:35:56AM +, David Laight wrote: > From: Sarah Sharp > > Hi David, > > > > I've been thinking about this some more, and I'd like to propose a much > > simpler solution. > > > > The TD fragment rules didn't go into the xHCI specification until the > > 1.0 revision. Th

RE: [PATCH 1/5] xhci: Don't change the ownership of LINK TRB until all the TRB are written

2014-01-29 Thread David Laight
From: Sarah Sharp > On Wed, Jan 22, 2014 at 03:22:53PM -0800, walt wrote: > > On 01/22/2014 12:56 PM, Sarah Sharp wrote: > > > Walt, can you turn on xHCI debugging and look for whether the NEC host > > > that worked with David's patch is a 1.0 host? You'll see a line like: > > > > > > // @%p = 0x%

RE: [PATCH 1/5] xhci: Don't change the ownership of LINK TRB until all the TRB are written

2014-01-29 Thread David Laight
From: Sarah Sharp > Hi David, > > I've been thinking about this some more, and I'd like to propose a much > simpler solution. > > The TD fragment rules didn't go into the xHCI specification until the > 1.0 revision. The code that follows those rules only seems to trigger > issues for 0.96 ASMed