[PATCH 1/9] usb/gadget: start with libcomposite

2012-08-23 Thread Sebastian Andrzej Siewior
This patch aims to be simple. It removes #include usbstribgs.c line from each gadget and creats libcomposite.ko which has only one member, that is usbstribgs.c. To avoid mass select statements in Kconfig I simply group the composite based gadgets together. The three gadgets which are not part of th

Re: [PATCH 1/9] usb/gadget: start with libcomposite

2012-08-23 Thread Michal Nazarewicz
Sebastian Andrzej Siewior writes: > This patch aims to be simple. It removes #include usbstribgs.c line from each > gadget and creats libcomposite.ko which has only one member, that is > usbstribgs.c. > To avoid mass select statements in Kconfig I simply group the composite > based gadgets togethe

Re: [PATCH 1/9] usb/gadget: start with libcomposite

2012-08-23 Thread Sebastian Andrzej Siewior
On 08/23/2012 03:07 PM, Michal Nazarewicz wrote: Perhaps also wrap declaration of usb_gadget_get_string() with an #ifdef in include/linux/usb/gadget.h? This way, anything trying to use the function w/o USB_LIBCOMPOSITE selected will fail to compile rather than failing to load. Good hint. The f

Re: [PATCH 1/9] usb/gadget: start with libcomposite

2012-08-23 Thread Alan Stern
On Thu, 23 Aug 2012, Sebastian Andrzej Siewior wrote: > This patch aims to be simple. It removes #include usbstribgs.c line from each > gadget and creats libcomposite.ko which has only one member, that is > usbstribgs.c. > To avoid mass select statements in Kconfig I simply group the composite > b

Re: [PATCH 1/9] usb/gadget: start with libcomposite

2012-08-24 Thread Sebastian Andrzej Siewior
* Alan Stern | 2012-08-23 10:15:16 [-0400]: >> --- a/drivers/usb/gadget/Kconfig >> +++ b/drivers/usb/gadget/Kconfig >> @@ -507,6 +507,16 @@ config USB_GADGET_SUPERSPEED >> # >> # USB Gadget Drivers >> # >> + >> +# composite based drivers >> +config USB_LIBCOMPOSITE >> +tristate "Lib composi