Re: [PATCH 11/14] USB: serial: mos7840: move constants to right

2016-02-28 Thread Johan Hovold
On Mon, Feb 01, 2016 at 01:37:33PM +0100, Bjørn Mork wrote: > Mathieu OTHACEHE writes: > > On Sun, Jan 31, 2016 at 10:33:54PM +0100, Bjørn Mork wrote: > > > >> I feel I'm missing something here, so I have to ask the stupid question: > >> What could possibly be the benefit here? Is it faster? Safe

Re: [PATCH 11/14] USB: serial: mos7840: move constants to right

2016-02-01 Thread Bjørn Mork
Mathieu OTHACEHE writes: > On Sun, Jan 31, 2016 at 10:33:54PM +0100, Bjørn Mork wrote: > >> I feel I'm missing something here, so I have to ask the stupid question: >> What could possibly be the benefit here? Is it faster? Safer? Easier >> to read? > > I don't think it will be faster or safer, m

Re: [PATCH 11/14] USB: serial: mos7840: move constants to right

2016-02-01 Thread Mathieu OTHACEHE
On Sun, Jan 31, 2016 at 10:33:54PM +0100, Bjørn Mork wrote: > Mathieu OTHACEHE writes: > > > This patch fixes the following coccinelle warnings: > > > > drivers/usb/serial/mos7840.c:2042:4-10: Move constant to right. > > drivers/usb/serial/mos7840.c:2062:16-22: Move constant to right. > > > > Sig

Re: [PATCH 11/14] USB: serial: mos7840: move constants to right

2016-01-31 Thread Bjørn Mork
Mathieu OTHACEHE writes: > This patch fixes the following coccinelle warnings: > > drivers/usb/serial/mos7840.c:2042:4-10: Move constant to right. > drivers/usb/serial/mos7840.c:2062:16-22: Move constant to right. > > Signed-off-by: Mathieu OTHACEHE > --- > drivers/usb/serial/mos7840.c | 4 ++--

[PATCH 11/14] USB: serial: mos7840: move constants to right

2016-01-30 Thread Mathieu OTHACEHE
This patch fixes the following coccinelle warnings: drivers/usb/serial/mos7840.c:2042:4-10: Move constant to right. drivers/usb/serial/mos7840.c:2062:16-22: Move constant to right. Signed-off-by: Mathieu OTHACEHE --- drivers/usb/serial/mos7840.c | 4 ++-- 1 file changed, 2 insertions(+), 2 dele