Re: [PATCH 13/15] staging: usbip: userspace: libsrc: cleanup parsing

2013-04-05 Thread Greg KH
On Thu, Apr 04, 2013 at 04:03:14PM +0200, Stefan Reif wrote: > From: Kurt Kanzenbach > > Since the names.c/names.h are taken from another project, some > functions which names.c provides aren't used by usbipd. > This patch fixes: > - removed useless comments > - unified debug/error messages by

Re: [PATCH 13/15] staging: usbip: userspace: libsrc: cleanup parsing

2013-04-04 Thread Dan Carpenter
On Thu, Apr 04, 2013 at 10:10:10PM +0300, Dan Carpenter wrote: > > + if (buf[0] == 'P' && buf[1] == 'H' && buf[2] == 'Y' && > > + buf[3] == 'S' && buf[4] == 'D' && > > + buf[5] == 'E' && buf[6] == 'S' && /*isspace(buf[7])*/ > > + buf[7] == ' ') {

Re: [PATCH 13/15] staging: usbip: userspace: libsrc: cleanup parsing

2013-04-04 Thread Dan Carpenter
This one could probably have been broken into separate patches. > + if (buf[0] == 'P' && buf[1] == 'H' && buf[2] == 'Y' && > + buf[3] == 'S' && buf[4] == 'D' && > + buf[5] == 'E' && buf[6] == 'S' && /*isspace(buf[7])*/ > + buf[7] == ' ')

[PATCH 13/15] staging: usbip: userspace: libsrc: cleanup parsing

2013-04-04 Thread Stefan Reif
From: Kurt Kanzenbach Since the names.c/names.h are taken from another project, some functions which names.c provides aren't used by usbipd. This patch fixes: - removed useless comments - unified debug/error messages by using the macros provided by usbip_common.h - removed unnused code The