Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

On 09/06/16 16:58, Felipe Balbi wrote: > > Hi, > > Felipe Balbi writes: >>> However, if I comment out the phy_exit()/init(), phy_power_off/on() part >>> then >>> I do see the devices resume correctly. >> >> okay, so in some cases we don't want

Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

On 09/06/16 16:10, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >>> okay, so we actually want to power the hole thing down when in deep >>> sleep. What does deep sleep map to in linux parlance? suspend-to-ram? >>> suspend-to-disk? >> >> SoC standby == echo standby >

Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

Hi, Felipe Balbi writes: >> However, if I comment out the phy_exit()/init(), phy_power_off/on() part then >> I do see the devices resume correctly. > > okay, so in some cases we don't want phy_exit()/phy_init(), I can move > that elsewhere. Let me check. wait a

Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

Hi, Roger Quadros writes: >> okay, so we actually want to power the hole thing down when in deep >> sleep. What does deep sleep map to in linux parlance? suspend-to-ram? >> suspend-to-disk? > > SoC standby == echo standby > /sys/power/state > SoC deepsleep == echo mem >

Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

+Kishon, On 09/06/16 14:50, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: > we're only suspending with cable detached, if you need to maintain That's true only for device mode. What about host mode? Devices are still connected to the host port and are

Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

Hi, Roger Quadros writes: we're only suspending with cable detached, if you need to maintain >>> >>> That's true only for device mode. What about host mode? Devices are still >>> connected to the host port and are most probably just suspended, not >>> disconnected. >> >>

Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

On 09/06/16 13:58, Roger Quadros wrote: > On 09/06/16 12:27, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: >>> [ Unknown signature status ] >>> On 09/06/16 11:00, Felipe Balbi wrote: Hi, Roger Quadros writes: > Felipe, > >

Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

On 09/06/16 12:27, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> [ Unknown signature status ] >> On 09/06/16 11:00, Felipe Balbi wrote: >>> >>> Hi, >>> >>> Roger Quadros writes: Felipe, On 30/05/16 14:34, Felipe Balbi wrote: > now

Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

Hi, Roger Quadros writes: > [ Unknown signature status ] > On 09/06/16 11:00, Felipe Balbi wrote: >> >> Hi, >> >> Roger Quadros writes: >>> Felipe, >>> >>> On 30/05/16 14:34, Felipe Balbi wrote: now that we have re-factored dwc3_core_init() and

Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

On 09/06/16 11:00, Felipe Balbi wrote: > > Hi, > > Roger Quadros writes: >> Felipe, >> >> On 30/05/16 14:34, Felipe Balbi wrote: >>> now that we have re-factored dwc3_core_init() and >>> dwc3_core_exit() we can use them for suspend/resume >>> operations. >>> >>> This will help us

Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

Hi, Roger Quadros writes: > Felipe, > > On 30/05/16 14:34, Felipe Balbi wrote: >> now that we have re-factored dwc3_core_init() and >> dwc3_core_exit() we can use them for suspend/resume >> operations. >> >> This will help us avoid some common mistakes when >> patching code when

Re: [PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

Felipe, On 30/05/16 14:34, Felipe Balbi wrote: > now that we have re-factored dwc3_core_init() and > dwc3_core_exit() we can use them for suspend/resume > operations. > > This will help us avoid some common mistakes when > patching code when we have duplicated pieces of code > doing the same

[PATCH 18/62] usb: dwc3: core: simplify suspend/resume operations

now that we have re-factored dwc3_core_init() and dwc3_core_exit() we can use them for suspend/resume operations. This will help us avoid some common mistakes when patching code when we have duplicated pieces of code doing the same thing. Signed-off-by: Felipe Balbi