RE: [PATCH 2/2] usb: chipidea: usbmisc: Add support for i.MX51 CPU

2013-11-16 Thread Peter Chen
> > > This gives us some breathing room later to actually do the right > thing > > > without additionally performing renames all over the place to make > > > imx5 -> imx53 (again)/imx51 (new). > > > > You may take matt's suggestion, it can reduce the code change now and > in future. > > We can on

Re: [PATCH 2/2] usb: chipidea: usbmisc: Add support for i.MX51 CPU

2013-11-16 Thread Alexander Shiyan
Hello. > > > Signed-off-by: Alexander Shiyan > > > --- > > > drivers/usb/chipidea/usbmisc_imx.c | 40 +- > > > > > 1 file changed, 22 insertions(+), 18 deletions(-) > > > > > > > > > -static int usbmisc_imx53_init(struct imx_usbmisc_data *data) > > > +static

RE: [PATCH 2/2] usb: chipidea: usbmisc: Add support for i.MX51 CPU

2013-11-16 Thread Peter Chen
> > > > Signed-off-by: Alexander Shiyan > > --- > > drivers/usb/chipidea/usbmisc_imx.c | 40 +- > > > 1 file changed, 22 insertions(+), 18 deletions(-) > > > > > > -static int usbmisc_imx53_init(struct imx_usbmisc_data *data) > > +static int usbmisc_imx5_ini

Re: [PATCH 2/2] usb: chipidea: usbmisc: Add support for i.MX51 CPU

2013-11-14 Thread Matt Sealey
I'd prefer this was kept separated out a little bit, as follows: On Sun, Nov 10, 2013 at 1:18 AM, Alexander Shiyan wrote: > This adds i.MX51 as the next user of the usbmisc driver. > Since the functional is similar i.MX53, we just rename the > definitions and add an alias for the new CPU. > > Sig

Re: [PATCH 2/2] usb: chipidea: usbmisc: Add support for i.MX51 CPU

2013-11-14 Thread Peter Chen
On Sun, Nov 10, 2013 at 3:18 PM, Alexander Shiyan wrote: > This adds i.MX51 as the next user of the usbmisc driver. > Since the functional is similar i.MX53, we just rename the > definitions and add an alias for the new CPU. > > Signed-off-by: Alexander Shiyan > --- > drivers/usb/chipidea/usbmis

[PATCH 2/2] usb: chipidea: usbmisc: Add support for i.MX51 CPU

2013-11-09 Thread Alexander Shiyan
This adds i.MX51 as the next user of the usbmisc driver. Since the functional is similar i.MX53, we just rename the definitions and add an alias for the new CPU. Signed-off-by: Alexander Shiyan --- drivers/usb/chipidea/usbmisc_imx.c | 40 +- 1 file changed, 22