Re: [PATCH 2/2] xhci: fix last valid endpoint when dropping an endpoint

2013-10-11 Thread Xenia Ragiadakou
Hi Sarah, On 10/10/2013 09:25 PM, Sarah Sharp wrote: Hi Xenia, On Mon, Oct 07, 2013 at 06:52:39PM +0300, Xenia Ragiadakou wrote: The previous patch on the endpoint reset uses the already implemented function xhci_drop_endpoint() to reduce code duplication. However, the way that xhci updates

Re: [PATCH 2/2] xhci: fix last valid endpoint when dropping an endpoint

2013-10-11 Thread Xenia Ragiadakou
On 10/11/2013 11:40 AM, Xenia Ragiadakou wrote: [snip] The main reasons that made me come to this conclusion was the fact that Context Entries by being updated with a value other than the last valid endpoint will be inconsistent with the definition in xhci spec (revision 1.0 5/21/10) Context

Re: [PATCH 2/2] xhci: fix last valid endpoint when dropping an endpoint

2013-10-11 Thread Sarah Sharp
On Fri, Oct 11, 2013 at 11:40:07AM +0300, Xenia Ragiadakou wrote: Hi Sarah, On 10/10/2013 09:25 PM, Sarah Sharp wrote: Hi Xenia, On Mon, Oct 07, 2013 at 06:52:39PM +0300, Xenia Ragiadakou wrote: The previous patch on the endpoint reset uses the already implemented function

Re: [PATCH 2/2] xhci: fix last valid endpoint when dropping an endpoint

2013-10-11 Thread Sarah Sharp
On Fri, Oct 11, 2013 at 07:30:17PM +0300, Xenia Ragiadakou wrote: On 10/11/2013 11:40 AM, Xenia Ragiadakou wrote: [snip] The main reasons that made me come to this conclusion was the fact that Context Entries by being updated with a value other than the last valid endpoint will be

Re: [PATCH 2/2] xhci: fix last valid endpoint when dropping an endpoint

2013-10-11 Thread Xenia Ragiadakou
On 10/11/2013 09:26 PM, Sarah Sharp wrote: On Fri, Oct 11, 2013 at 07:30:17PM +0300, Xenia Ragiadakou wrote: [snip] To test if a smaller value will cause a problem, I reset first endpoint 4 and, then, endpoint 3 so that the Context Entries field get updated with the value 3 while the actual

Re: [PATCH 2/2] xhci: fix last valid endpoint when dropping an endpoint

2013-10-10 Thread Sarah Sharp
Hi Xenia, On Mon, Oct 07, 2013 at 06:52:39PM +0300, Xenia Ragiadakou wrote: The previous patch on the endpoint reset uses the already implemented function xhci_drop_endpoint() to reduce code duplication. However, the way that xhci updates the last valid endpoint in the Input Slot Context, when

[PATCH 2/2] xhci: fix last valid endpoint when dropping an endpoint

2013-10-07 Thread Xenia Ragiadakou
The previous patch on the endpoint reset uses the already implemented function xhci_drop_endpoint() to reduce code duplication. However, the way that xhci updates the last valid endpoint in the Input Slot Context, when an endpoint is dropped, can lead to incosistent value for the last valid