Re: [PATCH 2/2 v6] typec: tcpm: Only request matching pdos

2017-11-15 Thread Guenter Roeck
On 11/15/2017 05:01 PM, Badhri Jagan Sridharan wrote: On Tue, Nov 14, 2017 at 9:05 AM, Guenter Roeck wrote: [ ... ] Reviewed-by: Guenter Roeck /* Though I really dislike this new-world comment style. * It hurts my eyes and distracts me from the

Re: [PATCH 2/2 v6] typec: tcpm: Only request matching pdos

2017-11-15 Thread Badhri Jagan Sridharan
On Tue, Nov 14, 2017 at 9:05 AM, Guenter Roeck wrote: > On Sun, Nov 12, 2017 at 04:23:17PM -0800, Badhri Jagan Sridharan wrote: >> At present, TCPM code assumes that local device supports >> variable/batt pdos and always selects the pdo with highest >> possible power within

Re: [PATCH 2/2 v6] typec: tcpm: Only request matching pdos

2017-11-14 Thread Guenter Roeck
On Sun, Nov 12, 2017 at 04:23:17PM -0800, Badhri Jagan Sridharan wrote: > At present, TCPM code assumes that local device supports > variable/batt pdos and always selects the pdo with highest > possible power within the board limit. This assumption > might not hold good for all devices. To

[PATCH 2/2 v6] typec: tcpm: Only request matching pdos

2017-11-12 Thread Badhri Jagan Sridharan
At present, TCPM code assumes that local device supports variable/batt pdos and always selects the pdo with highest possible power within the board limit. This assumption might not hold good for all devices. To overcome this, this patch makes TCPM only accept a source_pdo when there is a matching