Re: [PATCH 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-21 Thread Yoshihiro Shimoda
(2014/05/21 17:04), Arnd Bergmann wrote: > On Wednesday 21 May 2014 16:54:00 Yoshihiro Shimoda wrote: >> >> (2014/05/20 19:11), Arnd Bergmann wrote: >>> On Monday 19 May 2014 19:08:05 Yoshihiro Shimoda wrote: #include "xhci.h" #include "xhci-mvebu.h" +#include "xhci-rcar.h" >

Re: [PATCH 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-21 Thread Arnd Bergmann
On Wednesday 21 May 2014 16:54:00 Yoshihiro Shimoda wrote: > > (2014/05/20 19:11), Arnd Bergmann wrote: > > On Monday 19 May 2014 19:08:05 Yoshihiro Shimoda wrote: > >> > >> #include "xhci.h" > >> #include "xhci-mvebu.h" > >> +#include "xhci-rcar.h" > >> > >> static void xhci_plat_quirks(struct

Re: [PATCH 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-21 Thread Yoshihiro Shimoda
Hi Geert-san, Thank you for the reply again. (2014/05/20 19:14), Geert Uytterhoeven wrote: > Hi Shimoda-san, > > On Tue, May 20, 2014 at 11:35 AM, Yoshihiro Shimoda > wrote: >> (2014/05/19 20:58), Geert Uytterhoeven wrote: >>> On Mon, May 19, 2014 at 12:08 PM, Yoshihiro Shimoda >>> wrote: >> <

Re: [PATCH 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-21 Thread Yoshihiro Shimoda
Hi, (2014/05/20 19:11), Arnd Bergmann wrote: > On Monday 19 May 2014 19:08:05 Yoshihiro Shimoda wrote: >> >> #include "xhci.h" >> #include "xhci-mvebu.h" >> +#include "xhci-rcar.h" >> >> static void xhci_plat_quirks(struct device *dev, struct xhci_hcd *xhci) >> { >> @@ -39,6 +40,12 @@ static i

Re: [PATCH 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-20 Thread Geert Uytterhoeven
Hi Shimoda-san, On Tue, May 20, 2014 at 11:35 AM, Yoshihiro Shimoda wrote: > (2014/05/19 20:58), Geert Uytterhoeven wrote: >> On Mon, May 19, 2014 at 12:08 PM, Yoshihiro Shimoda >> wrote: > < snip > >>> +config USB_XHCI_RCAR >>> + tristate "xHCI support for Renesas R-Car SoCs" >>> +

Re: [PATCH 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-20 Thread Arnd Bergmann
On Monday 19 May 2014 19:08:05 Yoshihiro Shimoda wrote: > > #include "xhci.h" > #include "xhci-mvebu.h" > +#include "xhci-rcar.h" > > static void xhci_plat_quirks(struct device *dev, struct xhci_hcd *xhci) > { > @@ -39,6 +40,12 @@ static int xhci_plat_setup(struct usb_hcd *hcd) > > static i

Re: [PATCH 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-20 Thread Yoshihiro Shimoda
Hello, (2014/05/19 21:14), Sergei Shtylyov wrote: > Hello. > > On 19-05-2014 14:08, Yoshihiro Shimoda wrote: < snip > >> static int xhci_plat_start(struct usb_hcd *hcd) >> { >> +struct device_node *of_node = hcd->self.controller->of_node; >> + >> +if (of_device_is_compatible(of_node,

Re: [PATCH 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-20 Thread Yoshihiro Shimoda
Hi Geert-san, (2014/05/19 20:58), Geert Uytterhoeven wrote: > Hi Shimoda-san, > > On Mon, May 19, 2014 at 12:08 PM, Yoshihiro Shimoda > wrote: < snip > >> +config USB_XHCI_RCAR >> + tristate "xHCI support for Renesas R-Car SoCs" >> + select USB_XHCI_PLATFORM >> + depends on ARC

Re: [PATCH 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-20 Thread Yoshihiro Shimoda
Hi Magnus-san, (2014/05/19 19:21), Magnus Damm wrote: > Hi Shimoda-san, > > Thanks for your patches, I did however find one typo below: > > On Mon, May 19, 2014 at 7:08 PM, Yoshihiro Shimoda > wrote: < snip > >> static int xhci_plat_start(struct usb_hcd *hcd) >> { >> + struct device_nod

Re: [PATCH 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-19 Thread Sergei Shtylyov
Hello. On 19-05-2014 14:08, Yoshihiro Shimoda wrote: The R-Car H2 and M2 SoCs come with an xHCI controller that requires some specific initilization related to the firmware downloading and some specific registers. This patch adds the support for this special configuration as an xHCI quirk execu

Re: [PATCH 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-19 Thread Geert Uytterhoeven
Hi Shimoda-san, On Mon, May 19, 2014 at 12:08 PM, Yoshihiro Shimoda wrote: > The R-Car H2 and M2 SoCs come with an xHCI controller that requires > some specific initilization related to the firmware downloading and > some specific registers. This patch adds the support for this special > configur

Re: [PATCH 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-19 Thread Magnus Damm
Hi Shimoda-san, Thanks for your patches, I did however find one typo below: On Mon, May 19, 2014 at 7:08 PM, Yoshihiro Shimoda wrote: > The R-Car H2 and M2 SoCs come with an xHCI controller that requires > some specific initilization related to the firmware downloading and > some specific regist

[PATCH 2/3] usb: host: xhci-plat: add support for the R-Car H2 and M2 xHCI controllers

2014-05-19 Thread Yoshihiro Shimoda
The R-Car H2 and M2 SoCs come with an xHCI controller that requires some specific initilization related to the firmware downloading and some specific registers. This patch adds the support for this special configuration as an xHCI quirk executed during probe and start. Signed-off-by: Yoshihiro Shi