[PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue

2015-09-18 Thread eu
From: "Felipe F. Tonello" f_midi is not checking weather the is an error on usb_ep_queue request, ignoring potential problems, such as memory leaks. Signed-off-by: Felipe F. Tonello --- Changes for v2: - Update code style. drivers/usb/gadget/function/f_midi.c | 12 +--- 1 file chan

[PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue

2015-09-18 Thread eu
From: "Felipe F. Tonello" f_midi is not checking whether there is an error on usb_ep_queue request, ignoring potential problems, such as memory leaks. Signed-off-by: Felipe F. Tonello --- Changes for v2: - Update code style. Changes for v3: - Use ip_ep instead of out_ep. Fixed typo in com

Re: [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue

2015-09-18 Thread Felipe Tonello
On Fri, Sep 18, 2015 at 6:30 PM, wrote: > From: "Felipe F. Tonello" > > f_midi is not checking weather the is an error on usb_ep_queue > request, ignoring potential problems, such as memory leaks. > > Signed-off-by: Felipe F. Tonello > --- > > Changes for v2: > - Update code style. > > drive

Re: [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue

2015-09-21 Thread Felipe Tonello
Hi Balbi, On Fri, Sep 18, 2015 at 6:36 PM, wrote: > From: "Felipe F. Tonello" > > f_midi is not checking whether there is an error on usb_ep_queue > request, ignoring potential problems, such as memory leaks. > > Signed-off-by: Felipe F. Tonello > --- > > Changes for v2: > - Update code styl

Re: [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue

2015-09-21 Thread Felipe Balbi
Hi, On Mon, Sep 21, 2015 at 10:21:31AM +0100, Felipe Tonello wrote: > Hi Balbi, > > On Fri, Sep 18, 2015 at 6:36 PM, wrote: > > From: "Felipe F. Tonello" > > > > f_midi is not checking whether there is an error on usb_ep_queue > > request, ignoring potential problems, such as memory leaks. > >

Re: [PATCH 3/3] usb: gadget: f_midi: check for error on usb_ep_queue

2015-09-21 Thread Peter Chen
On Mon, Sep 21, 2015 at 11:04:42PM -0500, Felipe Balbi wrote: > Hi, > > On Mon, Sep 21, 2015 at 10:21:31AM +0100, Felipe Tonello wrote: > > Hi Balbi, > > > > On Fri, Sep 18, 2015 at 6:36 PM, wrote: > > > From: "Felipe F. Tonello" > > > > > > f_midi is not checking whether there is an error on