Getting rid of kref seems sensible to me. Reference counting used to
be needed because sharing of fsg_common among multiple USB function
instances was handled by fsg. Now this is handled by configfs layer
and I don’t think the kref is necessary any more.
2018-06-14 19:23 GMT+01:00 Jaejoong Kim :
>
On Fri, 15 Jun 2018, Jaejoong Kim wrote:
> Thanks for the review it.
>
> 2018년 6월 14일 (목) 오후 11:48, Alan Stern 님이 작성:
> >
> > On Thu, 14 Jun 2018, Jaejoong Kim wrote:
> >
> > > Removing EXPORT_SYMBOL_GPL from kref_{put, get} since it is used
> > > only in f_mass_storage
> > >
> > > Signed-off-by:
2018년 6월 15일 (금) 오전 3:14, Sergei Shtylyov
님이 작성:
>
> Hello!
>
> On 06/14/2018 12:23 PM, Jaejoong Kim wrote:
>
> > Removing EXPORT_SYMBOL_GPL from kref_{put, get} since it is used
>
>I thought you removed the exports from the real kref_{get|put}(). :-)
> Your patch subject and description are si
Thanks for the review it.
2018년 6월 14일 (목) 오후 11:48, Alan Stern 님이 작성:
>
> On Thu, 14 Jun 2018, Jaejoong Kim wrote:
>
> > Removing EXPORT_SYMBOL_GPL from kref_{put, get} since it is used
> > only in f_mass_storage
> >
> > Signed-off-by: Jaejoong Kim
>
> This is only a partial solution. In fact,
Hello!
On 06/14/2018 12:23 PM, Jaejoong Kim wrote:
> Removing EXPORT_SYMBOL_GPL from kref_{put, get} since it is used
I thought you removed the exports from the real kref_{get|put}(). :-)
Your patch subject and description are simply misleading the way they are
written.
> only in f_mass_stor
On Thu, 14 Jun 2018, Jaejoong Kim wrote:
> Removing EXPORT_SYMBOL_GPL from kref_{put, get} since it is used
> only in f_mass_storage
>
> Signed-off-by: Jaejoong Kim
This is only a partial solution. In fact, fsg_common_get() isn't used
anywhere, and fsg_common_put() is used in only one place.
Removing EXPORT_SYMBOL_GPL from kref_{put, get} since it is used
only in f_mass_storage
Signed-off-by: Jaejoong Kim
---
drivers/usb/gadget/function/f_mass_storage.c | 6 ++
drivers/usb/gadget/function/f_mass_storage.h | 4
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/d
