Re: [PATCH 3/6] USB: move many drivers to use DEVICE_ATTR_WO

2018-01-23 Thread Johan Hovold
On Tue, Jan 23, 2018 at 11:24:07AM +0100, Greg Kroah-Hartman wrote: > Instead of "open coding" a DEVICE_ATTR() define, use the > DEVICE_ATTR_WO() macro instead, which does everything properly instead. > > This does require a few static functions to be renamed to work properly, > but thanks to a sc

Re: [PATCH 3/6] USB: move many drivers to use DEVICE_ATTR_WO

2018-01-23 Thread Shuah Khan
On 01/23/2018 03:24 AM, Greg Kroah-Hartman wrote: > Instead of "open coding" a DEVICE_ATTR() define, use the > DEVICE_ATTR_WO() macro instead, which does everything properly instead. > > This does require a few static functions to be renamed to work properly, > but thanks to a script from Joe Perc

Re: [PATCH 3/6] USB: move many drivers to use DEVICE_ATTR_WO

2018-01-23 Thread Felipe Balbi
Greg Kroah-Hartman writes: > Instead of "open coding" a DEVICE_ATTR() define, use the > DEVICE_ATTR_WO() macro instead, which does everything properly instead. > > This does require a few static functions to be renamed to work properly, > but thanks to a script from Joe Perches, this was easily d

[PATCH 3/6] USB: move many drivers to use DEVICE_ATTR_WO

2018-01-23 Thread Greg Kroah-Hartman
Instead of "open coding" a DEVICE_ATTR() define, use the DEVICE_ATTR_WO() macro instead, which does everything properly instead. This does require a few static functions to be renamed to work properly, but thanks to a script from Joe Perches, this was easily done. Reported-by: Joe Perches Cc: Pe