[PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-10 Thread Vivek Gautam
Some PHY controllers may need to tune PHY post-initialization, so that the PHY consumers can call phy-tuning at appropriate point of time. Signed-off-by: vivek Gautam --- drivers/phy/phy-core.c | 20 include/linux/phy/phy.h |7 +++ 2 files changed, 27 insertions(+

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-10 Thread Heikki Krogerus
Hi, On Tue, Dec 10, 2013 at 04:25:23PM +0530, Vivek Gautam wrote: > Some PHY controllers may need to tune PHY post-initialization, > so that the PHY consumers can call phy-tuning at appropriate > point of time. > > Signed-off-by: vivek Gautam > --- > drivers/phy/phy-core.c | 20 +

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-10 Thread Vivek Gautam
Hi, On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus wrote: > Hi, Thanks for reviewing this. > > On Tue, Dec 10, 2013 at 04:25:23PM +0530, Vivek Gautam wrote: >> Some PHY controllers may need to tune PHY post-initialization, >> so that the PHY consumers can call phy-tuning at appropriate >> po

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Heikki Krogerus
Hi, On Wed, Dec 11, 2013 at 12:08:04PM +0530, Vivek Gautam wrote: > On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus > > I think "setup" instead of "tune" is much more clear and reusable. > > I think "setup" will look more like first time setting up the phy, > which is rather served by "init" cal

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Kishon Vijay Abraham I
On Wednesday 11 December 2013 12:08 PM, Vivek Gautam wrote: > Hi, > > > On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus > wrote: >> Hi, > > Thanks for reviewing this. > >> >> On Tue, Dec 10, 2013 at 04:25:23PM +0530, Vivek Gautam wrote: >>> Some PHY controllers may need to tune PHY post-initi

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Vivek Gautam
Hi, On Wed, Dec 11, 2013 at 1:39 PM, Heikki Krogerus wrote: > Hi, > > On Wed, Dec 11, 2013 at 12:08:04PM +0530, Vivek Gautam wrote: >> On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus >> > I think "setup" instead of "tune" is much more clear and reusable. >> >> I think "setup" will look more lik

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Vivek Gautam
Hi Kishon, On Wed, Dec 11, 2013 at 1:47 PM, Kishon Vijay Abraham I wrote: > On Wednesday 11 December 2013 12:08 PM, Vivek Gautam wrote: >> Hi, >> >> >> On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus >> wrote: >>> Hi, >> >> Thanks for reviewing this. >> >>> >>> On Tue, Dec 10, 2013 at 04:25:23

Re: [PATCH RFC 1/4] phy: Add provision for tuning phy.

2013-12-11 Thread Heikki Krogerus
Hi again, On Wed, Dec 11, 2013 at 02:02:43PM +0530, Vivek Gautam wrote: > On Wed, Dec 11, 2013 at 1:39 PM, Heikki Krogerus > wrote: > > On Wed, Dec 11, 2013 at 12:08:04PM +0530, Vivek Gautam wrote: > >> On Tue, Dec 10, 2013 at 7:31 PM, Heikki Krogerus > >> > I think "setup" instead of "tune" is m