Re: [PATCH v2] usb: core: remove local_irq_save/restore around urb->complete

2016-10-04 Thread Bin Liu
On Tue, Oct 04, 2016 at 02:50:09PM -0400, Alan Stern wrote: > On Tue, 4 Oct 2016, Bin Liu wrote: > > > local_irq_save() disables irq completely on non-SMP which causes the > > hard interrupt handler unable to serve interrupts, which loses the > > benefit that the giveback tasklet brings in usb_hcd

Re: [PATCH v2] usb: core: remove local_irq_save/restore around urb->complete

2016-10-04 Thread Alan Stern
On Tue, 4 Oct 2016, Bin Liu wrote: > local_irq_save() disables irq completely on non-SMP which causes the > hard interrupt handler unable to serve interrupts, which loses the > benefit that the giveback tasklet brings in usb_hcd_giveback_urb(). It doesn't lose all the benefit. Interrupts are sti

[PATCH v2] usb: core: remove local_irq_save/restore around urb->complete

2016-10-04 Thread Bin Liu
local_irq_save() disables irq completely on non-SMP which causes the hard interrupt handler unable to serve interrupts, which loses the benefit that the giveback tasklet brings in usb_hcd_giveback_urb(). One example of the issues caused by this disabling local irq is that urb->complete in uvc driv