Re: [PATCH v2] usb: musb: gadget: Fix big-endian arch issue

2018-08-27 Thread Bin Liu
Hi, On Fri, Aug 03, 2018 at 09:03:36AM +, Alexey Spirkov wrote: > Existing code is not applicable to big-endian machines > ctrlrequest fields received in USB endian - i.e. in little-endian > and should be converted to cpu endianness before usage. > > Signed-off-by: Alexey Spirkov > --- >

RE: [PATCH v2] usb: musb: gadget: Fix big-endian arch issue

2018-08-03 Thread Alexey Spirkov
, August 3, 2018 12:17 PM To: Alexey Spirkov Cc: Bin Liu ; Greg Kroah-Hartman ; linux-usb@vger.kernel.org; and...@ncrmnt.org Subject: Re: [PATCH v2] usb: musb: gadget: Fix big-endian arch issue On Fri, Aug 3, 2018 at 12:03 PM, Alexey Spirkov wrote: > Existing code is not applicable to big-end

Re: [PATCH v2] usb: musb: gadget: Fix big-endian arch issue

2018-08-03 Thread Andy Shevchenko
On Fri, Aug 3, 2018 at 12:03 PM, Alexey Spirkov wrote: > Existing code is not applicable to big-endian machines > ctrlrequest fields received in USB endian - i.e. in little-endian > and should be converted to cpu endianness before usage. > - epnum = (u8) ctrlrequest->wIndex; > +

[PATCH v2] usb: musb: gadget: Fix big-endian arch issue

2018-08-03 Thread Alexey Spirkov
Existing code is not applicable to big-endian machines ctrlrequest fields received in USB endian - i.e. in little-endian and should be converted to cpu endianness before usage. Signed-off-by: Alexey Spirkov --- drivers/usb/musb/musb_gadget_ep0.c | 29 ++--- 1 file