Re: [PATCH v2] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-09-11 Thread Andrew Lunn
> > I need 115200, since that is what most of my development systems use > > for the serial console. Will the normal path, tty_get_baud_rate(tty), > > handle baud rates above 57600? > > Yes, cfsetospeed can be used up to 4Mbaud for example. > > > The hardware is also capable of "custom divisor" a

Re: [PATCH v2] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-09-11 Thread Johan Hovold
On Tue, Sep 10, 2013 at 07:24:35PM +0200, Andrew Lunn wrote: > Hi Johan > > Thanks for your quick comments. I hopefully have more time to work on > this code now, so v3 will not take as long as v2 did. Great. It shouldn't be that much more work. > > > +/* This structure holds all of the local p

Re: [PATCH v2] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-09-10 Thread Andrew Lunn
Hi Johan Thanks for your quick comments. I hopefully have more time to work on this code now, so v3 will not take as long as v2 did. > > All data transfers are made on port0, yet the locks are taken on PortN. > > urb->context points to PortN, even though the URL is for port0. > > You probably me

[PATCH v2] usb-serial: Moxa UPORT 12XX/14XX/16XX driver

2013-09-05 Thread Andrew Lunn
Add a driver which supports the following Moxa USB to serial converters: * 2 ports : UPort 1250, UPort 1250I * 4 ports : UPort 1410, UPort 1450, UPort 1450I * 8 ports : UPort 1610-8, UPort 1650-8 * 16 ports : UPort 1610-16, UPort 1650-16 The UPORT devices don't directy fit t